[PATCH] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[PATCH] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[Dirk Chen via B4 Relay]

From: Dirk Chen <dirkchen@amd.com>

Add Atmel 24C2048 EEPROMs on i2c0 and i2c1 to support retimer
configuration. Follow the same compatible string usage as the
Facebook Harma platform to maintain consistency across Meta boards.

Signed-off-by: Dirk Chen <dirkchen@amd.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
index 221af858cb6b..b8d248d99d7c 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
@@ -328,6 +328,12 @@ i2c0mux0ch3: i2c@3 {
 			#size-cells = <0>;
 		};
 	};
+
+	eeprom@50 {
+		compatible = "atmel,24c2048";
+		reg = <0x50>;
+		pagesize = <128>;
+	};
 };
 
 // R Bridge Board
@@ -362,6 +368,12 @@ i2c1mux0ch3: i2c@3 {
 			#size-cells = <0>;
 		};
 	};
+
+	eeprom@50 {
+		compatible = "atmel,24c2048";
+		reg = <0x50>;
+		pagesize = <128>;
+	};
 };
 
 // MB - E1.S

---
base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f
change-id: 20260202-b4-anacapa-dts-fix-207ffe9a3b0c

Best regards,
-- 
Dirk Chen <dirkchen@amd.com>

Re: [PATCH] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[Andrew Jeffery]

On Mon, 2026-02-02 at 10:29 +0800, Dirk Chen via B4 Relay wrote:
> From: Dirk Chen <dirkchen@amd.com>
> 
> Add Atmel 24C2048 EEPROMs on i2c0 and i2c1 to support retimer
> configuration. Follow the same compatible string usage as the
> Facebook Harma platform to maintain consistency across Meta boards.

This description seems surprising.

Does the change reflect the hardware or not? What's the significance of
the consistency comment if so?

Andrew

> 
> Signed-off-by: Dirk Chen <dirkchen@amd.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts | 12
> ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> index 221af858cb6b..b8d248d99d7c 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> @@ -328,6 +328,12 @@ i2c0mux0ch3: i2c@3 {
>  			#size-cells = <0>;
>  		};
>  	};
> +
> +	eeprom@50 {
> +		compatible = "atmel,24c2048";
> +		reg = <0x50>;
> +		pagesize = <128>;
> +	};
>  };
>  
>  // R Bridge Board
> @@ -362,6 +368,12 @@ i2c1mux0ch3: i2c@3 {
>  			#size-cells = <0>;
>  		};
>  	};
> +
> +	eeprom@50 {
> +		compatible = "atmel,24c2048";
> +		reg = <0x50>;
> +		pagesize = <128>;
> +	};
>  };
>  
>  // MB - E1.S
> 
> ---
> base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f
> change-id: 20260202-b4-anacapa-dts-fix-207ffe9a3b0c
> 
> Best regards,

RE: [PATCH] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[Chen, Dirk]

[AMD Official Use Only - AMD Internal Distribution Only]

> This description seems surprising.
> Does the change reflect the hardware or not? What's the significance of the consistency comment if so?
> Andrew

Hi Andrew,

Thanks for the review.
Yes, the change reflects the actual hardware. The Anacapa board has two EEPROMs on i2c0 and i2c1 for retimer configuration.
The mention of the Harma platform was intended to explain why I chose the "atmel,24c2048" compatible string
 (as it was previously accepted for similar hardware in that platform), but I can see how that caused confusion.

I will send a v2 with a clearer description.

Best regards,
Dirk