From: David Howells <dhowells@redhat.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: dhowells@redhat.com, "David S. Miller" <davem@davemloft.net>,
linux-afs@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: rxrpc: mark expected switch fall-throughs
Date: Thu, 19 Oct 2017 22:16:56 +0100 [thread overview]
Message-ID: <32524.1508447816@warthog.procyon.org.uk> (raw)
In-Reply-To: <20171019185016.GA18770@embeddedor.com>
Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
> + /* fall through */
All new comments in rxrpc should begin with a capital letter; I'm switching to
this as I modify the lines with comments on. Fix checkpatch or gcc or
whatever takes -Wimplicit-fallthrough to stop being silly.
> - /* Fall through */
> -
> + /* fall through */
No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's
there for a reason.
> + /* fall through */
Capital 'F'.
> -
> + /* fall through */
Don't remove the blank line. Capital 'F'.
> + /* fall through */
Capital 'F'.
David
next prev parent reply other threads:[~2017-10-19 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 18:50 Gustavo A. R. Silva
2017-10-19 21:16 ` David Howells [this message]
2017-10-19 21:23 ` Gustavo A. R. Silva
2017-10-19 21:44 ` David Howells
2017-10-19 21:50 ` Gustavo A. R. Silva
2017-10-19 21:54 ` [PATCH v2] " Gustavo A. R. Silva
2017-10-24 9:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32524.1508447816@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®