From: Paul Menzel <pmenzel+amd-gfx@molgen.mpg.de>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>
Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
Andrew Jiang <Andrew.Jiang@amd.com>,
Tony Cheng <Tony.Cheng@amd.com>,
Harry Wentland <harry.wentland@amd.com>
Subject: [PATCH] drm/amd/display: Remove check for 0 kHz clock values
Date: Mon, 15 Jul 2019 12:34:51 +0200 [thread overview]
Message-ID: <32619ed4-8a27-4e9c-5b99-ba826f1d163e@molgen.mpg.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1679 bytes --]
From 09c1952466752033722b02d9c7e5532e1982f6d9 Mon Sep 17 00:00:00 2001
From: Paul Menzel <pmenzel@molgen.mpg.de>
Date: Sat, 13 Jul 2019 20:33:49 +0200
This basically reverts commit 00893681a0ff4 (drm/amd/display: Reject
PPLib clock values if they are invalid).
0 kHz values are a thing on at least the boards below.
1. MSI MS-7A37/B350M MORTAR (MS-7A37), BIOS 1.G1 05/17/2018
2. MSI B450M Mortar, 2400G on 4.19.8
3. Gigabyte Technology Co., Ltd. X470 AORUS ULTRA GAMING/X470 AORUS
ULTRA GAMING-CF, BIOS F30 04/16/2019
Asserting instead of giving a useful error message to the user, so they
can understand what is going on and how to possible fix things, might be
good for development, but is a bad user experience, so should not be on
production systems. So, remove the check for now.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=107296
Tested: MSI MS-7A37/B350M MORTAR (MS-7A37)
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c b/drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c
index 1b4b51657f5e..edaaae5754fe 100644
--- a/drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c
+++ b/drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c
@@ -1362,11 +1362,6 @@ static bool verify_clock_values(struct dm_pp_clock_levels_with_voltage *clks)
if (clks->num_levels == 0)
return false;
- for (i = 0; i < clks->num_levels; i++)
- /* Ensure that the result is sane */
- if (clks->data[i].clocks_in_khz == 0)
- return false;
-
return true;
}
--
2.22.0
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
next reply other threads:[~2019-07-15 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 10:34 Paul Menzel [this message]
2019-07-15 12:57 ` Kazlauskas, Nicholas
2019-07-15 13:10 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32619ed4-8a27-4e9c-5b99-ba826f1d163e@molgen.mpg.de \
--to=pmenzel+amd-gfx@molgen.mpg.de \
--cc=Andrew.Jiang@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Tony.Cheng@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®