[PATCH] ASoC: cs42l42: Convert comma to semicolon

[PATCH] ASoC: cs42l42: Convert comma to semicolon

[Chen Ni]

Replace a comma between expression statements by a semicolon.

Fixes: 90f6a2a20bd2 ("ASoC: cs42l42: Add SoundWire support")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 sound/soc/codecs/cs42l42-sdw.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/sound/soc/codecs/cs42l42-sdw.c b/sound/soc/codecs/cs42l42-sdw.c
index 94a66a325303..29891c1f6bec 100644
--- a/sound/soc/codecs/cs42l42-sdw.c
+++ b/sound/soc/codecs/cs42l42-sdw.c
@@ -323,15 +323,15 @@ static int cs42l42_sdw_read_prop(struct sdw_slave *peripheral)
 	prop->scp_int1_mask = SDW_SCP_INT1_BUS_CLASH | SDW_SCP_INT1_PARITY;
 
 	/* DP1 - capture */
-	ports[0].num = CS42L42_SDW_CAPTURE_PORT,
-	ports[0].type = SDW_DPN_FULL,
-	ports[0].ch_prep_timeout = 10,
+	ports[0].num = CS42L42_SDW_CAPTURE_PORT;
+	ports[0].type = SDW_DPN_FULL;
+	ports[0].ch_prep_timeout = 10;
 	prop->src_dpn_prop = &ports[0];
 
 	/* DP2 - playback */
-	ports[1].num = CS42L42_SDW_PLAYBACK_PORT,
-	ports[1].type = SDW_DPN_FULL,
-	ports[1].ch_prep_timeout = 10,
+	ports[1].num = CS42L42_SDW_PLAYBACK_PORT;
+	ports[1].type = SDW_DPN_FULL;
+	ports[1].ch_prep_timeout = 10;
 	prop->sink_dpn_prop = &ports[1];
 
 	return 0;
-- 
2.25.1

Re: [PATCH] ASoC: cs42l42: Convert comma to semicolon

[Dragan Simic]

On 2024-07-16 04:53, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: 90f6a2a20bd2 ("ASoC: cs42l42: Add SoundWire support")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Nice catch, thanks!

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ---
>  sound/soc/codecs/cs42l42-sdw.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/sound/soc/codecs/cs42l42-sdw.c 
> b/sound/soc/codecs/cs42l42-sdw.c
> index 94a66a325303..29891c1f6bec 100644
> --- a/sound/soc/codecs/cs42l42-sdw.c
> +++ b/sound/soc/codecs/cs42l42-sdw.c
> @@ -323,15 +323,15 @@ static int cs42l42_sdw_read_prop(struct
> sdw_slave *peripheral)
>  	prop->scp_int1_mask = SDW_SCP_INT1_BUS_CLASH | SDW_SCP_INT1_PARITY;
> 
>  	/* DP1 - capture */
> -	ports[0].num = CS42L42_SDW_CAPTURE_PORT,
> -	ports[0].type = SDW_DPN_FULL,
> -	ports[0].ch_prep_timeout = 10,
> +	ports[0].num = CS42L42_SDW_CAPTURE_PORT;
> +	ports[0].type = SDW_DPN_FULL;
> +	ports[0].ch_prep_timeout = 10;
>  	prop->src_dpn_prop = &ports[0];
> 
>  	/* DP2 - playback */
> -	ports[1].num = CS42L42_SDW_PLAYBACK_PORT,
> -	ports[1].type = SDW_DPN_FULL,
> -	ports[1].ch_prep_timeout = 10,
> +	ports[1].num = CS42L42_SDW_PLAYBACK_PORT;
> +	ports[1].type = SDW_DPN_FULL;
> +	ports[1].ch_prep_timeout = 10;
>  	prop->sink_dpn_prop = &ports[1];
> 
>  	return 0;

Re: [PATCH] ASoC: cs42l42: Convert comma to semicolon

[Richard Fitzgerald]

On 16/07/2024 03:53, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: 90f6a2a20bd2 ("ASoC: cs42l42: Add SoundWire support")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   sound/soc/codecs/cs42l42-sdw.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/sound/soc/codecs/cs42l42-sdw.c b/sound/soc/codecs/cs42l42-sdw.c
> index 94a66a325303..29891c1f6bec 100644
> --- a/sound/soc/codecs/cs42l42-sdw.c
> +++ b/sound/soc/codecs/cs42l42-sdw.c
> @@ -323,15 +323,15 @@ static int cs42l42_sdw_read_prop(struct sdw_slave *peripheral)
>   	prop->scp_int1_mask = SDW_SCP_INT1_BUS_CLASH | SDW_SCP_INT1_PARITY;
>   
>   	/* DP1 - capture */
> -	ports[0].num = CS42L42_SDW_CAPTURE_PORT,
> -	ports[0].type = SDW_DPN_FULL,
> -	ports[0].ch_prep_timeout = 10,
> +	ports[0].num = CS42L42_SDW_CAPTURE_PORT;
> +	ports[0].type = SDW_DPN_FULL;
> +	ports[0].ch_prep_timeout = 10;
>   	prop->src_dpn_prop = &ports[0];
>   
>   	/* DP2 - playback */
> -	ports[1].num = CS42L42_SDW_PLAYBACK_PORT,
> -	ports[1].type = SDW_DPN_FULL,
> -	ports[1].ch_prep_timeout = 10,
> +	ports[1].num = CS42L42_SDW_PLAYBACK_PORT;
> +	ports[1].type = SDW_DPN_FULL;
> +	ports[1].ch_prep_timeout = 10;
>   	prop->sink_dpn_prop = &ports[1];
>   
>   	return 0;
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>

Re: [PATCH] ASoC: cs42l42: Convert comma to semicolon

[Mark Brown]

On Tue, 16 Jul 2024 10:53:07 +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs42l42: Convert comma to semicolon
      commit: 275d57ae441f34749cbf8621441ce2148f83d5e6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark