Re: [PATCH] most: fix kernel-doc warnings

[<Christian.Gromm@microchip.com>]

On Tue, 2023-01-31 at 10:46 +0100, Greg KH wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, Jan 23, 2023 at 10:31:56AM +0000, Christian.Gromm@microchip.com wrote:
> >
> > On Thu, 2023-01-19 at 17:15 +0100, Greg Kroah-Hartman wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > >
> > > On Thu, Jan 12, 2023 at 10:39:47PM -0800, Randy Dunlap wrote:
> > > > Fix various W=1 kernel-doc warnings in drivers/most/:
> > > >
> > > > drivers/most/most_usb.c:669: warning: Excess function parameter 'data' description in 'link_stat_timer_handler'
> > > > drivers/most/most_usb.c:769: warning: cannot understand function prototype: 'const struct file_operations hdm_usb_fops = '
> > > > drivers/most/most_usb.c:776: warning: cannot understand function prototype: 'const struct usb_device_id usbid[] = '
> > > > drivers/most/most_cdev.c:301: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > > >  * Initialization of struct file_operations
> > > > drivers/most/most_cdev.c:414: warning: Function parameter or member 'args' not described in 'comp_probe'
> > > > drivers/most/most_snd.c:56: warning: Function parameter or member 'pcm_hardware' not described in 'channel'
> > > > drivers/most/most_snd.c:56: warning: Function parameter or member 'copy_fn' not described in 'channel'
> > > > drivers/most/most_snd.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > > >  * Initialization of struct snd_pcm_ops
> > > > drivers/most/most_snd.c:514: warning: Function parameter or member 'device_name' not described in 'audio_probe_channel'
> > > > drivers/most/most_snd.c:703: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > > >  * Initialization of the struct most_component
> > > >
> > > >
> > > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > > > Cc: Christian Gromm <christian.gromm@microchip.com>
> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > ---
> > > > Also: what does MOST mean? Can that be added to drivers/most/Kconfig,
> > > >     in a prompt or help text?
> > > > Also: how about a MAINTAINERS entry for drivers/most/?
> > >
> > > That would be good, Christian, can you send a patch for that?
> > >
> >
> > Sure, I can do that. But since I am not working for the automotive divison
> > within the company anymore I need to indentify the right person for that first.
> 
> Should we just remove these files if no one is using them anymore and
> there's no one to maintain them?
> 
No, the files should not be removed. We will come up with a maintainer shortly.

thanks,
Chris 


> thanks,
> 
> greg k-h