From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Christian Gromm <christian.gromm@microchip.com>
Subject: Re: [PATCH] most: fix kernel-doc warnings
Date: Thu, 19 Jan 2023 17:15:58 +0100 [thread overview]
Message-ID: <Y8lsvtoSYFj/8/U/@kroah.com> (raw)
In-Reply-To: <20230113063947.23174-1-rdunlap@infradead.org>
On Thu, Jan 12, 2023 at 10:39:47PM -0800, Randy Dunlap wrote:
> Fix various W=1 kernel-doc warnings in drivers/most/:
>
> drivers/most/most_usb.c:669: warning: Excess function parameter 'data' description in 'link_stat_timer_handler'
> drivers/most/most_usb.c:769: warning: cannot understand function prototype: 'const struct file_operations hdm_usb_fops = '
> drivers/most/most_usb.c:776: warning: cannot understand function prototype: 'const struct usb_device_id usbid[] = '
> drivers/most/most_cdev.c:301: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Initialization of struct file_operations
> drivers/most/most_cdev.c:414: warning: Function parameter or member 'args' not described in 'comp_probe'
> drivers/most/most_snd.c:56: warning: Function parameter or member 'pcm_hardware' not described in 'channel'
> drivers/most/most_snd.c:56: warning: Function parameter or member 'copy_fn' not described in 'channel'
> drivers/most/most_snd.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Initialization of struct snd_pcm_ops
> drivers/most/most_snd.c:514: warning: Function parameter or member 'device_name' not described in 'audio_probe_channel'
> drivers/most/most_snd.c:703: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Initialization of the struct most_component
>
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christian Gromm <christian.gromm@microchip.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Also: what does MOST mean? Can that be added to drivers/most/Kconfig,
> in a prompt or help text?
> Also: how about a MAINTAINERS entry for drivers/most/?
That would be good, Christian, can you send a patch for that?
thanks,
greg k-h
next prev parent reply other threads:[~2023-01-19 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 6:39 Randy Dunlap
2023-01-19 16:15 ` Greg Kroah-Hartman [this message]
2023-01-23 10:31 ` Christian.Gromm
2023-01-31 9:46 ` Greg KH
2023-02-02 8:16 ` Christian.Gromm
2023-02-07 14:04 ` Christian.Gromm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8lsvtoSYFj/8/U/@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christian.gromm@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®