mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manuel Ebner <manuelebnerli@mailbox.org>
To: Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	 Randy Dunlap <rdunlap@infradead.org>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: doc-guide: add hint to review patch
Date: Mon, 16 Nov 2026 10:38:16 +0100	[thread overview]
Message-ID: <32a4976792275c8ee903ca99728bae12bb3b9be3.camel@mailbox.org> (raw)
In-Reply-To: <87ik1x3zwg.fsf@trenco.lwn.net>

On Mon, 2026-11-16 at 02:10 -0700, Jonathan Corbet wrote:
> Manuel Ebner <manuelebnerli@mailbox.org> writes:
> 
> > For the case of a duplicate patch, review the other patch instead of
> > sending own patch.
> > 
> > Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> > ---
> >  Documentation/doc-guide/contributing.rst | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/doc-guide/contributing.rst b/Documentation/doc-guide/contributing.rst
> > index 46a44b39d6..ee2f896a21 100644
> > --- a/Documentation/doc-guide/contributing.rst
> > +++ b/Documentation/doc-guide/contributing.rst
> > @@ -129,7 +129,9 @@ looked like this::
> >  The entire process only took a few minutes.  Of course, I then found that
> >  somebody else had fixed it in a separate tree, highlighting another lesson:
> >  always check linux-next to see if a problem has been fixed before you dig
> > -into it.
> > +into it.  If the other patch isn't applied yet it's good to give it a
> > +'Reviewed-by:' tag to help it get applied.  This way your effort is not in
> > +vain.
> 
> Should we perhaps be explicit and say that the person involved should
> actually review the patch?

Makes sense. I'll change it to:

into it.  If the other patch isn't applied yet it's good to review it and
state that by replying with the 'Reviewed-by:' tag.  This helps getting the
patch applied, so your effort is not in vain after all.

Thanks
 Manuel
> 
> jon

      reply	other threads:[~2026-11-16  9:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  8:22 Manuel Ebner
2026-11-16  9:10 ` Jonathan Corbet
2026-11-16  9:38   ` Manuel Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32a4976792275c8ee903ca99728bae12bb3b9be3.camel@mailbox.org \
    --to=manuelebnerli@mailbox.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®