* [PATCH] docs: doc-guide: add hint to review patch
@ 2026-11-16 8:22 Manuel Ebner
2026-11-16 9:10 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: Manuel Ebner @ 2026-11-16 8:22 UTC (permalink / raw)
To: Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: Manuel Ebner, linux-doc, linux-kernel
For the case of a duplicate patch, review the other patch instead of
sending own patch.
Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
Documentation/doc-guide/contributing.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/doc-guide/contributing.rst b/Documentation/doc-guide/contributing.rst
index 46a44b39d6..ee2f896a21 100644
--- a/Documentation/doc-guide/contributing.rst
+++ b/Documentation/doc-guide/contributing.rst
@@ -129,7 +129,9 @@ looked like this::
The entire process only took a few minutes. Of course, I then found that
somebody else had fixed it in a separate tree, highlighting another lesson:
always check linux-next to see if a problem has been fixed before you dig
-into it.
+into it. If the other patch isn't applied yet it's good to give it a
+'Reviewed-by:' tag to help it get applied. This way your effort is not in
+vain.
Other fixes will take longer, especially those relating to structure
members or function parameters that lack documentation. In such cases, it
--
2.56.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: doc-guide: add hint to review patch
2026-11-16 8:22 [PATCH] docs: doc-guide: add hint to review patch Manuel Ebner
@ 2026-11-16 9:10 ` Jonathan Corbet
2026-11-16 9:38 ` Manuel Ebner
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Corbet @ 2026-11-16 9:10 UTC (permalink / raw)
To: Manuel Ebner, Shuah Khan, Randy Dunlap
Cc: Manuel Ebner, linux-doc, linux-kernel
Manuel Ebner <manuelebnerli@mailbox.org> writes:
> For the case of a duplicate patch, review the other patch instead of
> sending own patch.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
> Documentation/doc-guide/contributing.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/doc-guide/contributing.rst b/Documentation/doc-guide/contributing.rst
> index 46a44b39d6..ee2f896a21 100644
> --- a/Documentation/doc-guide/contributing.rst
> +++ b/Documentation/doc-guide/contributing.rst
> @@ -129,7 +129,9 @@ looked like this::
> The entire process only took a few minutes. Of course, I then found that
> somebody else had fixed it in a separate tree, highlighting another lesson:
> always check linux-next to see if a problem has been fixed before you dig
> -into it.
> +into it. If the other patch isn't applied yet it's good to give it a
> +'Reviewed-by:' tag to help it get applied. This way your effort is not in
> +vain.
Should we perhaps be explicit and say that the person involved should
actually review the patch?
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: doc-guide: add hint to review patch
2026-11-16 9:10 ` Jonathan Corbet
@ 2026-11-16 9:38 ` Manuel Ebner
0 siblings, 0 replies; 3+ messages in thread
From: Manuel Ebner @ 2026-11-16 9:38 UTC (permalink / raw)
To: Jonathan Corbet, Shuah Khan, Randy Dunlap; +Cc: linux-doc, linux-kernel
On Mon, 2026-11-16 at 02:10 -0700, Jonathan Corbet wrote:
> Manuel Ebner <manuelebnerli@mailbox.org> writes:
>
> > For the case of a duplicate patch, review the other patch instead of
> > sending own patch.
> >
> > Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> > ---
> > Documentation/doc-guide/contributing.rst | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/doc-guide/contributing.rst b/Documentation/doc-guide/contributing.rst
> > index 46a44b39d6..ee2f896a21 100644
> > --- a/Documentation/doc-guide/contributing.rst
> > +++ b/Documentation/doc-guide/contributing.rst
> > @@ -129,7 +129,9 @@ looked like this::
> > The entire process only took a few minutes. Of course, I then found that
> > somebody else had fixed it in a separate tree, highlighting another lesson:
> > always check linux-next to see if a problem has been fixed before you dig
> > -into it.
> > +into it. If the other patch isn't applied yet it's good to give it a
> > +'Reviewed-by:' tag to help it get applied. This way your effort is not in
> > +vain.
>
> Should we perhaps be explicit and say that the person involved should
> actually review the patch?
Makes sense. I'll change it to:
into it. If the other patch isn't applied yet it's good to review it and
state that by replying with the 'Reviewed-by:' tag. This helps getting the
patch applied, so your effort is not in vain after all.
Thanks
Manuel
>
> jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-16 9:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 8:22 [PATCH] docs: doc-guide: add hint to review patch Manuel Ebner
2026-11-16 9:10 ` Jonathan Corbet
2026-11-16 9:38 ` Manuel Ebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®