mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shivnandan Kumar <quic_kshivnan@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Sibi Sankar <quic_sibis@quicinc.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Rob Herring <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<cros-qcom-dts-watchers@chromium.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	"Ramakrishna Gottimukkula" <quic_rgottimu@quicinc.com>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc7280: Add cpucp mbox node
Date: Thu, 17 Oct 2024 17:21:30 +0530	[thread overview]
Message-ID: <32cf828b-91c8-4710-8943-f2d174ada53b@quicinc.com> (raw)
In-Reply-To: <grvdxaiakv62nfom5r5m7zv43xpxfwhxnp7x5byfubbvecfers@pqydhpu7a2vm>



On 10/6/2024 8:05 AM, Bjorn Andersson wrote:
> On Tue, Sep 24, 2024 at 10:39:41AM GMT, Shivnandan Kumar wrote:
>> Add the CPUCP mailbox node required for communication with CPUCP.
> 
> I'd like to see a description of why that's useful...
> 

I will add in next patch set.

> But perhaps more importantly, why are there no user(s) of this?
> 

We will later add features such as BUS DCVS (memlat algorithm in CPUCP) 
and CPUCP logging based on this series.

> Regards,
> Bjorn
> 


>>
>> Signed-off-by: Shivnandan Kumar <quic_kshivnan@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 3d8410683402..4b9b26a75c62 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -4009,6 +4009,14 @@ gem_noc: interconnect@9100000 {
>>   			qcom,bcm-voters = <&apps_bcm_voter>;
>>   		};
>>
>> +		cpucp_mbox: mailbox@17430000 {
>> +			compatible = "qcom,sc7280-cpucp-mbox";
>> +			reg = <0 0x18590000 0 0x2000>,
>> +			      <0 0x17C00000 0 0x10>;
>> +			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
>> +			#mbox-cells = <1>;
>> +		};
>> +
>>   		system-cache-controller@9200000 {
>>   			compatible = "qcom,sc7280-llcc";
>>   			reg = <0 0x09200000 0 0x58000>, <0 0x09280000 0 0x58000>,
>> --
>> 2.25.1
>>

  reply	other threads:[~2024-10-17 11:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-24  5:09 [PATCH 0/3] qcom: sc7280: Enable cpucp mbox Shivnandan Kumar
2024-09-24  5:09 ` [PATCH 1/3] dt-bindings: mailbox: qcom,cpucp-mbox: Add sc7280 cpucp mailbox instance Shivnandan Kumar
2024-09-24 23:25   ` Rob Herring
2024-10-03  5:43     ` Shivnandan Kumar
2024-10-06 17:11       ` Dmitry Baryshkov
2024-10-17  5:18         ` Shivnandan Kumar
2024-10-18 10:51           ` Dmitry Baryshkov
2024-09-25 14:23   ` Krzysztof Kozlowski
2024-10-03  5:42     ` Shivnandan Kumar
2024-09-24  5:09 ` [PATCH 2/3] mailbox: qcom-cpucp-mbox: Add support for SC7280 CPUCP mailbox controller Shivnandan Kumar
2024-09-24  6:44   ` Dmitry Baryshkov
2024-10-03  5:42     ` Shivnandan Kumar
2024-09-24 15:27   ` kernel test robot
2024-10-06  2:33   ` Bjorn Andersson
2024-10-17 11:52     ` Shivnandan Kumar
2024-10-18 14:44       ` Bjorn Andersson
2024-10-17 21:15   ` Konrad Dybcio
2024-09-24  5:09 ` [PATCH 3/3] arm64: dts: qcom: sc7280: Add cpucp mbox node Shivnandan Kumar
2024-09-25 14:22   ` Krzysztof Kozlowski
2024-10-03  5:41     ` Shivnandan Kumar
2024-10-06  2:35   ` Bjorn Andersson
2024-10-17 11:51     ` Shivnandan Kumar [this message]
2024-10-17 21:13       ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32cf828b-91c8-4710-8943-f2d174ada53b@quicinc.com \
    --to=quic_kshivnan@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_rgottimu@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®