* [PATCH] ARM: dts: mstar: align UART node name with bindings
@ 2023-01-23 15:15 Krzysztof Kozlowski
2023-01-25 10:20 ` Daniel Palmer
2023-01-25 10:39 ` Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 15:15 UTC (permalink / raw)
To: Daniel Palmer, Romain Perier, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings expect UART/serial node names to be "serial".
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/mstar-v7.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi
index c26ba9b7b6dd..3eeafd8c7121 100644
--- a/arch/arm/boot/dts/mstar-v7.dtsi
+++ b/arch/arm/boot/dts/mstar-v7.dtsi
@@ -174,7 +174,7 @@ gpio: gpio@207800 {
status = "disabled";
};
- pm_uart: uart@221000 {
+ pm_uart: serial@221000 {
compatible = "ns16550a";
reg = <0x221000 0x100>;
reg-shift = <3>;
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: mstar: align UART node name with bindings
2023-01-23 15:15 [PATCH] ARM: dts: mstar: align UART node name with bindings Krzysztof Kozlowski
@ 2023-01-25 10:20 ` Daniel Palmer
2023-01-25 10:37 ` Krzysztof Kozlowski
2023-01-25 10:39 ` Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Palmer @ 2023-01-25 10:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Romain Perier, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel
Hi,
On Tue, 24 Jan 2023 at 00:15, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Bindings expect UART/serial node names to be "serial".
snip
> - pm_uart: uart@221000 {
> + pm_uart: serial@221000 {
> compatible = "ns16550a";
> reg = <0x221000 0x100>;
> reg-shift = <3>;
> --
> 2.34.1
>
I have this change in my changes to use the proper uart driver that I
need to fix up and resend but it doesn't hurt to fix it now.
Reviewed-by: Daniel Palmer <daniel@thingy.jp>
But we don't have anything queued up in our tree to send a PR for so
maybe this should be merged via soc.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: mstar: align UART node name with bindings
2023-01-25 10:20 ` Daniel Palmer
@ 2023-01-25 10:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-25 10:37 UTC (permalink / raw)
To: Daniel Palmer
Cc: Romain Perier, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel
On 25/01/2023 11:20, Daniel Palmer wrote:
> Hi,
>
> On Tue, 24 Jan 2023 at 00:15, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Bindings expect UART/serial node names to be "serial".
>
> snip
>
>> - pm_uart: uart@221000 {
>> + pm_uart: serial@221000 {
>> compatible = "ns16550a";
>> reg = <0x221000 0x100>;
>> reg-shift = <3>;
>> --
>> 2.34.1
>>
>
> I have this change in my changes to use the proper uart driver that I
> need to fix up and resend but it doesn't hurt to fix it now.
>
> Reviewed-by: Daniel Palmer <daniel@thingy.jp>
>
> But we don't have anything queued up in our tree to send a PR for so
> maybe this should be merged via soc.
I can take it with my other cleanups. Thanks.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: mstar: align UART node name with bindings
2023-01-23 15:15 [PATCH] ARM: dts: mstar: align UART node name with bindings Krzysztof Kozlowski
2023-01-25 10:20 ` Daniel Palmer
@ 2023-01-25 10:39 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-25 10:39 UTC (permalink / raw)
To: devicetree, Krzysztof Kozlowski, Romain Perier, Rob Herring,
Krzysztof Kozlowski, Daniel Palmer, linux-kernel,
linux-arm-kernel
On Mon, 23 Jan 2023 16:15:23 +0100, Krzysztof Kozlowski wrote:
> Bindings expect UART/serial node names to be "serial".
>
>
Applied, thanks!
[1/1] ARM: dts: mstar: align UART node name with bindings
https://git.kernel.org/krzk/linux-dt/c/5e4505d22f2c3c739bdd063e5348bca3ff34dae2
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-25 10:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 15:15 [PATCH] ARM: dts: mstar: align UART node name with bindings Krzysztof Kozlowski
2023-01-25 10:20 ` Daniel Palmer
2023-01-25 10:37 ` Krzysztof Kozlowski
2023-01-25 10:39 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®