MemoryStick / Pro support

MemoryStick / Pro support

[Alex Dubov]

After a much longer, than expected, time I managed to implement a support for MemoryStick (read-only currently, as there's still a subtle data corruption bug with writes) and MemoryStick Pro cards. The implementation follows the MMC driver model (there exist MSIO cards, but none are supported at the moment). The MS Pro support appears stable from what I can learn from user reports. Nevertheless, I've implemented a couple of diagnostics files in the "sys" filesystem, as well as low level format facility for legacy MS cards.

Currently only TI Flashmedia adapters are supported, but I'm working on a JMicron JMB38x adapter support and I know for sure that it'll be easy to support a Winbond 528 adapter, as I used its GPLed driver as a reference for  a more generic implementation.

I would like to get an advice on the way to arrange the files in the kernel tree. My current idea is:

memstick.h        -> include/linux
memstick.c        -> drivers/memstick      ("bus" support)
ms_block.c        -> drivers/memstick      (legacy MS storage support)
mspro_block.c   -> drivers/memstick      (MS Pro storage support)
tifm_ms.c          -> drivers/memstick      (TI Flashmedia low level driver)



I also wonder, where do I send the patches if nobody currently maintains this thing?




__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: MemoryStick / Pro support

[Andrew Morton]

> On Fri, 2 Nov 2007 06:23:48 -0700 (PDT) Alex Dubov <oakad@yahoo.com> wrote:
> After a much longer, than expected, time I managed to implement a support for MemoryStick (read-only currently, as there's still a subtle data corruption bug with writes) and MemoryStick Pro cards. The implementation follows the MMC driver model (there exist MSIO cards, but none are supported at the moment). The MS Pro support appears stable from what I can learn from user reports. Nevertheless, I've implemented a couple of diagnostics files in the "sys" filesystem, as well as low level format facility for legacy MS cards.
> 
> Currently only TI Flashmedia adapters are supported, but I'm working on a JMicron JMB38x adapter support and I know for sure that it'll be easy to support a Winbond 528 adapter, as I used its GPLed driver as a reference for  a more generic implementation.
> 
> I would like to get an advice on the way to arrange the files in the kernel tree. My current idea is:
> 
> memstick.h        -> include/linux

Or drivers/memstick/.  Will anything else need this header?

> memstick.c        -> drivers/memstick      ("bus" support)
> ms_block.c        -> drivers/memstick      (legacy MS storage support)
> mspro_block.c   -> drivers/memstick      (MS Pro storage support)
> tifm_ms.c          -> drivers/memstick      (TI Flashmedia low level driver)
> 
> 
> 
> I also wonder, where do I send the patches if nobody currently maintains this thing?
> 

Me, Pierre, lkml?

Re: MemoryStick / Pro support

[Pierre Ossman]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On Tue, 6 Nov 2007 22:15:37 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> > On Fri, 2 Nov 2007 06:23:48 -0700 (PDT) Alex Dubov <oakad@yahoo.com> wrote:
> > 
> > I also wonder, where do I send the patches if nobody currently maintains this thing?
> > 
> 
> Me, Pierre, lkml?

I'm not sure sending it through me is a good idea. I'm having trouble finding time for my current projects, so I will be a bottle neck.

That's not a "no", but you have been warned. ;)

Rgds
Pierre

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]