mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>,
	"Russell King" <linux@armlinux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition
Date: Tue, 13 Jun 2017 08:37:20 +0100	[thread overview]
Message-ID: <331b6524-acd6-37ec-df72-9b8b2f3eec97@arm.com> (raw)
In-Reply-To: <20170612170937.2969-1-jeremy.lefaure@lse.epita.fr>

On 12/06/17 18:09, Jérémy Lefaure wrote:
> I didn't find any use of this macro in the current kernel tree (with git
> grep). KTHREAD_SIZE is no longer used for a very very long time. So
> let's remove this definition.
> 
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
>  arch/arm/include/asm/page-nommu.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h
> index 503f488053de..8f2c47bec375 100644
> --- a/arch/arm/include/asm/page-nommu.h
> +++ b/arch/arm/include/asm/page-nommu.h
> @@ -11,12 +11,6 @@
>  #ifndef _ASMARM_PAGE_NOMMU_H
>  #define _ASMARM_PAGE_NOMMU_H
>  
> -#if !defined(CONFIG_SMALL_TASKS) && PAGE_SHIFT < 13
> -#define KTHREAD_SIZE (8192)
> -#else
> -#define KTHREAD_SIZE PAGE_SIZE
> -#endif
> - 
>  #define clear_page(page)	memset((page), 0, PAGE_SIZE)
>  #define copy_page(to,from)	memcpy((to), (from), PAGE_SIZE)
>  
> 

Even more, CONFIG_SMALL_TASKS has gone and only page size we support is 4K.

It looks like that similar patch has been submitted several times by different
people but never got merged, so if it helps:

Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>

Cheers
Vladimir

      parent reply	other threads:[~2017-06-13  7:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 17:09 Jérémy Lefaure
2017-06-12 17:09 ` [PATCH 2/2] c6x: " Jérémy Lefaure
2017-06-15 20:53   ` Mark Salter
2017-06-13  7:37 ` Vladimir Murzin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=331b6524-acd6-37ec-df72-9b8b2f3eec97@arm.com \
    --to=vladimir.murzin@arm.com \
    --cc=jeremy.lefaure@lse.epita.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome