[Debian Package]Regression 6.3-rc3: version is empty for linux-headers installation dir

[Debian Package]Regression 6.3-rc3: version is empty for linux-headers installation dir

[David Wang]

When make a clean build for debian packages, with 6.3-rc3, there is no version information in the name of linux-headers dir, the linux-headers package would install into "/usr/src/linux-headers-".

This is caused by 36862e14e31611f9786622db366327209a7aede7 which remove the definition for "version" in scripts/package/builddeb

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 906889b304a4..c5ae57167d7c 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
...
 
-version=$KERNELRELEASE
--


But the variable is need for building linux-headers:
scripts/package/builddeb
188     destdir=$pdir/usr/src/linux-headers-$version
189     mkdir -p $destdir


This could be fixed by adding back the definition for version

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index c5ae57167d7c..1870b2485217 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -216,6 +216,7 @@ install_libc_headers () {
 rm -f debian/files
 
 packages_enabled=$(dh_listpackages)
+version=$KERNELRELEASE
 
 for package in ${packages_enabled}
 do
--



Davud

Re: [Debian Package]Regression 6.3-rc3: version is empty for linux-headers installation dir

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

On Mon, Mar 20, 2023 at 03:36:16PM +0800, David Wang wrote:
> This could be fixed by adding back the definition for version
> 
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index c5ae57167d7c..1870b2485217 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -216,6 +216,7 @@ install_libc_headers () {
>  rm -f debian/files
>  
>  packages_enabled=$(dh_listpackages)
> +version=$KERNELRELEASE
>  
>  for package in ${packages_enabled}
>  do
> --

Hi,

Looks like your fixup is corrupted (tabs converted to spaces). Can you
please send the proper patch (see
Documentation/process/submitting-patches.rst)?

Also, see Documentation/process/email-clients.rst) for guides on
configuring your email client for kernel development.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re:Re: [Debian Package]Regression 6.3-rc3: version is empty for linux-headers installation dir

[David Wang]

Thanks for the information, I was meaning to just report the regression.
And I just send a patch with the simple fix in another mail, hope the format is ok.


Thanks
David







At 2023-03-20 17:22:50, "Bagas Sanjaya" <bagasdotme@gmail.com> wrote:
>On Mon, Mar 20, 2023 at 03:36:16PM +0800, David Wang wrote:
>> This could be fixed by adding back the definition for version
>> 
>> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
>> index c5ae57167d7c..1870b2485217 100755
>> --- a/scripts/package/builddeb
>> +++ b/scripts/package/builddeb
>> @@ -216,6 +216,7 @@ install_libc_headers () {
>>  rm -f debian/files
>>  
>>  packages_enabled=$(dh_listpackages)
>> +version=$KERNELRELEASE
>>  
>>  for package in ${packages_enabled}
>>  do
>> --
>
>Hi,
>
>Looks like your fixup is corrupted (tabs converted to spaces). Can you
>please send the proper patch (see
>Documentation/process/submitting-patches.rst)?
>
>Also, see Documentation/process/email-clients.rst) for guides on
>configuring your email client for kernel development.
>
>Thanks.
>
>-- 
>An old man doll... just what I always wanted! - Clara