Re: Re: [PATCH] I2C: Change the value of octeon i2c adapter timeout value

Re: Re: [PATCH] I2C: Change the value of octeon i2c adapter timeout value

[EUNBONG SONG]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 574 bytes --]



On Fri, Apr 19, 2013 at 12:01:04AM +0000, EUNBONG SONG wrote:
>> 
>>  I think HZ/50 is better than 2 for adapter timeout.

> Basically OK. But why HZ/50? Most drivers use HZ.

Actually, I just translated 2 jiffies because HZ is 100 in default cavium config. 
You can find that in "arch/mips/configs/cavium_octeon_defconfig". 
And i have been using this value over 1 year in octeon board without problem.
Thanks. ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: Re: [PATCH] I2C: Change the value of octeon i2c adapter timeout value

[Wolfram Sang]

On Fri, Apr 19, 2013 at 09:13:54AM +0000, EUNBONG SONG wrote:
> 
> 
> On Fri, Apr 19, 2013 at 12:01:04AM +0000, EUNBONG SONG wrote:
> >> 
> >>  I think HZ/50 is better than 2 for adapter timeout.
> 
> > Basically OK. But why HZ/50? Most drivers use HZ.
> 
> Actually, I just translated 2 jiffies because HZ is 100 in default cavium config. 
> You can find that in "arch/mips/configs/cavium_octeon_defconfig". 
> And i have been using this value over 1 year in octeon board without problem.

Have you been writing to EEPROMS? Their erase/write cycle might be
longer. But I am not forcing you to change the value, just giving some
suggestions.