From: Daniel Almeida <daniel.almeida@collabora.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: FUJITA Tomonori <fujita.tomonori@gmail.com>,
a.hindborg@kernel.org, alex.gaynor@gmail.com, ojeda@kernel.org,
aliceryhl@google.com, anna-maria@linutronix.de,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
frederic@kernel.org, gary@garyguo.net, jstultz@google.com,
linux-kernel@vger.kernel.org, lossin@kernel.org,
lyude@redhat.com, rust-for-linux@vger.kernel.org,
sboyd@kernel.org, tglx@linutronix.de, tmgross@umich.edu,
acourbot@nvidia.com
Subject: Re: [PATCH v1 2/2] rust: Add read_poll_timeout_atomic function
Date: Tue, 26 Aug 2025 13:59:46 -0300 [thread overview]
Message-ID: <33725E09-3994-4306-AD4F-4A0253261DE1@collabora.com> (raw)
In-Reply-To: <DCCF63BESWQ9.9LC8MZK7NG1Y@kernel.org>
> On 26 Aug 2025, at 11:12, Danilo Krummrich <dakr@kernel.org> wrote:
>
> On Thu Aug 21, 2025 at 5:57 AM CEST, FUJITA Tomonori wrote:
>> +pub fn read_poll_timeout_atomic<Op, Cond, T>(
>> + mut op: Op,
>> + mut cond: Cond,
>> + delay_delta: Delta,
>> + timeout_delta: Delta,
>> +) -> Result<T>
>> +where
>> + Op: FnMut() -> Result<T>,
>> + Cond: FnMut(&T) -> bool,
>> +{
>> + let mut left_ns = timeout_delta.as_nanos();
>> + let delay_ns = delay_delta.as_nanos();
>> +
>> + loop {
>> + let val = op()?;
>> + if cond(&val) {
>> + // Unlike the C version, we immediately return.
>> + // We know the condition is met so we don't need to check again.
>> + return Ok(val);
>> + }
>> +
>> + if left_ns < 0 {
>> + // Unlike the C version, we immediately return.
>> + // We have just called `op()` so we don't need to call it again.
>> + return Err(ETIMEDOUT);
>> + }
>> +
>> + if !delay_delta.is_zero() {
>> + udelay(delay_delta);
>> + left_ns -= delay_ns;
>> + }
>> +
>> + cpu_relax();
>> + left_ns -= 1;
>
> How do we know that each iteration costs 1ns? To make it even more obvious, we
> don't control the implementation of cond(). Shouldn't we use ktime for this?
I don’t think ktime can be used from an atomic context?
— Daniel
next prev parent reply other threads:[~2025-08-26 17:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 3:57 [PATCH v1 0/2] Add read_poll_timeout_atomic support FUJITA Tomonori
2025-08-21 3:57 ` [PATCH v1 1/2] rust: add udelay() function FUJITA Tomonori
2025-08-26 9:09 ` Andreas Hindborg
2025-08-26 11:59 ` FUJITA Tomonori
2025-08-26 18:03 ` Miguel Ojeda
2025-08-27 7:12 ` Andreas Hindborg
2025-08-26 12:44 ` Daniel Almeida
2025-08-27 2:43 ` FUJITA Tomonori
2025-08-21 3:57 ` [PATCH v1 2/2] rust: Add read_poll_timeout_atomic function FUJITA Tomonori
2025-08-26 14:02 ` Daniel Almeida
2025-08-27 0:35 ` FUJITA Tomonori
2025-08-27 4:32 ` FUJITA Tomonori
2025-08-26 14:12 ` Danilo Krummrich
2025-08-26 16:59 ` Daniel Almeida [this message]
2025-08-26 17:15 ` Danilo Krummrich
2025-08-27 0:14 ` FUJITA Tomonori
2025-08-27 9:00 ` Danilo Krummrich
2025-08-27 10:29 ` Danilo Krummrich
2025-08-27 12:14 ` Daniel Almeida
2025-08-27 12:19 ` Danilo Krummrich
2025-08-27 12:22 ` Daniel Almeida
2025-08-27 12:36 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33725E09-3994-4306-AD4F-4A0253261DE1@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®