[PATCH 0/2] drm/imagination: minor code improvements

[PATCH 0/2] drm/imagination: minor code improvements

[Luigi Santivetti]

No functional change is assumed in this series.

Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
---
Luigi Santivetti (2):
      drm/imagination: switch to inline init of rogue_fwif_rta_ctl
      drm/imagination: drop unused arg in free_list_create_fw_structure()

 drivers/gpu/drm/imagination/pvr_free_list.c |  3 +--
 drivers/gpu/drm/imagination/pvr_hwrt.c      | 12 ++++--------
 2 files changed, 5 insertions(+), 10 deletions(-)
---
base-commit: 33ed26235db93162935d1719bc6f538c384a2fd8
change-id: 20261104-minor-improvements-2c62fc679235

Best regards,
--  
Luigi Santivetti <luigi.santivetti@imgtec.com>

[PATCH 1/2] drm/imagination: switch to inline init of rogue_fwif_rta_ctl

[Luigi Santivetti]

Rely on implicitly zero-ing all members using designated identifiers.

Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_hwrt.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_hwrt.c b/drivers/gpu/drm/imagination/pvr_hwrt.c
index 05c68c78da22..3f7c4346c52c 100644
--- a/drivers/gpu/drm/imagination/pvr_hwrt.c
+++ b/drivers/gpu/drm/imagination/pvr_hwrt.c
@@ -358,8 +358,8 @@ hwrt_data_init_fw_structure(struct pvr_file *pvr_file,
 			    struct pvr_hwrt_data *hwrt_data)
 {
 	struct drm_pvr_create_hwrt_geom_data_args *geom_data_args = &args->geom_data_args;
+	struct rogue_fwif_rta_ctl *rta_ctl = &hwrt_data->data.rta_ctl;
 	struct pvr_device *pvr_dev = pvr_file->pvr_dev;
-	struct rogue_fwif_rta_ctl *rta_ctl;
 	int err;
 
 	pvr_fw_object_get_fw_addr(hwrt->common_fw_obj,
@@ -378,13 +378,9 @@ hwrt_data_init_fw_structure(struct pvr_file *pvr_file,
 	hwrt_data->data.macrotile_array_dev_addr = rt_data_args->macrotile_array_dev_addr;
 	hwrt_data->data.rgn_header_dev_addr = rt_data_args->region_header_dev_addr;
 
-	rta_ctl = &hwrt_data->data.rta_ctl;
-
-	rta_ctl->render_target_index = 0;
-	rta_ctl->active_render_targets = 0;
-	rta_ctl->valid_render_targets_fw_addr = 0;
-	rta_ctl->rta_num_partial_renders_fw_addr = 0;
-	rta_ctl->max_rts = args->layers;
+	*rta_ctl = (struct rogue_fwif_rta_ctl){
+		.max_rts = args->layers,
+	};
 
 	if (args->layers > 1) {
 		err = pvr_fw_object_create(pvr_dev, args->layers * SRTC_ENTRY_SIZE,

-- 
2.43.0

[PATCH 2/2] drm/imagination: drop unused arg in free_list_create_fw_structure()

[Luigi Santivetti]

free_list_create_fw_structure() doesn't need nor use the ioctl arguments.

Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_free_list.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_free_list.c b/drivers/gpu/drm/imagination/pvr_free_list.c
index ec02fbbe0168..5ad262ee24f1 100644
--- a/drivers/gpu/drm/imagination/pvr_free_list.c
+++ b/drivers/gpu/drm/imagination/pvr_free_list.c
@@ -193,7 +193,6 @@ free_list_fw_init(void *cpu_ptr, void *priv)
 
 static int
 free_list_create_fw_structure(struct pvr_file *pvr_file,
-			      struct drm_pvr_ioctl_create_free_list_args *args,
 			      struct pvr_free_list *free_list)
 {
 	struct pvr_device *pvr_dev = pvr_file->pvr_dev;
@@ -443,7 +442,7 @@ pvr_free_list_create(struct pvr_file *pvr_file,
 	if (err)
 		goto err_destroy_kernel_structure;
 
-	err = free_list_create_fw_structure(pvr_file, args, free_list);
+	err = free_list_create_fw_structure(pvr_file, free_list);
 	if (err < 0)
 		goto err_free_fw_id;
 

-- 
2.43.0

Re: [PATCH 0/2] drm/imagination: minor code improvements

[Alessio Belle]

On Wed, 2026-11-04 at 19:28 +0000, Luigi Santivetti wrote:
> No functional change is assumed in this series.
> 
> Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>

For the series,

Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>

Thanks,
Alessio

> ---
> Luigi Santivetti (2):
>       drm/imagination: switch to inline init of rogue_fwif_rta_ctl
>       drm/imagination: drop unused arg in free_list_create_fw_structure()
> 
>  drivers/gpu/drm/imagination/pvr_free_list.c |  3 +--
>  drivers/gpu/drm/imagination/pvr_hwrt.c      | 12 ++++--------
>  2 files changed, 5 insertions(+), 10 deletions(-)
> ---
> base-commit: 33ed26235db93162935d1719bc6f538c384a2fd8
> change-id: 20261104-minor-improvements-2c62fc679235
> 
> Best regards,
> --  
> Luigi Santivetti <luigi.santivetti@imgtec.com>
>