* [PATCH] serial: xilinx_uartps: make cdns_rs485_supported static
@ 2024-09-05 23:19 Min-Hua Chen
2024-09-06 7:05 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: Min-Hua Chen @ 2024-09-05 23:19 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Michal Simek
Cc: Min-Hua Chen, linux-kernel, linux-serial, linux-arm-kernel
make cdns_rs485_supported static to fix the following sparse
warning:
drivers/tty/serial/xilinx_uartps.c:222:21: sparse: warning:
symbol 'cdns_rs485_supported' was not declared. Should it be static?
Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
drivers/tty/serial/xilinx_uartps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 2acfcea403ce..777392914819 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -219,7 +219,7 @@ struct cdns_platform_data {
u32 quirks;
};
-struct serial_rs485 cdns_rs485_supported = {
+static struct serial_rs485 cdns_rs485_supported = {
.flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND |
SER_RS485_RTS_AFTER_SEND,
.delay_rts_before_send = 1,
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] serial: xilinx_uartps: make cdns_rs485_supported static
2024-09-05 23:19 [PATCH] serial: xilinx_uartps: make cdns_rs485_supported static Min-Hua Chen
@ 2024-09-06 7:05 ` Michal Simek
2024-09-06 9:03 ` Min-Hua Chen
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2024-09-06 7:05 UTC (permalink / raw)
To: Min-Hua Chen, Greg Kroah-Hartman, Jiri Slaby
Cc: linux-kernel, linux-serial, linux-arm-kernel
On 9/6/24 01:19, Min-Hua Chen wrote:
> make cdns_rs485_supported static to fix the following sparse
> warning:
>
> drivers/tty/serial/xilinx_uartps.c:222:21: sparse: warning:
> symbol 'cdns_rs485_supported' was not declared. Should it be static?
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---
> drivers/tty/serial/xilinx_uartps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 2acfcea403ce..777392914819 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -219,7 +219,7 @@ struct cdns_platform_data {
> u32 quirks;
> };
>
> -struct serial_rs485 cdns_rs485_supported = {
> +static struct serial_rs485 cdns_rs485_supported = {
> .flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND |
> SER_RS485_RTS_AFTER_SEND,
> .delay_rts_before_send = 1,
This has been applied already as commit 68c5efd9dca ("serial: xilinx_uartps:
Make cdns_rs485_supported static").
You can also see it here
https://lore.kernel.org/r/20240819120107.3884973-1-ruanjinjie@huawei.com
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-06 9:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-05 23:19 [PATCH] serial: xilinx_uartps: make cdns_rs485_supported static Min-Hua Chen
2024-09-06 7:05 ` Michal Simek
2024-09-06 9:03 ` Min-Hua Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®