[PATCH v2 0/2] Drivers: hv: fix typos in comments

[PATCH v2 0/2] Drivers: hv: fix typos in comments

[Hemanth Selam]

This is v2 of the spelling fixes for this tree.

Changes since v1:
Subject prefix of patch 1 corrected to 'Drivers: hv: vmbus:'.
Michael Kelley's Reviewed-by tags are picked up.

Only comments change; no code is touched.

 drivers/hv/channel.c        | 2 +-
 tools/hv/hv_get_dns_info.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 1/2] Drivers: hv: vmbus: fix typo "substract" in comment

[Hemanth Selam]

Correct "substract" to "subtract", reported by scripts/checkpatch.pl using
the misspelling list in scripts/spelling.txt.  Only touches a comment, no
code changes.

The subject prefix changed since v1, from "hv:" to "Drivers: hv: vmbus:",
for consistency with the rest of the subsystem's history as Michael Kelley
pointed out.

Assisted-by: Cursor:claude-opus-5
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 drivers/hv/channel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index f4370617deac..c36ec14529b9 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -79,7 +79,7 @@ static inline u32 hv_ring_gpadl_send_hvpgoffset(u32 offset)
 	 * therefore leaving a (PAGE_SIZE - HV_HYP_PAGE_SIZE) gap.
 	 *
 	 * And to calculate the effective send offset in gpadl, we need to
-	 * substract this gap.
+	 * subtract this gap.
 	 */
 	return (offset - (PAGE_SIZE - HV_HYP_PAGE_SIZE)) >> HV_HYP_PAGE_SHIFT;
 }

Re: [PATCH v2 1/2] Drivers: hv: vmbus: fix typo "substract" in comment

[Naman Jain]

On 9/7/2026 10:19 AM, Hemanth Selam wrote:
> Correct "substract" to "subtract", reported by scripts/checkpatch.pl using
> the misspelling list in scripts/spelling.txt.  Only touches a comment, no
> code changes.
> 
> The subject prefix changed since v1, from "hv:" to "Drivers: hv: vmbus:",
> for consistency with the rest of the subsystem's history as Michael Kelley
> pointed out.

Hi,
The change-log (these 3 lines) go after "---" line as a comment so that 
these do not get propagated to the git log in kernel tree.

> 
> Assisted-by: Cursor:claude-opus-5
> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---

Here.

Refer: https://docs.kernel.org/process/submitting-patches.html#commentary

Example: 
https://lore.kernel.org/all/20260907054742.235389-1-namjain@linux.microsoft.com/

Regards,
Naman

>   drivers/hv/channel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index f4370617deac..c36ec14529b9 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -79,7 +79,7 @@ static inline u32 hv_ring_gpadl_send_hvpgoffset(u32 offset)
>   	 * therefore leaving a (PAGE_SIZE - HV_HYP_PAGE_SIZE) gap.
>   	 *
>   	 * And to calculate the effective send offset in gpadl, we need to
> -	 * substract this gap.
> +	 * subtract this gap.
>   	 */
>   	return (offset - (PAGE_SIZE - HV_HYP_PAGE_SIZE)) >> HV_HYP_PAGE_SHIFT;
>   }

Re: [PATCH v2 1/2] Drivers: hv: vmbus: fix typo "substract" in comment

[Hemanth Selam]

On Mon, 07 Sep 2026, Naman Jain wrote:
> The change-log (these 3 lines) go after "---" line as a comment so that
> these do not get propagated to the git log in kernel tree.

Understood, thanks for the pointer and the example.  The changelog belongs
below the "---", not in the commit message.  I have moved it there for the
respins that went out after this one.

Since the diff itself is unchanged and Michael's Reviewed-by still stands,
please just drop the three lines when you apply it.  Happy to send a v3
with the changelog in the right place if you would rather have that.

Re: [PATCH v2 1/2] Drivers: hv: vmbus: fix typo "substract" in comment

[Wei Liu]

On Mon, Sep 07, 2026 at 10:19:45AM +0530, Hemanth Selam wrote:
> Correct "substract" to "subtract", reported by scripts/checkpatch.pl using
> the misspelling list in scripts/spelling.txt.  Only touches a comment, no
> code changes.
> 
> The subject prefix changed since v1, from "hv:" to "Drivers: hv: vmbus:",
> for consistency with the rest of the subsystem's history as Michael Kelley
> pointed out.

You can drop this long wall of text. It is pretty clear what this patch
does.

Wei

> 
> Assisted-by: Cursor:claude-opus-5
> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
>  drivers/hv/channel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index f4370617deac..c36ec14529b9 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -79,7 +79,7 @@ static inline u32 hv_ring_gpadl_send_hvpgoffset(u32 offset)
>  	 * therefore leaving a (PAGE_SIZE - HV_HYP_PAGE_SIZE) gap.
>  	 *
>  	 * And to calculate the effective send offset in gpadl, we need to
> -	 * substract this gap.
> +	 * subtract this gap.
>  	 */
>  	return (offset - (PAGE_SIZE - HV_HYP_PAGE_SIZE)) >> HV_HYP_PAGE_SHIFT;
>  }

[PATCH v2 2/2] tools/hv: fix typo "retrive" in comment

[Hemanth Selam]

Correct "retrive" to "retrieve", reported by scripts/checkpatch.pl using
the misspelling list in scripts/spelling.txt.  Only touches a comment, no
code changes.

Assisted-by: Cursor:claude-opus-5
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 tools/hv/hv_get_dns_info.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hv/hv_get_dns_info.sh b/tools/hv/hv_get_dns_info.sh
index 268521234d4b..288821565eee 100755
--- a/tools/hv/hv_get_dns_info.sh
+++ b/tools/hv/hv_get_dns_info.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-# This example script parses /etc/resolv.conf to retrive DNS information.
+# This example script parses /etc/resolv.conf to retrieve DNS information.
 # In the interest of keeping the KVP daemon code free of distro specific
 # information; the kvp daemon code invokes this external script to gather
 # DNS information.

Re: [PATCH v2 2/2] tools/hv: fix typo "retrive" in comment

[Wei Liu]

On Mon, Sep 07, 2026 at 10:19:46AM +0530, Hemanth Selam wrote:
> Correct "retrive" to "retrieve", reported by scripts/checkpatch.pl using
> the misspelling list in scripts/spelling.txt.  Only touches a comment, no
> code changes.

There is no need to write a whole paragraph for a simple typo fix.

Wei

> 
> Assisted-by: Cursor:claude-opus-5
> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
>  tools/hv/hv_get_dns_info.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_get_dns_info.sh b/tools/hv/hv_get_dns_info.sh
> index 268521234d4b..288821565eee 100755
> --- a/tools/hv/hv_get_dns_info.sh
> +++ b/tools/hv/hv_get_dns_info.sh
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  
> -# This example script parses /etc/resolv.conf to retrive DNS information.
> +# This example script parses /etc/resolv.conf to retrieve DNS information.
>  # In the interest of keeping the KVP daemon code free of distro specific
>  # information; the kvp daemon code invokes this external script to gather
>  # DNS information.

[PATCH v3 0/2] Drivers: hv: fix typos in comments

[Hemanth Selam]

Two one-line comment typo fixes.  The diffs are unchanged from v2.

v3:
 - Trimmed the commit messages down to a single line each (Wei Liu).
 - Dropped the Assisted-by trailer naming the model.
 - Moved the note about the v1 -> v2 subject prefix change out of patch
   1/2's commit message and into this cover letter: the prefix became
   "Drivers: hv: vmbus:" to match the subsystem's history, as Michael
   Kelley pointed out.

Michael Kelley's Reviewed-by is carried over on both patches, as neither
diff changed.

v2: https://lore.kernel.org/all/20260907044946.10813-1-hemanth.selam@gmail.com/


Hemanth Selam (2):
  Drivers: hv: vmbus: fix typo "substract" in comment
  tools/hv: fix typo "retrive" in comment

 drivers/hv/channel.c        | 2 +-
 tools/hv/hv_get_dns_info.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.48.1

[PATCH v3 1/2] Drivers: hv: vmbus: fix typo "substract" in comment

[Hemanth Selam]

Correct "substract" to "subtract".

Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 drivers/hv/channel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 7e4cc6f55237..a0883ddf32e2 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -79,7 +79,7 @@ static inline u32 hv_ring_gpadl_send_hvpgoffset(u32 offset)
 	 * therefore leaving a (PAGE_SIZE - HV_HYP_PAGE_SIZE) gap.
 	 *
 	 * And to calculate the effective send offset in gpadl, we need to
-	 * substract this gap.
+	 * subtract this gap.
 	 */
 	return (offset - (PAGE_SIZE - HV_HYP_PAGE_SIZE)) >> HV_HYP_PAGE_SHIFT;
 }
-- 
2.48.1

[PATCH v3 2/2] tools/hv: fix typo "retrive" in comment

[Hemanth Selam]

Correct "retrive" to "retrieve".

Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 tools/hv/hv_get_dns_info.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hv/hv_get_dns_info.sh b/tools/hv/hv_get_dns_info.sh
index 268521234d4b..288821565eee 100755
--- a/tools/hv/hv_get_dns_info.sh
+++ b/tools/hv/hv_get_dns_info.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-# This example script parses /etc/resolv.conf to retrive DNS information.
+# This example script parses /etc/resolv.conf to retrieve DNS information.
 # In the interest of keeping the KVP daemon code free of distro specific
 # information; the kvp daemon code invokes this external script to gather
 # DNS information.
-- 
2.48.1