Re: [PATCH 2/4] amd64_edac: do not enable module by default

Re: [PATCH 2/4] amd64_edac: do not enable module by default

[Doug Thompson]

--- On Wed, 5/20/09, Borislav Petkov <borislav.petkov@amd.com> wrote:

> From: Borislav Petkov <borislav.petkov@amd.com>
> Subject: [PATCH 2/4] amd64_edac: do not enable module by default
> To: akpm@linux-foundation.org, greg@kroah.com, mingo@elte.hu
> Cc: norsk5@yahoo.com, tglx@linutronix.de, hpa@zytor.com, mchehab@redhat.com, aris@redhat.com, edt@aei.ca, linux-kernel@vger.kernel.org, randy.dunlap@oracle.com, "Borislav Petkov" <borislav.petkov@amd.com>
> Date: Wednesday, May 20, 2009, 12:43 PM
> While at it, fix a link failure when
> !K8_NB.
> 
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>

Acked-by: Doug Thompson <dougthompson@xmission.com>

> ---
>  drivers/edac/Kconfig |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index 1c5a325..d294421 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -60,11 +60,10 @@ config EDAC_MM_EDAC
>  
>  config EDAC_AMD64
>      tristate "AMD64 (Opteron, Athlon64) K8,
> F10h, F11h"
> -    depends on EDAC_MM_EDAC && X86
> && PCI
> -    default m
> +    depends on EDAC_MM_EDAC &&
> K8_NB && X86_64 && PCI
>      help
> -    Support for error detection and
> correction on the AMD 64
> -    Families of Memory Controllers (K8,
> F10h and F11h)
> +      Support for error detection and
> correction on the AMD 64
> +      Families of Memory Controllers
> (K8, F10h and F11h)
>  
>  config EDAC_AMD64_ERROR_INJECTION
>      bool "Sysfs Error Injection
> facilities"
> -- 
> 1.6.2.4
> 
> 
> 

[PATCH 0/4] amd64_edac: misc fixes

[Borislav Petkov]

Hi,

here are some minor fixlets which came up lately. I'm sending them
separately as an offset from the rest of the patchset since nothing has
changed there. For details, see

git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git for-next

Thanks,
Boris.

[PATCH 2/4] amd64_edac: do not enable module by default

[Borislav Petkov]

While at it, fix a link failure when !K8_NB.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 drivers/edac/Kconfig |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 1c5a325..d294421 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -60,11 +60,10 @@ config EDAC_MM_EDAC
 
 config EDAC_AMD64
 	tristate "AMD64 (Opteron, Athlon64) K8, F10h, F11h"
-	depends on EDAC_MM_EDAC && X86 && PCI
-	default m
+	depends on EDAC_MM_EDAC && K8_NB && X86_64 && PCI
 	help
-	Support for error detection and correction on the AMD 64
-	Families of Memory Controllers (K8, F10h and F11h)
+	  Support for error detection and correction on the AMD 64
+	  Families of Memory Controllers (K8, F10h and F11h)
 
 config EDAC_AMD64_ERROR_INJECTION
 	bool "Sysfs Error Injection facilities"
-- 
1.6.2.4