mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kirill Marinushkin <kmarinushkin@birdec.tech>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: pcm3060: Add control for differential output
Date: Fri, 9 Nov 2018 14:06:50 +0100	[thread overview]
Message-ID: <34162ae4-5000-f355-a5a2-90c7b7c6c3e7@birdec.tech> (raw)
In-Reply-To: <20181105112036.GC5365@sirena.org.uk>

Hello Mark,

On 11/05/18 12:20, Mark Brown wrote:
> On Mon, Oct 29, 2018 at 09:59:12AM +0100, Kirill Marinushkin wrote:
>> DAC may be switched between differential and single-ended output.
> 
> Isn't this something that'd be better controlled by DT - it's usually
> going to be part of the board design?
> 

I agree with that. I implemented it as a switch, just because that's how other
codec drivers do. In such situations, I prefer to be aligned with already
existing code.

Indeed, it's more logical to implement such setup via DT. I will rewrite and
send it as patch v2.

Best Regards,
Kirill

  reply	other threads:[~2018-11-09 13:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29  8:59 Kirill Marinushkin
2018-10-29  8:59 ` [PATCH 2/2] ASoC: pcm3060: Rename output widgets Kirill Marinushkin
2018-11-05 11:20 ` [PATCH 1/2] ASoC: pcm3060: Add control for differential output Mark Brown
2018-11-09 13:06   ` Kirill Marinushkin [this message]
2018-11-12  7:08   ` [PATCH v2 1/3] dt-bindings: sound: Add documentation for pcm3060 property out-single-ended Kirill Marinushkin
2018-11-12  7:08     ` [PATCH v2 2/3] ASoC: pcm3060: Add DT property for single-ended output Kirill Marinushkin
2018-11-14  0:37       ` Applied "ASoC: pcm3060: Add DT property for single-ended output" to the asoc tree Mark Brown
2018-11-14  7:15         ` Kirill Marinushkin
2018-11-12  7:08     ` [PATCH v2 3/3] ASoC: pcm3060: Rename output widgets Kirill Marinushkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34162ae4-5000-f355-a5a2-90c7b7c6c3e7@birdec.tech \
    --to=kmarinushkin@birdec.tech \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®