mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Andy Lutomirski <luto@amacapital.net>
Cc: Ingo Molnar <mingo@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Patch "x86: Store a per-cpu shadow copy of CR4" gives VirtualBox 4.3.24 indigestion.
Date: Tue, 03 Mar 2015 20:28:34 -0500	[thread overview]
Message-ID: <34194.1425432514@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 03 Mar 2015 17:08:37 -0800." <CALCETrWgt=iN+49escoCh11+ArBsWXZt3uGT-n0jDJrkX7-NDg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

On Tue, 03 Mar 2015 17:08:37 -0800, Andy Lutomirski said:
>
> Are they poking cr4 directly with mov?  Let's see:
>
>     /* Enable the VMX bit in CR4 if necessary. */
>     RTCCUINTREG uCr4 = ASMGetCR4();
>     if (!(uCr4 & X86_CR4_VMXE))
>         ASMSetCR4(uCr4 | X86_CR4_VMXE);
>
> ASMSetCR4 is about what you'd expect.
>
> I deliberately renamed write_cr4 to __write_cr4 to catch this kind of
> thing in anything that uses the asm/ headers, but I can't do anything
> about asm code in out-of-tree modules.

Thanks for the confirmation, I've already updated the tracking bug they
were using for 4.0 issues, and will chase it further with them...

[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

      reply	other threads:[~2015-03-04  1:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04  0:49 Valdis Kletnieks
2015-03-04  1:08 ` Andy Lutomirski
2015-03-04  1:28   ` Valdis.Kletnieks [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34194.1425432514@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®