From: "Anthony Godshall, Ampro Computers, Inc." <agodshall@ampro.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI disabled due to DMI failure or blacklisted year should be noted, as is done with other ACPI blacklisting
Date: Tue, 6 Mar 2007 15:38:46 -0800 [thread overview]
Message-ID: <3424dc900703061538q564de10y4ea47dc97a7cc96@mail.gmail.com> (raw)
In-Reply-To: <3424dc900703061527i6153573wc7b932dd69c50f6d@mail.gmail.com>
Hello everyone.
IMHO, ACPI disabled due to DMI failure or blacklisted year should be
noted, as is done with other ACPI blacklisting.
This will help people troubleshoot when ACPI isn't working. Status
quo is a mysterious "ACPI Disabled" message without explanation on
BIOS that implements ACPI but not DMI. This is actually fairly common
on embedded x86 boards.
Tony
--- blacklist.orig.c 2007-02-04 10:44:54.000000000 -0800
+++ blacklist.tg.c 2007-03-06 10:57:18.000000000 -0800
@@ -79,11 +79,17 @@
{
int year = dmi_get_year(DMI_BIOS_DATE);
/* Doesn't exist? Likely an old system */
- if (year == -1)
+ if (year == -1) {
+ printk(KERN_ERR PREFIX "no DMI BIOS year, "
+ "acpi=force is required to enable ACPI\n" );
return 1;
+ }
/* 0? Likely a buggy new BIOS */
- if (year == 0)
+ if (year == 0) {
+ printk(KERN_ERR PREFIX "DMI BIOS year==0, "
+ "assuming ACPI-capable machine\n" );
return 0;
+ }
if (year < CONFIG_ACPI_BLACKLIST_YEAR) {
printk(KERN_ERR PREFIX "BIOS age (%d) fails cutoff (%d), "
"acpi=force is required to enable ACPI\n",
--
--
Tony Godshall
g
next parent reply other threads:[~2007-03-06 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3424dc900703061527i6153573wc7b932dd69c50f6d@mail.gmail.com>
2007-03-06 23:38 ` Anthony Godshall, Ampro Computers, Inc. [this message]
2007-03-12 20:39 ` Anthony Godshall, Ampro Computers, Inc.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3424dc900703061538q564de10y4ea47dc97a7cc96@mail.gmail.com \
--to=agodshall@ampro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®