[PATCH] ACPI disabled due to DMI failure or blacklisted year should be noted, as is done with other ACPI blacklisting

[PATCH] ACPI disabled due to DMI failure or blacklisted year should be noted, as is done with other ACPI blacklisting

[Anthony Godshall, Ampro Computers, Inc.]

Hello everyone.

IMHO, ACPI disabled due to DMI failure or blacklisted year should be
noted, as is done with other ACPI blacklisting.

This will help people troubleshoot when ACPI isn't working.  Status
quo is a mysterious "ACPI Disabled" message without explanation on
BIOS that implements ACPI but not DMI.  This is actually fairly common
on embedded x86 boards.

Tony

--- blacklist.orig.c    2007-02-04 10:44:54.000000000 -0800
+++ blacklist.tg.c      2007-03-06 10:57:18.000000000 -0800
@@ -79,11 +79,17 @@
 {
        int year = dmi_get_year(DMI_BIOS_DATE);
        /* Doesn't exist? Likely an old system */
-       if (year == -1)
+       if (year == -1) {
+               printk(KERN_ERR PREFIX "no DMI BIOS year, "
+                      "acpi=force is required to enable ACPI\n" );
                return 1;
+       }
        /* 0? Likely a buggy new BIOS */
-       if (year == 0)
+       if (year == 0) {
+               printk(KERN_ERR PREFIX "DMI BIOS year==0, "
+                      "assuming ACPI-capable machine\n" );
                return 0;
+       }
        if (year < CONFIG_ACPI_BLACKLIST_YEAR) {
                printk(KERN_ERR PREFIX "BIOS age (%d) fails cutoff (%d), "
                       "acpi=force is required to enable ACPI\n",

--
--
Tony Godshall
g

Re: [PATCH] ACPI disabled due to DMI failure or blacklisted year should be noted, as is done with other ACPI blacklisting

[Anthony Godshall, Ampro Computers, Inc.]

On Wednesday 07 March 2007 17:00, akpm@linux-foundation.org wrote:
>
> The patch titled
>      ACPI disabled due to DMI failure or blacklisted year should be noted, as is done with other ACPI blacklisting
> has been added to the -mm tree.  Its filename is
>      acpi-disabled-due-to-dmi-failure-or-blacklisted-year-should-be-noted-as-is-done-with-other-acpi-blacklisting.patch
>

Thank you for applying it, Andrew.

> good one -- i just ran into this yesterday:-)
>
> applied.
> thanks,
> -len

No, thank you.

Tony Godshall