* Re: [PATCH v16 0/9] Linux RISC-V AIA Support
@ 2024-03-14 5:47 Dawei Li
2024-03-14 6:21 ` Anup Patel
0 siblings, 1 reply; 8+ messages in thread
From: Dawei Li @ 2024-03-14 5:47 UTC (permalink / raw)
To: apatel
Cc: tglx, palmer, paul.walmsley, robh+dt, krzysztof.kozlowski+dt,
conor+dt, maz, bjorn, atishp, ajones, sunilvl, saravanak,
linux-riscv, linux-kernel, dawei.li
Hi Anup,
Thanks for the great work on AIA!
Firstly I must apologize for the top posting cuz I miss the series mail for
my inbox. And for the record, I am replying to [1].
After I checkout riscv_aia_v16 branch at https://github.com/avpatel/linux.git,
some call traces about spurious interrupt are screaming:
[ 1.244292] irq 11: nobody cared (try booting with the "irqpoll" option)
[ 1.244707] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.8.0-rc6-00055-gd7d4d086b79a #14
[ 1.244932] Hardware name: riscv-virtio,qemu (DT)
[ 1.245130] Call Trace:
[ 1.245337] [<ffffffff80005f32>] dump_backtrace+0x1c/0x24
[ 1.245559] [<ffffffff809023f4>] show_stack+0x2c/0x38
[ 1.245761] [<ffffffff8090ec8c>] dump_stack_lvl+0x3c/0x54
[ 1.245979] [<ffffffff8090ecb8>] dump_stack+0x14/0x1c
[ 1.246116] [<ffffffff8090368c>] __report_bad_irq+0x3e/0xae
[ 1.246276] [<ffffffff8006a938>] note_interrupt+0x1f4/0x23e
[ 1.246382] [<ffffffff800679e2>] handle_irq_event_percpu+0x42/0x50
[ 1.246508] [<ffffffff80067a2c>] handle_irq_event+0x3c/0x68
[ 1.246628] [<ffffffff8006b7a4>] handle_fasteoi_irq+0xac/0x176
[ 1.246788] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
[ 1.246928] [<ffffffff80473f0e>] imsic_handle_irq+0x72/0x12a
[ 1.247041] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
[ 1.247165] [<ffffffff80472470>] riscv_intc_aia_irq+0x26/0x38
[ 1.247291] [<ffffffff8090ed0a>] handle_riscv_irq+0x4a/0x74
[ 1.247430] [<ffffffff80918af6>] call_on_irq_stack+0x32/0x40
[ 1.247626] handlers:
[ 1.247721] [<000000004ebb6fe3>] vm_interrupt
[ 1.248314] Disabling IRQ #11
[ 1.303510] irq 12: nobody cared (try booting with the "irqpoll" option)
[ 1.303700] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.8.0-rc6-00055-gd7d4d086b79a #14
[ 1.304768] Hardware name: riscv-virtio,qemu (DT)
[ 1.305460] Call Trace:
[ 1.305868] [<ffffffff80005f32>] dump_backtrace+0x1c/0x24
[ 1.306621] [<ffffffff809023f4>] show_stack+0x2c/0x38
[ 1.307295] [<ffffffff8090ec8c>] dump_stack_lvl+0x3c/0x54
[ 1.308025] [<ffffffff8090ecb8>] dump_stack+0x14/0x1c
[ 1.308698] [<ffffffff8090368c>] __report_bad_irq+0x3e/0xae
[ 1.309698] [<ffffffff8006a938>] note_interrupt+0x1f4/0x23e
[ 1.310568] [<ffffffff800679e2>] handle_irq_event_percpu+0x42/0x50
[ 1.311542] [<ffffffff80067a2c>] handle_irq_event+0x3c/0x68
[ 1.312298] [<ffffffff8006b7a4>] handle_fasteoi_irq+0xac/0x176
[ 1.313127] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
[ 1.315375] [<ffffffff80473f0e>] imsic_handle_irq+0x72/0x12a
[ 1.316163] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
[ 1.317078] [<ffffffff80472470>] riscv_intc_aia_irq+0x26/0x38
[ 1.318036] [<ffffffff8090ed0a>] handle_riscv_irq+0x4a/0x74
[ 1.318934] [<ffffffff8090f3e6>] do_irq+0x4a/0x4c
[ 1.319831] [<ffffffff809189ac>] ret_from_exception+0x0/0x64
[ 1.320860] [<ffffffff8091845c>] _raw_spin_unlock_irqrestore+0x1a/0x2e
[ 1.321887] [<ffffffff80473d06>] imsic_local_timer_callback+0x50/0x5c
[ 1.322957] [<ffffffff8008ade4>] call_timer_fn.isra.0+0x14/0x5e
[ 1.323781] [<ffffffff8008b44a>] run_timer_softirq+0x388/0x3a8
[ 1.324579] [<ffffffff80918c7e>] __do_softirq+0x100/0x252
[ 1.325304] [<ffffffff80018464>] irq_exit_rcu+0x7c/0xa6
[ 1.326126] [<ffffffff8090ed24>] handle_riscv_irq+0x64/0x74
[ 1.327535] [<ffffffff80918af6>] call_on_irq_stack+0x32/0x40
[ 1.328703] handlers:
[ 1.330724] [<000000008b6c4f15>] serial8250_interrupt
[ 1.331573] Disabling IRQ #12
[ 1.350231] Run /sbin/init as init process
And I take a look on /proc/interrupts, spurious interrupts are happening:
~ # cat /proc/interrupts
CPU0 CPU1 CPU2 CPU3 CPU4 CPU5 CPU6 CPU7 CPU8 CPU9 CPU10 CPU11 CPU12 CPU13 CPU14 CPU15
10: 83 222 350 163 71 101 193 68 54 60 174 50 51 48 48 46 RISC-V INTC 5 Edge riscv-timer
11: 100001 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 APLIC-MSI-d000000.aplic 8 Level -fasteoi virtio0
12: 0 100000 0 0 0 0 0 0 0 0 0 0 0 0 0 0 APLIC-MSI-d000000.aplic 10 Level -fasteoi ttyS0
13: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 APLIC-MSI-d000000.aplic 11 Level -fasteoi 101000.rtc
IPI0: 3 8 4 7 7 6 5 4 7 7 7 5 6 10 4 5 Rescheduling interrupts
IPI1: 727 517 431 448 497 456 514 476 488 466 455 456 443 443 439 433 Function call interrupts
IPI2: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 CPU stop interrupts
IPI3: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 CPU stop (for crash dump) interrupts
IPI4: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 IRQ work interrupts
IPI5: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 Timer broadcast interrupts
But when I switched back to V15, everything is fine.
Here are some of info _maybe_ helpful:
kernel: d7d4d086b79a11ad8bbcaf732c7830faa3f3192f
qemu: e1007b6bab5cf97705bf4f2aaec1f607787355b8
qemu cmdline: qemu-system-riscv64 -M virt,aia=aplic-imsic -m 256M -nographic -kernel ~/src/linux/arch/riscv/boot/Image -drive file=rootfs.img,format=raw,id=hd0 -device virtio-blk-device,drive=hd0 -append "root=/dev/vda rw console=ttyS0" -smp 16
config: defconfig(make ARCH=riscv defconfig)
And I am happy to provide any extra info if needed.
After I take a git diff and check your changelog:
[Quoting from [1]]
- Simplified aplic_msi_irq_eoi() in PATCH7 based on the section "4.9.2 Special
consideration for level-sensitive interrupt sources" of the RISC-V AIA
specification and also provided handler name.
I apologize if I miss something.
[1] https://lore.kernel.org/lkml/20240307140307.646078-1-apatel@ventanamicro.com/
Thanks,
Dawei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v16 0/9] Linux RISC-V AIA Support
2024-03-14 5:47 [PATCH v16 0/9] Linux RISC-V AIA Support Dawei Li
@ 2024-03-14 6:21 ` Anup Patel
2024-03-14 6:59 ` Dawei Li
0 siblings, 1 reply; 8+ messages in thread
From: Anup Patel @ 2024-03-14 6:21 UTC (permalink / raw)
To: 20240307140307.646078-1-apatel
Cc: tglx, palmer, paul.walmsley, robh+dt, krzysztof.kozlowski+dt,
conor+dt, maz, bjorn, atishp, ajones, sunilvl, saravanak,
linux-riscv, linux-kernel, dawei.li
On Thu, Mar 14, 2024 at 11:17 AM Dawei Li <dawei.li@shingroup.cn> wrote:
>
> Hi Anup,
>
> Thanks for the great work on AIA!
>
> Firstly I must apologize for the top posting cuz I miss the series mail for
> my inbox. And for the record, I am replying to [1].
>
> After I checkout riscv_aia_v16 branch at https://github.com/avpatel/linux.git,
> some call traces about spurious interrupt are screaming:
>
> [ 1.244292] irq 11: nobody cared (try booting with the "irqpoll" option)
> [ 1.244707] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.8.0-rc6-00055-gd7d4d086b79a #14
> [ 1.244932] Hardware name: riscv-virtio,qemu (DT)
> [ 1.245130] Call Trace:
> [ 1.245337] [<ffffffff80005f32>] dump_backtrace+0x1c/0x24
> [ 1.245559] [<ffffffff809023f4>] show_stack+0x2c/0x38
> [ 1.245761] [<ffffffff8090ec8c>] dump_stack_lvl+0x3c/0x54
> [ 1.245979] [<ffffffff8090ecb8>] dump_stack+0x14/0x1c
> [ 1.246116] [<ffffffff8090368c>] __report_bad_irq+0x3e/0xae
> [ 1.246276] [<ffffffff8006a938>] note_interrupt+0x1f4/0x23e
> [ 1.246382] [<ffffffff800679e2>] handle_irq_event_percpu+0x42/0x50
> [ 1.246508] [<ffffffff80067a2c>] handle_irq_event+0x3c/0x68
> [ 1.246628] [<ffffffff8006b7a4>] handle_fasteoi_irq+0xac/0x176
> [ 1.246788] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
> [ 1.246928] [<ffffffff80473f0e>] imsic_handle_irq+0x72/0x12a
> [ 1.247041] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
> [ 1.247165] [<ffffffff80472470>] riscv_intc_aia_irq+0x26/0x38
> [ 1.247291] [<ffffffff8090ed0a>] handle_riscv_irq+0x4a/0x74
> [ 1.247430] [<ffffffff80918af6>] call_on_irq_stack+0x32/0x40
> [ 1.247626] handlers:
> [ 1.247721] [<000000004ebb6fe3>] vm_interrupt
> [ 1.248314] Disabling IRQ #11
> [ 1.303510] irq 12: nobody cared (try booting with the "irqpoll" option)
> [ 1.303700] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.8.0-rc6-00055-gd7d4d086b79a #14
> [ 1.304768] Hardware name: riscv-virtio,qemu (DT)
> [ 1.305460] Call Trace:
> [ 1.305868] [<ffffffff80005f32>] dump_backtrace+0x1c/0x24
> [ 1.306621] [<ffffffff809023f4>] show_stack+0x2c/0x38
> [ 1.307295] [<ffffffff8090ec8c>] dump_stack_lvl+0x3c/0x54
> [ 1.308025] [<ffffffff8090ecb8>] dump_stack+0x14/0x1c
> [ 1.308698] [<ffffffff8090368c>] __report_bad_irq+0x3e/0xae
> [ 1.309698] [<ffffffff8006a938>] note_interrupt+0x1f4/0x23e
> [ 1.310568] [<ffffffff800679e2>] handle_irq_event_percpu+0x42/0x50
> [ 1.311542] [<ffffffff80067a2c>] handle_irq_event+0x3c/0x68
> [ 1.312298] [<ffffffff8006b7a4>] handle_fasteoi_irq+0xac/0x176
> [ 1.313127] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
> [ 1.315375] [<ffffffff80473f0e>] imsic_handle_irq+0x72/0x12a
> [ 1.316163] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
> [ 1.317078] [<ffffffff80472470>] riscv_intc_aia_irq+0x26/0x38
> [ 1.318036] [<ffffffff8090ed0a>] handle_riscv_irq+0x4a/0x74
> [ 1.318934] [<ffffffff8090f3e6>] do_irq+0x4a/0x4c
> [ 1.319831] [<ffffffff809189ac>] ret_from_exception+0x0/0x64
> [ 1.320860] [<ffffffff8091845c>] _raw_spin_unlock_irqrestore+0x1a/0x2e
> [ 1.321887] [<ffffffff80473d06>] imsic_local_timer_callback+0x50/0x5c
> [ 1.322957] [<ffffffff8008ade4>] call_timer_fn.isra.0+0x14/0x5e
> [ 1.323781] [<ffffffff8008b44a>] run_timer_softirq+0x388/0x3a8
> [ 1.324579] [<ffffffff80918c7e>] __do_softirq+0x100/0x252
> [ 1.325304] [<ffffffff80018464>] irq_exit_rcu+0x7c/0xa6
> [ 1.326126] [<ffffffff8090ed24>] handle_riscv_irq+0x64/0x74
> [ 1.327535] [<ffffffff80918af6>] call_on_irq_stack+0x32/0x40
> [ 1.328703] handlers:
> [ 1.330724] [<000000008b6c4f15>] serial8250_interrupt
> [ 1.331573] Disabling IRQ #12
> [ 1.350231] Run /sbin/init as init process
>
> And I take a look on /proc/interrupts, spurious interrupts are happening:
> ~ # cat /proc/interrupts
> CPU0 CPU1 CPU2 CPU3 CPU4 CPU5 CPU6 CPU7 CPU8 CPU9 CPU10 CPU11 CPU12 CPU13 CPU14 CPU15
> 10: 83 222 350 163 71 101 193 68 54 60 174 50 51 48 48 46 RISC-V INTC 5 Edge riscv-timer
> 11: 100001 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 APLIC-MSI-d000000.aplic 8 Level -fasteoi virtio0
> 12: 0 100000 0 0 0 0 0 0 0 0 0 0 0 0 0 0 APLIC-MSI-d000000.aplic 10 Level -fasteoi ttyS0
> 13: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 APLIC-MSI-d000000.aplic 11 Level -fasteoi 101000.rtc
> IPI0: 3 8 4 7 7 6 5 4 7 7 7 5 6 10 4 5 Rescheduling interrupts
> IPI1: 727 517 431 448 497 456 514 476 488 466 455 456 443 443 439 433 Function call interrupts
> IPI2: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 CPU stop interrupts
> IPI3: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 CPU stop (for crash dump) interrupts
> IPI4: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 IRQ work interrupts
> IPI5: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 Timer broadcast interrupts
>
> But when I switched back to V15, everything is fine.
>
> Here are some of info _maybe_ helpful:
> kernel: d7d4d086b79a11ad8bbcaf732c7830faa3f3192f
> qemu: e1007b6bab5cf97705bf4f2aaec1f607787355b8
> qemu cmdline: qemu-system-riscv64 -M virt,aia=aplic-imsic -m 256M -nographic -kernel ~/src/linux/arch/riscv/boot/Image -drive file=rootfs.img,format=raw,id=hd0 -device virtio-blk-device,drive=hd0 -append "root=/dev/vda rw console=ttyS0" -smp 16
> config: defconfig(make ARCH=riscv defconfig)
>
> And I am happy to provide any extra info if needed.
>
> After I take a git diff and check your changelog:
> [Quoting from [1]]
> - Simplified aplic_msi_irq_eoi() in PATCH7 based on the section "4.9.2 Special
> consideration for level-sensitive interrupt sources" of the RISC-V AIA
> specification and also provided handler name.
>
> I apologize if I miss something.
>
> [1] https://lore.kernel.org/lkml/20240307140307.646078-1-apatel@ventanamicro.com/
The QEMU APLIC emulation of the setipnum register was broken. The
corresponding QEMU fixes are already accepted and queued by the
maintainer.
Please refer, https://lore.kernel.org/all/20240306095722.463296-1-apatel@ventanamicro.com/
Regards,
Anup
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v16 0/9] Linux RISC-V AIA Support
2024-03-14 6:21 ` Anup Patel
@ 2024-03-14 6:59 ` Dawei Li
0 siblings, 0 replies; 8+ messages in thread
From: Dawei Li @ 2024-03-14 6:59 UTC (permalink / raw)
To: Anup Patel
Cc: 20240307140307.646078-1-apatel, tglx, palmer, paul.walmsley,
robh+dt, krzysztof.kozlowski+dt, conor+dt, maz, bjorn, atishp,
ajones, sunilvl, saravanak, linux-riscv, linux-kernel
Hi Anup,
On Thu, Mar 14, 2024 at 11:51:53AM +0530, Anup Patel wrote:
> On Thu, Mar 14, 2024 at 11:17 AM Dawei Li <dawei.li@shingroup.cn> wrote:
> >
> > Hi Anup,
> >
> > Thanks for the great work on AIA!
> >
> > Firstly I must apologize for the top posting cuz I miss the series mail for
> > my inbox. And for the record, I am replying to [1].
> >
> > After I checkout riscv_aia_v16 branch at https://github.com/avpatel/linux.git,
> > some call traces about spurious interrupt are screaming:
> >
> > [ 1.244292] irq 11: nobody cared (try booting with the "irqpoll" option)
> > [ 1.244707] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.8.0-rc6-00055-gd7d4d086b79a #14
> > [ 1.244932] Hardware name: riscv-virtio,qemu (DT)
> > [ 1.245130] Call Trace:
> > [ 1.245337] [<ffffffff80005f32>] dump_backtrace+0x1c/0x24
> > [ 1.245559] [<ffffffff809023f4>] show_stack+0x2c/0x38
> > [ 1.245761] [<ffffffff8090ec8c>] dump_stack_lvl+0x3c/0x54
> > [ 1.245979] [<ffffffff8090ecb8>] dump_stack+0x14/0x1c
> > [ 1.246116] [<ffffffff8090368c>] __report_bad_irq+0x3e/0xae
> > [ 1.246276] [<ffffffff8006a938>] note_interrupt+0x1f4/0x23e
> > [ 1.246382] [<ffffffff800679e2>] handle_irq_event_percpu+0x42/0x50
> > [ 1.246508] [<ffffffff80067a2c>] handle_irq_event+0x3c/0x68
> > [ 1.246628] [<ffffffff8006b7a4>] handle_fasteoi_irq+0xac/0x176
> > [ 1.246788] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
> > [ 1.246928] [<ffffffff80473f0e>] imsic_handle_irq+0x72/0x12a
> > [ 1.247041] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
> > [ 1.247165] [<ffffffff80472470>] riscv_intc_aia_irq+0x26/0x38
> > [ 1.247291] [<ffffffff8090ed0a>] handle_riscv_irq+0x4a/0x74
> > [ 1.247430] [<ffffffff80918af6>] call_on_irq_stack+0x32/0x40
> > [ 1.247626] handlers:
> > [ 1.247721] [<000000004ebb6fe3>] vm_interrupt
> > [ 1.248314] Disabling IRQ #11
> > [ 1.303510] irq 12: nobody cared (try booting with the "irqpoll" option)
> > [ 1.303700] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.8.0-rc6-00055-gd7d4d086b79a #14
> > [ 1.304768] Hardware name: riscv-virtio,qemu (DT)
> > [ 1.305460] Call Trace:
> > [ 1.305868] [<ffffffff80005f32>] dump_backtrace+0x1c/0x24
> > [ 1.306621] [<ffffffff809023f4>] show_stack+0x2c/0x38
> > [ 1.307295] [<ffffffff8090ec8c>] dump_stack_lvl+0x3c/0x54
> > [ 1.308025] [<ffffffff8090ecb8>] dump_stack+0x14/0x1c
> > [ 1.308698] [<ffffffff8090368c>] __report_bad_irq+0x3e/0xae
> > [ 1.309698] [<ffffffff8006a938>] note_interrupt+0x1f4/0x23e
> > [ 1.310568] [<ffffffff800679e2>] handle_irq_event_percpu+0x42/0x50
> > [ 1.311542] [<ffffffff80067a2c>] handle_irq_event+0x3c/0x68
> > [ 1.312298] [<ffffffff8006b7a4>] handle_fasteoi_irq+0xac/0x176
> > [ 1.313127] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
> > [ 1.315375] [<ffffffff80473f0e>] imsic_handle_irq+0x72/0x12a
> > [ 1.316163] [<ffffffff80066c3c>] generic_handle_domain_irq+0x1c/0x2a
> > [ 1.317078] [<ffffffff80472470>] riscv_intc_aia_irq+0x26/0x38
> > [ 1.318036] [<ffffffff8090ed0a>] handle_riscv_irq+0x4a/0x74
> > [ 1.318934] [<ffffffff8090f3e6>] do_irq+0x4a/0x4c
> > [ 1.319831] [<ffffffff809189ac>] ret_from_exception+0x0/0x64
> > [ 1.320860] [<ffffffff8091845c>] _raw_spin_unlock_irqrestore+0x1a/0x2e
> > [ 1.321887] [<ffffffff80473d06>] imsic_local_timer_callback+0x50/0x5c
> > [ 1.322957] [<ffffffff8008ade4>] call_timer_fn.isra.0+0x14/0x5e
> > [ 1.323781] [<ffffffff8008b44a>] run_timer_softirq+0x388/0x3a8
> > [ 1.324579] [<ffffffff80918c7e>] __do_softirq+0x100/0x252
> > [ 1.325304] [<ffffffff80018464>] irq_exit_rcu+0x7c/0xa6
> > [ 1.326126] [<ffffffff8090ed24>] handle_riscv_irq+0x64/0x74
> > [ 1.327535] [<ffffffff80918af6>] call_on_irq_stack+0x32/0x40
> > [ 1.328703] handlers:
> > [ 1.330724] [<000000008b6c4f15>] serial8250_interrupt
> > [ 1.331573] Disabling IRQ #12
> > [ 1.350231] Run /sbin/init as init process
> >
> > And I take a look on /proc/interrupts, spurious interrupts are happening:
> > ~ # cat /proc/interrupts
> > CPU0 CPU1 CPU2 CPU3 CPU4 CPU5 CPU6 CPU7 CPU8 CPU9 CPU10 CPU11 CPU12 CPU13 CPU14 CPU15
> > 10: 83 222 350 163 71 101 193 68 54 60 174 50 51 48 48 46 RISC-V INTC 5 Edge riscv-timer
> > 11: 100001 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 APLIC-MSI-d000000.aplic 8 Level -fasteoi virtio0
> > 12: 0 100000 0 0 0 0 0 0 0 0 0 0 0 0 0 0 APLIC-MSI-d000000.aplic 10 Level -fasteoi ttyS0
> > 13: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 APLIC-MSI-d000000.aplic 11 Level -fasteoi 101000.rtc
> > IPI0: 3 8 4 7 7 6 5 4 7 7 7 5 6 10 4 5 Rescheduling interrupts
> > IPI1: 727 517 431 448 497 456 514 476 488 466 455 456 443 443 439 433 Function call interrupts
> > IPI2: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 CPU stop interrupts
> > IPI3: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 CPU stop (for crash dump) interrupts
> > IPI4: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 IRQ work interrupts
> > IPI5: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 Timer broadcast interrupts
> >
> > But when I switched back to V15, everything is fine.
> >
> > Here are some of info _maybe_ helpful:
> > kernel: d7d4d086b79a11ad8bbcaf732c7830faa3f3192f
> > qemu: e1007b6bab5cf97705bf4f2aaec1f607787355b8
> > qemu cmdline: qemu-system-riscv64 -M virt,aia=aplic-imsic -m 256M -nographic -kernel ~/src/linux/arch/riscv/boot/Image -drive file=rootfs.img,format=raw,id=hd0 -device virtio-blk-device,drive=hd0 -append "root=/dev/vda rw console=ttyS0" -smp 16
> > config: defconfig(make ARCH=riscv defconfig)
> >
> > And I am happy to provide any extra info if needed.
> >
> > After I take a git diff and check your changelog:
> > [Quoting from [1]]
> > - Simplified aplic_msi_irq_eoi() in PATCH7 based on the section "4.9.2 Special
> > consideration for level-sensitive interrupt sources" of the RISC-V AIA
> > specification and also provided handler name.
> >
> > I apologize if I miss something.
> >
> > [1] https://lore.kernel.org/lkml/20240307140307.646078-1-apatel@ventanamicro.com/
>
> The QEMU APLIC emulation of the setipnum register was broken. The
> corresponding QEMU fixes are already accepted and queued by the
> maintainer.
>
> Please refer, https://lore.kernel.org/all/20240306095722.463296-1-apatel@ventanamicro.com/
After pulling latest QEMU which contains 2 commits above, problem solved.
Thanks for the fix.
Thanks,
Dawei
>
> Regards,
> Anup
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v16 0/9] Linux RISC-V AIA Support
@ 2024-03-07 14:02 Anup Patel
2024-03-07 14:11 ` Anup Patel
2024-03-08 11:11 ` Björn Töpel
0 siblings, 2 replies; 8+ messages in thread
From: Anup Patel @ 2024-03-07 14:02 UTC (permalink / raw)
To: Palmer Dabbelt, Paul Walmsley, Thomas Gleixner, Rob Herring,
Krzysztof Kozlowski, Frank Rowand, Conor Dooley
Cc: Marc Zyngier, Björn Töpel, Atish Patra, Andrew Jones,
Sunil V L, Saravana Kannan, Anup Patel, linux-riscv,
linux-arm-kernel, linux-kernel, devicetree, Anup Patel
The RISC-V AIA specification is ratified as-per the RISC-V international
process. The latest ratified AIA specifcation can be found at:
https://github.com/riscv/riscv-aia/releases/download/1.0/riscv-interrupts-1.0.pdf
At a high-level, the AIA specification adds three things:
1) AIA CSRs
- Improved local interrupt support
2) Incoming Message Signaled Interrupt Controller (IMSIC)
- Per-HART MSI controller
- Support MSI virtualization
- Support IPI along with virtualization
3) Advanced Platform-Level Interrupt Controller (APLIC)
- Wired interrupt controller
- In MSI-mode, converts wired interrupt into MSIs (i.e. MSI generator)
- In Direct-mode, injects external interrupts directly into HARTs
For an overview of the AIA specification, refer the AIA virtualization
talk at KVM Forum 2022:
https://static.sched.com/hosted_files/kvmforum2022/a1/AIA_Virtualization_in_KVM_RISCV_final.pdf
https://www.youtube.com/watch?v=r071dL8Z0yo
To test this series, use QEMU v7.2 (or higher) and OpenSBI v1.2 (or higher).
This series depends upon per-device MSI domain (and few other) patches merged
by Thomas (tglx) which are available in irq/msi branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
These patches can also be found in the riscv_aia_v16 branch at:
https://github.com/avpatel/linux.git
Changes since v15:
- Dropped PATCH1 since it is already merged by Thomas (tglx) and available in
his irq/msi branch at git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
- Simplified aplic_msi_irq_eoi() in PATCH7 based on the section "4.9.2 Special
consideration for level-sensitive interrupt sources" of the RISC-V AIA
specification and also provided handler name.
Changes since v14:
- Dropped 9 patches which are already merged by Thomas (tglx) and available in
his irq/msi branch at git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
- Added new PATCH1 which adds changes missed out in merging AIA support for
RISC-V INTC.
- Added a separate cpuhp state for IMSIC driver in PATCH3 which ensures that
cpuhp notifiers of IMSIC are called as early as possible.
- Removed redundant barriers in PATCH3.
- Addressed few other nit comments.
Changes since v13:
- Split PATCH1 into six granular patches
- Addressed nit comments from Thomas and Bjorn
Changes since v12:
- Rebased on Linux-6.8-rc5
- Dropped per-device MSI domain patches which are already merged by Thomas (tglx)
- Addressed nit comments from Thomas and Clement
- Added a new patch2 to fix lock dependency warning
- Replaced local sync IPI in the IMSIC driver with per-CPU timer
- Simplified locking in the IMSIC driver to avoid lock dependency issues
- Added a dirty bitmap in the IMSIC driver to optimize per-CPU local sync loop
Changes since v11:
- Rebased on Linux-6.8-rc1
- Included kernel/irq related patches from "genirq, irqchip: Convert ARM
MSI handling to per device MSI domains" series by Thomas.
(PATCH7, PATCH8, PATCH9, PATCH14, PATCH16, PATCH17, PATCH18, PATCH19,
PATCH20, PATCH21, PATCH22, PATCH23, and PATCH32 of
https://lore.kernel.org/linux-arm-kernel/20221121135653.208611233@linutronix.de/)
- Updated APLIC MSI-mode driver to use the new WIRED_TO_MSI mechanism.
- Updated IMSIC driver to support per-device MSI domains for PCI and
platform devices.
Changes since v10:
- Rebased on Linux-6.6-rc7
- Dropped PATCH3 of v10 series since this has been merged by MarcZ
for Linux-6.6-rc7
- Changed the IMSIC ID management strategy from 1-n approach to
x86-style 1-1 approach
Changes since v9:
- Rebased on Linux-6.6-rc4
- Use builtin_platform_driver() in PATCH5, PATCH9, and PATCH12
Changes since v8:
- Rebased on Linux-6.6-rc3
- Dropped PATCH2 of v8 series since we won't be requiring
riscv_get_intc_hartid() based on Marc Z's comments on ACPI AIA support.
- Addressed Saravana's comments in PATCH3 of v8 series
- Update PATCH9 and PATCH13 of v8 series based on comments from Sunil
Changes since v7:
- Rebased on Linux-6.6-rc1
- Addressed comments on PATCH1 of v7 series and split it into two PATCHes
- Use DEFINE_SIMPLE_PROP() in PATCH2 of v7 series
Changes since v6:
- Rebased on Linux-6.5-rc4
- Updated PATCH2 to use IS_ENABLED(CONFIG_SPARC) instead of
!IS_ENABLED(CONFIG_OF_IRQ)
- Added new PATCH4 to fix syscore registration in PLIC driver
- Update PATCH5 to convert PLIC driver into full-blown platform driver
with a re-written probe function.
Changes since v5:
- Rebased on Linux-6.5-rc2
- Updated the overall series to ensure that only IPI, timer, and
INTC drivers are probed very early whereas rest of the interrupt
controllers (such as PLIC, APLIC, and IMISC) are probed as
regular platform drivers.
- Renamed riscv_fw_parent_hartid() to riscv_get_intc_hartid()
- New PATCH1 to add fw_devlink support for msi-parent DT property
- New PATCH2 to ensure all INTC suppliers are initialized which in-turn
fixes the probing issue for PLIC, APLIC and IMSIC as platform driver
- New PATCH3 to use platform driver probing for PLIC
- Re-structured the IMSIC driver into two separate drivers: early and
platform. The IMSIC early driver (PATCH7) only initialized IMSIC state
and provides IPIs whereas the IMSIC platform driver (PATCH8) is probed
provides MSI domain for platform devices.
- Re-structure the APLIC platform driver into three separe sources: main,
direct mode, and MSI mode.
Changes since v4:
- Rebased on Linux-6.5-rc1
- Added "Dependencies" in the APLIC bindings (PATCH6 in v4)
- Dropped the PATCH6 which was changing the IOMMU DMA domain APIs
- Dropped use of IOMMU DMA APIs in the IMSIC driver (PATCH4)
Changes since v3:
- Rebased on Linux-6.4-rc6
- Dropped PATCH2 of v3 series instead we now set FWNODE_FLAG_BEST_EFFORT via
IRQCHIP_DECLARE()
- Extend riscv_fw_parent_hartid() to support both DT and ACPI in PATCH1
- Extend iommu_dma_compose_msi_msg() instead of adding iommu_dma_select_msi()
in PATCH6
- Addressed Conor's comments in PATCH3
- Addressed Conor's and Rob's comments in PATCH7
Changes since v2:
- Rebased on Linux-6.4-rc1
- Addressed Rob's comments on DT bindings patches 4 and 8.
- Addessed Marc's comments on IMSIC driver PATCH5
- Replaced use of OF apis in APLIC and IMSIC drivers with FWNODE apis
this makes both drivers easily portable for ACPI support. This also
removes unnecessary indirection from the APLIC and IMSIC drivers.
- PATCH1 is a new patch for portability with ACPI support
- PATCH2 is a new patch to fix probing in APLIC drivers for APLIC-only systems.
- PATCH7 is a new patch which addresses the IOMMU DMA domain issues pointed
out by SiFive
Changes since v1:
- Rebased on Linux-6.2-rc2
- Addressed comments on IMSIC DT bindings for PATCH4
- Use raw_spin_lock_irqsave() on ids_lock for PATCH5
- Improved MMIO alignment checks in PATCH5 to allow MMIO regions
with holes.
- Addressed comments on APLIC DT bindings for PATCH6
- Fixed warning splat in aplic_msi_write_msg() caused by
zeroed MSI message in PATCH7
- Dropped DT property riscv,slow-ipi instead will have module
parameter in future.
Anup Patel (9):
dt-bindings: interrupt-controller: Add RISC-V incoming MSI controller
irqchip: Add RISC-V incoming MSI controller early driver
irqchip/riscv-imsic: Add device MSI domain support for platform
devices
irqchip/riscv-imsic: Add device MSI domain support for PCI devices
dt-bindings: interrupt-controller: Add RISC-V advanced PLIC
irqchip: Add RISC-V advanced PLIC driver for direct-mode
irqchip/riscv-aplic: Add support for MSI-mode
RISC-V: Select APLIC and IMSIC drivers
MAINTAINERS: Add entry for RISC-V AIA drivers
.../interrupt-controller/riscv,aplic.yaml | 172 ++++
.../interrupt-controller/riscv,imsics.yaml | 172 ++++
MAINTAINERS | 14 +
arch/riscv/Kconfig | 2 +
drivers/irqchip/Kconfig | 25 +
drivers/irqchip/Makefile | 3 +
drivers/irqchip/irq-riscv-aplic-direct.c | 326 +++++++
drivers/irqchip/irq-riscv-aplic-main.c | 211 +++++
drivers/irqchip/irq-riscv-aplic-main.h | 52 ++
drivers/irqchip/irq-riscv-aplic-msi.c | 257 ++++++
drivers/irqchip/irq-riscv-imsic-early.c | 201 ++++
drivers/irqchip/irq-riscv-imsic-platform.c | 374 ++++++++
drivers/irqchip/irq-riscv-imsic-state.c | 865 ++++++++++++++++++
drivers/irqchip/irq-riscv-imsic-state.h | 108 +++
include/linux/cpuhotplug.h | 1 +
include/linux/irqchip/riscv-aplic.h | 145 +++
include/linux/irqchip/riscv-imsic.h | 87 ++
17 files changed, 3015 insertions(+)
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,aplic.yaml
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,imsics.yaml
create mode 100644 drivers/irqchip/irq-riscv-aplic-direct.c
create mode 100644 drivers/irqchip/irq-riscv-aplic-main.c
create mode 100644 drivers/irqchip/irq-riscv-aplic-main.h
create mode 100644 drivers/irqchip/irq-riscv-aplic-msi.c
create mode 100644 drivers/irqchip/irq-riscv-imsic-early.c
create mode 100644 drivers/irqchip/irq-riscv-imsic-platform.c
create mode 100644 drivers/irqchip/irq-riscv-imsic-state.c
create mode 100644 drivers/irqchip/irq-riscv-imsic-state.h
create mode 100644 include/linux/irqchip/riscv-aplic.h
create mode 100644 include/linux/irqchip/riscv-imsic.h
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v16 0/9] Linux RISC-V AIA Support
2024-03-07 14:02 Anup Patel
@ 2024-03-07 14:11 ` Anup Patel
2024-03-07 21:03 ` Thomas Gleixner
2024-03-08 11:11 ` Björn Töpel
1 sibling, 1 reply; 8+ messages in thread
From: Anup Patel @ 2024-03-07 14:11 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Marc Zyngier, Björn Töpel, Atish Patra, Andrew Jones,
Rob Herring, Sunil V L, Saravana Kannan, Anup Patel, linux-riscv,
Paul Walmsley, linux-arm-kernel, linux-kernel, devicetree,
Palmer Dabbelt, Conor Dooley, Frank Rowand, Krzysztof Kozlowski
Hi Thomas,
On Thu, Mar 7, 2024 at 7:33 PM Anup Patel <apatel@ventanamicro.com> wrote:
>
> The RISC-V AIA specification is ratified as-per the RISC-V international
> process. The latest ratified AIA specifcation can be found at:
> https://github.com/riscv/riscv-aia/releases/download/1.0/riscv-interrupts-1.0.pdf
>
> At a high-level, the AIA specification adds three things:
> 1) AIA CSRs
> - Improved local interrupt support
> 2) Incoming Message Signaled Interrupt Controller (IMSIC)
> - Per-HART MSI controller
> - Support MSI virtualization
> - Support IPI along with virtualization
> 3) Advanced Platform-Level Interrupt Controller (APLIC)
> - Wired interrupt controller
> - In MSI-mode, converts wired interrupt into MSIs (i.e. MSI generator)
> - In Direct-mode, injects external interrupts directly into HARTs
>
> For an overview of the AIA specification, refer the AIA virtualization
> talk at KVM Forum 2022:
> https://static.sched.com/hosted_files/kvmforum2022/a1/AIA_Virtualization_in_KVM_RISCV_final.pdf
> https://www.youtube.com/watch?v=r071dL8Z0yo
>
> To test this series, use QEMU v7.2 (or higher) and OpenSBI v1.2 (or higher).
>
> This series depends upon per-device MSI domain (and few other) patches merged
> by Thomas (tglx) which are available in irq/msi branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
>
> These patches can also be found in the riscv_aia_v16 branch at:
> https://github.com/avpatel/linux.git
>
> Changes since v15:
> - Dropped PATCH1 since it is already merged by Thomas (tglx) and available in
> his irq/msi branch at git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> - Simplified aplic_msi_irq_eoi() in PATCH7 based on the section "4.9.2 Special
> consideration for level-sensitive interrupt sources" of the RISC-V AIA
> specification and also provided handler name.
>
> Changes since v14:
> - Dropped 9 patches which are already merged by Thomas (tglx) and available in
> his irq/msi branch at git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> - Added new PATCH1 which adds changes missed out in merging AIA support for
> RISC-V INTC.
> - Added a separate cpuhp state for IMSIC driver in PATCH3 which ensures that
> cpuhp notifiers of IMSIC are called as early as possible.
> - Removed redundant barriers in PATCH3.
> - Addressed few other nit comments.
>
> Changes since v13:
> - Split PATCH1 into six granular patches
> - Addressed nit comments from Thomas and Bjorn
>
> Changes since v12:
> - Rebased on Linux-6.8-rc5
> - Dropped per-device MSI domain patches which are already merged by Thomas (tglx)
> - Addressed nit comments from Thomas and Clement
> - Added a new patch2 to fix lock dependency warning
> - Replaced local sync IPI in the IMSIC driver with per-CPU timer
> - Simplified locking in the IMSIC driver to avoid lock dependency issues
> - Added a dirty bitmap in the IMSIC driver to optimize per-CPU local sync loop
>
> Changes since v11:
> - Rebased on Linux-6.8-rc1
> - Included kernel/irq related patches from "genirq, irqchip: Convert ARM
> MSI handling to per device MSI domains" series by Thomas.
> (PATCH7, PATCH8, PATCH9, PATCH14, PATCH16, PATCH17, PATCH18, PATCH19,
> PATCH20, PATCH21, PATCH22, PATCH23, and PATCH32 of
> https://lore.kernel.org/linux-arm-kernel/20221121135653.208611233@linutronix.de/)
> - Updated APLIC MSI-mode driver to use the new WIRED_TO_MSI mechanism.
> - Updated IMSIC driver to support per-device MSI domains for PCI and
> platform devices.
>
> Changes since v10:
> - Rebased on Linux-6.6-rc7
> - Dropped PATCH3 of v10 series since this has been merged by MarcZ
> for Linux-6.6-rc7
> - Changed the IMSIC ID management strategy from 1-n approach to
> x86-style 1-1 approach
>
> Changes since v9:
> - Rebased on Linux-6.6-rc4
> - Use builtin_platform_driver() in PATCH5, PATCH9, and PATCH12
>
> Changes since v8:
> - Rebased on Linux-6.6-rc3
> - Dropped PATCH2 of v8 series since we won't be requiring
> riscv_get_intc_hartid() based on Marc Z's comments on ACPI AIA support.
> - Addressed Saravana's comments in PATCH3 of v8 series
> - Update PATCH9 and PATCH13 of v8 series based on comments from Sunil
>
> Changes since v7:
> - Rebased on Linux-6.6-rc1
> - Addressed comments on PATCH1 of v7 series and split it into two PATCHes
> - Use DEFINE_SIMPLE_PROP() in PATCH2 of v7 series
>
> Changes since v6:
> - Rebased on Linux-6.5-rc4
> - Updated PATCH2 to use IS_ENABLED(CONFIG_SPARC) instead of
> !IS_ENABLED(CONFIG_OF_IRQ)
> - Added new PATCH4 to fix syscore registration in PLIC driver
> - Update PATCH5 to convert PLIC driver into full-blown platform driver
> with a re-written probe function.
>
> Changes since v5:
> - Rebased on Linux-6.5-rc2
> - Updated the overall series to ensure that only IPI, timer, and
> INTC drivers are probed very early whereas rest of the interrupt
> controllers (such as PLIC, APLIC, and IMISC) are probed as
> regular platform drivers.
> - Renamed riscv_fw_parent_hartid() to riscv_get_intc_hartid()
> - New PATCH1 to add fw_devlink support for msi-parent DT property
> - New PATCH2 to ensure all INTC suppliers are initialized which in-turn
> fixes the probing issue for PLIC, APLIC and IMSIC as platform driver
> - New PATCH3 to use platform driver probing for PLIC
> - Re-structured the IMSIC driver into two separate drivers: early and
> platform. The IMSIC early driver (PATCH7) only initialized IMSIC state
> and provides IPIs whereas the IMSIC platform driver (PATCH8) is probed
> provides MSI domain for platform devices.
> - Re-structure the APLIC platform driver into three separe sources: main,
> direct mode, and MSI mode.
>
> Changes since v4:
> - Rebased on Linux-6.5-rc1
> - Added "Dependencies" in the APLIC bindings (PATCH6 in v4)
> - Dropped the PATCH6 which was changing the IOMMU DMA domain APIs
> - Dropped use of IOMMU DMA APIs in the IMSIC driver (PATCH4)
>
> Changes since v3:
> - Rebased on Linux-6.4-rc6
> - Dropped PATCH2 of v3 series instead we now set FWNODE_FLAG_BEST_EFFORT via
> IRQCHIP_DECLARE()
> - Extend riscv_fw_parent_hartid() to support both DT and ACPI in PATCH1
> - Extend iommu_dma_compose_msi_msg() instead of adding iommu_dma_select_msi()
> in PATCH6
> - Addressed Conor's comments in PATCH3
> - Addressed Conor's and Rob's comments in PATCH7
>
> Changes since v2:
> - Rebased on Linux-6.4-rc1
> - Addressed Rob's comments on DT bindings patches 4 and 8.
> - Addessed Marc's comments on IMSIC driver PATCH5
> - Replaced use of OF apis in APLIC and IMSIC drivers with FWNODE apis
> this makes both drivers easily portable for ACPI support. This also
> removes unnecessary indirection from the APLIC and IMSIC drivers.
> - PATCH1 is a new patch for portability with ACPI support
> - PATCH2 is a new patch to fix probing in APLIC drivers for APLIC-only systems.
> - PATCH7 is a new patch which addresses the IOMMU DMA domain issues pointed
> out by SiFive
>
> Changes since v1:
> - Rebased on Linux-6.2-rc2
> - Addressed comments on IMSIC DT bindings for PATCH4
> - Use raw_spin_lock_irqsave() on ids_lock for PATCH5
> - Improved MMIO alignment checks in PATCH5 to allow MMIO regions
> with holes.
> - Addressed comments on APLIC DT bindings for PATCH6
> - Fixed warning splat in aplic_msi_write_msg() caused by
> zeroed MSI message in PATCH7
> - Dropped DT property riscv,slow-ipi instead will have module
> parameter in future.
>
> Anup Patel (9):
> dt-bindings: interrupt-controller: Add RISC-V incoming MSI controller
> irqchip: Add RISC-V incoming MSI controller early driver
> irqchip/riscv-imsic: Add device MSI domain support for platform
> devices
> irqchip/riscv-imsic: Add device MSI domain support for PCI devices
> dt-bindings: interrupt-controller: Add RISC-V advanced PLIC
> irqchip: Add RISC-V advanced PLIC driver for direct-mode
> irqchip/riscv-aplic: Add support for MSI-mode
> RISC-V: Select APLIC and IMSIC drivers
> MAINTAINERS: Add entry for RISC-V AIA drivers
Can this series be considered for Linux-6.9 ?
Regards,
Anup
>
> .../interrupt-controller/riscv,aplic.yaml | 172 ++++
> .../interrupt-controller/riscv,imsics.yaml | 172 ++++
> MAINTAINERS | 14 +
> arch/riscv/Kconfig | 2 +
> drivers/irqchip/Kconfig | 25 +
> drivers/irqchip/Makefile | 3 +
> drivers/irqchip/irq-riscv-aplic-direct.c | 326 +++++++
> drivers/irqchip/irq-riscv-aplic-main.c | 211 +++++
> drivers/irqchip/irq-riscv-aplic-main.h | 52 ++
> drivers/irqchip/irq-riscv-aplic-msi.c | 257 ++++++
> drivers/irqchip/irq-riscv-imsic-early.c | 201 ++++
> drivers/irqchip/irq-riscv-imsic-platform.c | 374 ++++++++
> drivers/irqchip/irq-riscv-imsic-state.c | 865 ++++++++++++++++++
> drivers/irqchip/irq-riscv-imsic-state.h | 108 +++
> include/linux/cpuhotplug.h | 1 +
> include/linux/irqchip/riscv-aplic.h | 145 +++
> include/linux/irqchip/riscv-imsic.h | 87 ++
> 17 files changed, 3015 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,aplic.yaml
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,imsics.yaml
> create mode 100644 drivers/irqchip/irq-riscv-aplic-direct.c
> create mode 100644 drivers/irqchip/irq-riscv-aplic-main.c
> create mode 100644 drivers/irqchip/irq-riscv-aplic-main.h
> create mode 100644 drivers/irqchip/irq-riscv-aplic-msi.c
> create mode 100644 drivers/irqchip/irq-riscv-imsic-early.c
> create mode 100644 drivers/irqchip/irq-riscv-imsic-platform.c
> create mode 100644 drivers/irqchip/irq-riscv-imsic-state.c
> create mode 100644 drivers/irqchip/irq-riscv-imsic-state.h
> create mode 100644 include/linux/irqchip/riscv-aplic.h
> create mode 100644 include/linux/irqchip/riscv-imsic.h
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v16 0/9] Linux RISC-V AIA Support
2024-03-07 14:11 ` Anup Patel
@ 2024-03-07 21:03 ` Thomas Gleixner
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Gleixner @ 2024-03-07 21:03 UTC (permalink / raw)
To: Anup Patel
Cc: Marc Zyngier, Björn Töpel, Atish Patra, Andrew Jones,
Rob Herring, Sunil V L, Saravana Kannan, Anup Patel, linux-riscv,
Paul Walmsley, linux-arm-kernel, linux-kernel, devicetree,
Palmer Dabbelt, Conor Dooley, Frank Rowand, Krzysztof Kozlowski
On Thu, Mar 07 2024 at 19:41, Anup Patel wrote:
>
> Can this series be considered for Linux-6.9 ?
Sorry no. I stop taking patches which are not fixes or trivial cleanups
at rc7 latest. I marked it for inclusion into my post-merge window tree.
Thanks,
tglx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v16 0/9] Linux RISC-V AIA Support
2024-03-07 14:02 Anup Patel
2024-03-07 14:11 ` Anup Patel
@ 2024-03-08 11:11 ` Björn Töpel
2024-03-08 11:13 ` Björn Töpel
1 sibling, 1 reply; 8+ messages in thread
From: Björn Töpel @ 2024-03-08 11:11 UTC (permalink / raw)
To: Anup Patel, Palmer Dabbelt, Paul Walmsley, Thomas Gleixner,
Rob Herring, Krzysztof Kozlowski, Frank Rowand, Conor Dooley
Cc: Anup Patel, devicetree, Saravana Kannan, Marc Zyngier,
Anup Patel, linux-kernel, Atish Patra, linux-riscv,
linux-arm-kernel, Andrew Jones
Anup Patel <apatel@ventanamicro.com> writes:
> The RISC-V AIA specification is ratified as-per the RISC-V international
> process. The latest ratified AIA specifcation can be found at:
> https://github.com/riscv/riscv-aia/releases/download/1.0/riscv-interrupts-1.0.pdf
It's been a been a long ride, and I got in late (v10)... Thanks for the
hard work, Anup!
Note that Alex' text-patching/IPI series [1] needs to go into the RV
tree at roughly the same time as AIA.
I've not caught any regressions for kselftests on qemu for this version
(with Alex' series applied). I have not run it on real hardware.
For the series:
Tested-by: Björn Töpel <bjorn@rivosinc.com>
Reviewed-by: Björn Töpel <bjorn@rivosinc.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v16 0/9] Linux RISC-V AIA Support
2024-03-08 11:11 ` Björn Töpel
@ 2024-03-08 11:13 ` Björn Töpel
0 siblings, 0 replies; 8+ messages in thread
From: Björn Töpel @ 2024-03-08 11:13 UTC (permalink / raw)
To: Anup Patel, Palmer Dabbelt, Paul Walmsley, Thomas Gleixner,
Rob Herring, Krzysztof Kozlowski, Frank Rowand, Conor Dooley
Cc: Anup Patel, devicetree, Saravana Kannan, Marc Zyngier,
Anup Patel, linux-kernel, Atish Patra, linux-riscv,
linux-arm-kernel, Andrew Jones
Björn Töpel <bjorn@kernel.org> writes:
> Anup Patel <apatel@ventanamicro.com> writes:
>
>> The RISC-V AIA specification is ratified as-per the RISC-V international
>> process. The latest ratified AIA specifcation can be found at:
>> https://github.com/riscv/riscv-aia/releases/download/1.0/riscv-interrupts-1.0.pdf
>
> It's been a been a long ride, and I got in late (v10)... Thanks for the
> hard work, Anup!
Too excited! ;-)
s/a been//
> Note that Alex' text-patching/IPI series [1] needs to go into the RV
> tree at roughly the same time as AIA.
...and missing reference:
[1] https://lore.kernel.org/linux-riscv/20240229121056.203419-3-alexghiti@rivosinc.com/
> I've not caught any regressions for kselftests on qemu for this version
> (with Alex' series applied). I have not run it on real hardware.
>
> For the series:
>
> Tested-by: Björn Töpel <bjorn@rivosinc.com>
> Reviewed-by: Björn Töpel <bjorn@rivosinc.com>
Have a nice w/e,
Björn
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-03-14 6:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-14 5:47 [PATCH v16 0/9] Linux RISC-V AIA Support Dawei Li
2024-03-14 6:21 ` Anup Patel
2024-03-14 6:59 ` Dawei Li
-- strict thread matches above, loose matches on Subject: below --
2024-03-07 14:02 Anup Patel
2024-03-07 14:11 ` Anup Patel
2024-03-07 21:03 ` Thomas Gleixner
2024-03-08 11:11 ` Björn Töpel
2024-03-08 11:13 ` Björn Töpel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®