mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
	Linus Walleij <linus.walleij@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
	Jonathan Cameron <jic23@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/3] irq/irq_sim: add a simple interrupt simulator framework
Date: Mon, 24 Jul 2017 09:31:44 +0200	[thread overview]
Message-ID: <3444eb00-4097-9776-2e40-e19db6be5ab3@metafoo.de> (raw)
In-Reply-To: <1500466814-32679-2-git-send-email-brgl@bgdev.pl>

On 07/19/2017 02:20 PM, Bartosz Golaszewski wrote:
[...]
> +void irq_sim_fini(struct irq_sim *sim)
> +{

Not very likely to happen in practice, but for correctness we should
probably put a irq_work_sync() here for each of the IRQs to make sure that
the memory associated with the irq_sim_work_ctx struct is no longer accessed
and that handle_simple_irq() is not called after irq_free_descs().


> +	irq_free_descs(sim->irq_base, sim->irq_count);
> +	kfree(sim->irqs);
> +}
> +EXPORT_SYMBOL_GPL(irq_sim_fini);

  parent reply	other threads:[~2017-07-24  7:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19 12:20 [PATCH 0/3] simulated interrupts Bartosz Golaszewski
2017-07-19 12:20 ` [PATCH 1/3] irq/irq_sim: add a simple interrupt simulator framework Bartosz Golaszewski
2017-07-22 20:59   ` Jonathan Cameron
2017-07-24  6:54     ` Bartosz Golaszewski
2017-07-24  7:31   ` Lars-Peter Clausen [this message]
2017-07-19 12:20 ` [PATCH 2/3] irq/irq_sim: add a devres variant of irq_sim_init() Bartosz Golaszewski
2017-07-19 12:20 ` [PATCH 3/3] gpio: mockup: use irq_sim Bartosz Golaszewski
2017-08-02 11:34   ` Linus Walleij
2017-07-19 12:25 ` [PATCH 0/3] simulated interrupts Thomas Gleixner
2017-07-19 12:44   ` Bartosz Golaszewski
2017-07-19 13:58     ` Thomas Gleixner
2017-07-19 14:19       ` Marc Zyngier
2017-07-19 14:43         ` Andy Shevchenko
2017-07-19 14:53           ` Thomas Gleixner
2017-07-19 15:28             ` Andy Shevchenko
2017-08-02 11:32         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3444eb00-4097-9776-2e40-e19db6be5ab3@metafoo.de \
    --to=lars@metafoo.de \
    --cc=bamvor.zhangjian@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=corbet@lwn.net \
    --cc=jic23@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®