mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Daniel Stone <daniel@fooishbar.org>,
	Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Sandy Huang <hjc@rock-chips.com>, Andy Yan <andyshrk@163.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Daniel Stone <daniels@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Sashiko <sashiko-bot@kernel.org>,
	Igor Paunovic <royalnet026@gmail.com>,
	Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH v6 00/15] Support 10-bit YUV422 and 8/10-bit YUV420 color format on DW HDMI QP
Date: Thu, 05 Nov 2026 14:22:44 +0100	[thread overview]
Message-ID: <34506010.aRNtrjHk3s@diego> (raw)
In-Reply-To: <81fbb960-abde-44ea-82ab-3adc054da836@collabora.com>

Am Donnerstag, 5. November 2026, 14:04:25 Mitteleuropäische Normalzeit schrieb Cristian Ciocaltea:
> Hi Daniel,
> 
> On 11/5/26 2:25 PM, Daniel Stone wrote:
> > Hi Cristi,
> > 
> > On Thu, 5 Nov 2026 at 01:01, Cristian Ciocaltea
> > <cristian.ciocaltea@collabora.com> wrote:
> >> Changes in v6:
> >> - Added new vop2 patch "Disable core clocks before dropping runtime PM
> >>   reference" (Sashiko)
> >>
> >> Changes in v5:
> >> - Added new patch "drm/rockchip: dw_hdmi_qp: Do not mask error code in
> >>   atomic_check()" to fix a pre-existing issue reported by Sashiko
> >>
> >> Changes in v3:
> >> - Updated patch 3 to skip any hardware programming in the callbacks
> >>   gated by drm_atomic_helper_commit_planes() after powering down VOP2 on
> >>   an atomic_enable() error (Sashiko)
> >> - Ensured VBLANK events are sent immediately when atomic_enable() fails,
> >>   hence preventing userspace processes waiting for the page flip
> >>   completion to hang indefinitely (new patch 4, Sashiko)
> >>
> >> Changes in v2:
> >> - Addressed several issues reported by Sashiko
> >>   * Reset AXI before detaching the IOMMU domain, to close a theoretical
> >>     window where stale or in-flight DMA transactions could fault or
> >>     access memory untranslated after the domain is detached (patch 6)
> >>   * Fixed resource leak on vop2_enable() error path (new patch 2)
> >>   * Balance state on atomic_enable error paths (new patch 3)
> >>   * Avoided division by zero when computing max_dclk (new path 4)
> >>   * Fixed VOP2_MAX_DCLK_RATE overflow on 32-bit (new patch 5)
> > 
> > I think everything in here should now be solidly reviewed. 
> 
> Thanks a lot for checking this out!

except patch 9 of 15, or mail hasn't turned up yet :-)

It does look fine to me, but if someone has an eye to spare ...


Heiko



  reply	other threads:[~2026-11-05 13:23 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  1:00 Cristian Ciocaltea
2026-11-05  1:00 ` [PATCH v6 01/15] dt-bindings: display: vop2: Add missing reset properties Cristian Ciocaltea
2026-11-05  1:00 ` [PATCH v6 02/15] drm/rockchip: vop2: Fix resource leak on vop2_enable() error path Cristian Ciocaltea
2026-11-05  1:00 ` [PATCH v6 03/15] drm/rockchip: vop2: Disable core clocks before dropping runtime PM reference Cristian Ciocaltea
2026-11-05 11:43   ` Daniel Stone
2026-11-05  1:00 ` [PATCH v6 04/15] drm/rockchip: vop2: Balance state on atomic_enable() error paths Cristian Ciocaltea
2026-11-05 12:24   ` Daniel Stone
2026-11-05  1:00 ` [PATCH v6 05/15] drm/rockchip: vop2: Avoid division by zero when computing max_dclk Cristian Ciocaltea
2026-11-05  1:00 ` [PATCH v6 06/15] drm/rockchip: vop2: Fix VOP2_MAX_DCLK_RATE overflow on 32-bit Cristian Ciocaltea
2026-11-05  1:00 ` [PATCH v6 07/15] drm/rockchip: vop2: Reset AXI and DCLK to improve robustness Cristian Ciocaltea
2026-11-05  1:00 ` [PATCH v6 08/15] drm/rockchip: vop2: Consolidate HDMI PHY PLL clock parent switch Cristian Ciocaltea
2026-11-05 12:18   ` Daniel Stone
2026-11-05 12:56     ` Cristian Ciocaltea
2026-11-05 14:33       ` Daniel Stone
2026-11-05  1:00 ` [PATCH v6 09/15] drm/rockchip: vop2: Use TMDS character rate to select DCLK source Cristian Ciocaltea
2026-11-05 14:35   ` Daniel Stone
2026-11-05  1:00 ` [PATCH v6 10/15] drm/rockchip: vop2: Switch to enum vop_csc_format Cristian Ciocaltea
2026-11-05  1:00 ` [PATCH v6 11/15] drm/bridge: dw-hdmi-qp: Log resolution and refresh rate in atomic_enable() Cristian Ciocaltea
2026-11-05  1:00 ` [PATCH v6 12/15] drm/rockchip: dw_hdmi_qp: Do not mask error code in atomic_check() Cristian Ciocaltea
2026-11-05 11:55   ` Daniel Stone
2026-11-05  1:00 ` [PATCH v6 13/15] drm/rockchip: dw_hdmi_qp: Support 10-bit YUV422 output format Cristian Ciocaltea
2026-11-05 12:08   ` Daniel Stone
2026-11-05  1:00 ` [PATCH v6 14/15] drm/rockchip: dw_hdmi_qp: Enable YUV420 " Cristian Ciocaltea
2026-11-05 12:09   ` Daniel Stone
2026-11-05  1:00 ` [PATCH v6 15/15] arm64: dts: rockchip: Add RK3588 VOP2 resets Cristian Ciocaltea
2026-11-05 12:25 ` [PATCH v6 00/15] Support 10-bit YUV422 and 8/10-bit YUV420 color format on DW HDMI QP Daniel Stone
2026-11-05 13:04   ` Cristian Ciocaltea
2026-11-05 13:22     ` Heiko Stübner [this message]
2026-11-05 14:36       ` Daniel Stone
2026-11-05 14:35     ` Daniel Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34506010.aRNtrjHk3s@diego \
    --to=heiko@sntech.de \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=andyshrk@163.com \
    --cc=conor+dt@kernel.org \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=daniel@fooishbar.org \
    --cc=daniels@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=royalnet026@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sashiko-bot@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®