Re: [PATCH v6 00/15] Support 10-bit YUV422 and 8/10-bit YUV420 color format on DW HDMI QP

[Cristian Ciocaltea <cristian.ciocaltea@collabora.com>]

Hi Daniel,

On 11/5/26 2:25 PM, Daniel Stone wrote:
> Hi Cristi,
> 
> On Thu, 5 Nov 2026 at 01:01, Cristian Ciocaltea
> <cristian.ciocaltea@collabora.com> wrote:
>> Changes in v6:
>> - Added new vop2 patch "Disable core clocks before dropping runtime PM
>>   reference" (Sashiko)
>>
>> Changes in v5:
>> - Added new patch "drm/rockchip: dw_hdmi_qp: Do not mask error code in
>>   atomic_check()" to fix a pre-existing issue reported by Sashiko
>>
>> Changes in v3:
>> - Updated patch 3 to skip any hardware programming in the callbacks
>>   gated by drm_atomic_helper_commit_planes() after powering down VOP2 on
>>   an atomic_enable() error (Sashiko)
>> - Ensured VBLANK events are sent immediately when atomic_enable() fails,
>>   hence preventing userspace processes waiting for the page flip
>>   completion to hang indefinitely (new patch 4, Sashiko)
>>
>> Changes in v2:
>> - Addressed several issues reported by Sashiko
>>   * Reset AXI before detaching the IOMMU domain, to close a theoretical
>>     window where stale or in-flight DMA transactions could fault or
>>     access memory untranslated after the domain is detached (patch 6)
>>   * Fixed resource leak on vop2_enable() error path (new patch 2)
>>   * Balance state on atomic_enable error paths (new patch 3)
>>   * Avoided division by zero when computing max_dclk (new path 4)
>>   * Fixed VOP2_MAX_DCLK_RATE overflow on 32-bit (new patch 5)
> 
> I think everything in here should now be solidly reviewed. 

Thanks a lot for checking this out!

> But if this> series keeps on collecting unrelated patches until Sashiko decides all
> of VOP2 is bug-free, we will never get this series merged. Could we
> please keep this series focused on the useful bits at the end, and not
> keep on adding speculative new Sashiko-pleasing as artificial
> dependencies?

Yeah, sorry for that.  I'll stop here with regard to addressing further Sashiko
findings, unless there is really something wrong introduced by this series
(which doesn't seem to be the case).

Regards,
Cristian