From: Joe Perches <joe@perches.com>
To: John Garry <john.garry@huawei.com>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH] scsi: libsas: Remove pcidev reference
Date: Mon, 12 Nov 2018 10:58:12 -0800 [thread overview]
Message-ID: <3470156e35390d1810a6a5e4a554a77493c0d44f.camel@perches.com> (raw)
In-Reply-To: <dd39734e-4113-f9fd-6890-a83e80093c7e@huawei.com>
On Mon, 2018-11-12 at 18:48 +0000, John Garry wrote:
> On 12/11/2018 18:30, Joe Perches wrote:
[]
> > diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_internal.h
[]
> > @@ -32,7 +32,10 @@
> > #include <scsi/libsas.h>
> > #include <scsi/sas_ata.h>
> >
> > -#define sas_printk(fmt, ...) printk(KERN_NOTICE "sas: " fmt, ## __VA_ARGS__)
> > +#ifdef pr_fmt
> > +#undef pr_fmt
> > +#endif
> > +#define pr_fmt(fmt) "sas: " fmt
>
> Some other subsystem may try to include this header, and gets its
> message prefix overwritten. Just a consequence for doing something bad,
> right?
Right.
And as this file is internal to drivers/scsi/libsas
that seems very unlikely to occur.
It also might useful to use the common debugging
mechanisms and convert SAS_DPRINTK to pr_debug
which would use the same #define pr_fmt.
next prev parent reply other threads:[~2018-11-12 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 17:28 John Garry
2018-11-12 17:32 ` Joe Perches
2018-11-12 17:49 ` John Garry
2018-11-12 17:55 ` John Garry
2018-11-12 18:30 ` Joe Perches
2018-11-12 18:48 ` John Garry
2018-11-12 18:58 ` Joe Perches [this message]
2018-11-12 19:31 ` John Garry
2018-11-12 19:52 ` Joe Perches
2018-11-13 13:38 ` John Garry
2018-11-13 15:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3470156e35390d1810a6a5e4a554a77493c0d44f.camel@perches.com \
--to=joe@perches.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®