mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: John Garry <john.garry@huawei.com>,
	jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxarm@huawei.com
Subject: Re: [PATCH] scsi: libsas: Remove pcidev reference
Date: Mon, 12 Nov 2018 11:52:42 -0800	[thread overview]
Message-ID: <dda6fafd2096845ef503921703652f511d4f0daa.camel@perches.com> (raw)
In-Reply-To: <39f56211-cf15-8ca5-a48f-3e4cc347cdb0@huawei.com>

On Mon, 2018-11-12 at 19:31 +0000, John Garry wrote:
> On 12/11/2018 18:58, Joe Perches wrote:
> > > > +#define pr_fmt(fmt) "sas: " fmt
> > > > 
> > > > Some other subsystem may try to include this header, and gets its
> > > > message prefix overwritten. Just a consequence for doing something bad,
> > > > right?
> > Right.
> > 
> > And as this file is internal to drivers/scsi/libsas
> > that seems very unlikely to occur.
> > 
> > It also might useful to use the common debugging
> > mechanisms and convert SAS_DPRINTK to pr_debug
> > which would use the same #define pr_fmt.
> > 
> 
> OK, I will try to put this all together as a marginally wider scope tidy-up.

Thanks.

Another thing that could be done is to change
the #define pr_fmt(fmt) to KBUILD_MODNAME as
that would prefix "libsas" instead of just "sas".

I think that would be better but I didn't do that
as it should be in a separate patch.



  reply	other threads:[~2018-11-12 19:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12 17:28 John Garry
2018-11-12 17:32 ` Joe Perches
2018-11-12 17:49   ` John Garry
2018-11-12 17:55     ` John Garry
2018-11-12 18:30       ` Joe Perches
2018-11-12 18:48         ` John Garry
2018-11-12 18:58           ` Joe Perches
2018-11-12 19:31             ` John Garry
2018-11-12 19:52               ` Joe Perches [this message]
2018-11-13 13:38                 ` John Garry
2018-11-13 15:26                   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dda6fafd2096845ef503921703652f511d4f0daa.camel@perches.com \
    --to=joe@perches.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®