From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
andersson@kernel.org, agross@kernel.org,
linus.walleij@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v5 3/4] pinctrl: qcom: sm4450: Convert to platform remove callback returning void
Date: Thu, 30 Nov 2023 11:36:48 +0100 [thread overview]
Message-ID: <34afe467-bf18-4328-8325-0f2cce4982d3@linaro.org> (raw)
In-Reply-To: <20231130024046.25938-4-quic_tengfan@quicinc.com>
On 30.11.2023 03:40, Tengfei Fan wrote:
> Use .remove_new() instead of .remove() for converting to platform remove
> callback returning void.
>
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
You misunderstood me, this series now introduces a driver with known
issues and patches them up right away in subsequent changes.
What you should do in such situations is squash the fixups into the
newly added driver (e.g. by running git rebase -i baseofyourtree and
changing 'pick' to 'f' (for 'fixup') on the last two patches).
Konrad
next prev parent reply other threads:[~2023-11-30 10:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 2:40 [PATCH v5 0/4] pinctl: qcom: sm4450: Add SM4450 pinctrl driver Tengfei Fan
2023-11-30 2:40 ` [PATCH v5 1/4] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl Tengfei Fan
2023-11-30 11:56 ` Krzysztof Kozlowski
2023-12-06 2:01 ` Tengfei Fan
2023-11-30 2:40 ` [PATCH v5 2/4] pinctrl: qcom: Add SM4450 pinctrl driver Tengfei Fan
2023-11-30 11:31 ` kernel test robot
2023-11-30 11:57 ` Krzysztof Kozlowski
2023-12-04 1:57 ` Tengfei Fan
2023-12-04 7:56 ` Krzysztof Kozlowski
2023-12-04 8:06 ` Tengfei Fan
2023-12-04 8:14 ` Krzysztof Kozlowski
2023-12-04 8:19 ` Tengfei Fan
2023-12-04 16:04 ` Jeff Johnson
2023-12-05 6:51 ` Tengfei Fan
2023-11-30 2:40 ` [PATCH v5 3/4] pinctrl: qcom: sm4450: Convert to platform remove callback returning void Tengfei Fan
2023-11-30 10:36 ` Konrad Dybcio [this message]
2023-12-04 2:00 ` Tengfei Fan
2023-11-30 2:40 ` [PATCH v5 4/4] pinctrl: qcom: sm4450: correct incorrect address offset Tengfei Fan
2023-12-01 21:36 ` Bjorn Andersson
2023-12-04 2:02 ` Tengfei Fan
2023-12-04 9:57 ` Linus Walleij
2023-12-05 0:59 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34afe467-bf18-4328-8325-0f2cce4982d3@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=kernel@quicinc.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tengfan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®