mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: <agross@kernel.org>, <konrad.dybcio@linaro.org>,
	<linus.walleij@linaro.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel@quicinc.com>
Subject: Re: [PATCH v5 4/4] pinctrl: qcom: sm4450: correct incorrect address offset
Date: Mon, 4 Dec 2023 10:02:47 +0800	[thread overview]
Message-ID: <64fd99b9-51f1-4288-9789-d4f71f7d9dd2@quicinc.com> (raw)
In-Reply-To: <dx62durg3wmqviqdpecdqprd5wwkg4i7n5tgcab55axzssdeel@ftt35c6td2sh>



在 12/2/2023 5:36 AM, Bjorn Andersson 写道:
> On Thu, Nov 30, 2023 at 10:40:46AM +0800, Tengfei Fan wrote:
>> The address offset of 0x100000 is already provided in SM4450 DTSI, so
>> subtract 0x100000 from the offset which used by ufs and sdc.
>>
> 
> As Konrad points out, please fix the broken patch, don't add a separate
> fix in the same series.
Sure, I will do this as comments.
> 
>> Suggested-by: Can Guo <quic_cang@quicinc.com>
> 
> We unfortunately don't have a way to give credit to those providing
> review feedback, so omit this when fixing patch #2.
Sure, I will omit this in next version patch series.
> 
> Regards,
> Bjorn
> 
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   drivers/pinctrl/qcom/pinctrl-sm4450.c | 16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sm4450.c b/drivers/pinctrl/qcom/pinctrl-sm4450.c
>> index 49e2e3a7a9cb..5496f955ed2a 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-sm4450.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-sm4450.c
>> @@ -936,14 +936,14 @@ static const struct msm_pingroup sm4450_groups[] = {
>>   	[133] = PINGROUP(133, _, phase_flag, _, _, _, _, _, _, _),
>>   	[134] = PINGROUP(134, tsense_pwm1_out, tsense_pwm2_out, _, _, _, _, _, _, _),
>>   	[135] = PINGROUP(135, _, phase_flag, _, _, _, _, _, _, _),
>> -	[136] = UFS_RESET(ufs_reset, 0x197000),
>> -	[137] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x18c004, 0, 0),
>> -	[138] = SDC_QDSD_PINGROUP(sdc1_clk, 0x18c000, 13, 6),
>> -	[139] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x18c000, 11, 3),
>> -	[140] = SDC_QDSD_PINGROUP(sdc1_data, 0x18c000, 9, 0),
>> -	[141] = SDC_QDSD_PINGROUP(sdc2_clk, 0x18f000, 14, 6),
>> -	[142] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x18f000, 11, 3),
>> -	[143] = SDC_QDSD_PINGROUP(sdc2_data, 0x18f000, 9, 0),
>> +	[136] = UFS_RESET(ufs_reset, 0x97000),
>> +	[137] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x8c004, 0, 0),
>> +	[138] = SDC_QDSD_PINGROUP(sdc1_clk, 0x8c000, 13, 6),
>> +	[139] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x8c000, 11, 3),
>> +	[140] = SDC_QDSD_PINGROUP(sdc1_data, 0x8c000, 9, 0),
>> +	[141] = SDC_QDSD_PINGROUP(sdc2_clk, 0x8f000, 14, 6),
>> +	[142] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x8f000, 11, 3),
>> +	[143] = SDC_QDSD_PINGROUP(sdc2_data, 0x8f000, 9, 0),
>>   };
>>   
>>   static const struct msm_gpio_wakeirq_map sm4450_pdc_map[] = {
>> -- 
>> 2.17.1
>>

-- 
Thx and BRs,
Tengfei Fan

  reply	other threads:[~2023-12-04  2:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30  2:40 [PATCH v5 0/4] pinctl: qcom: sm4450: Add SM4450 pinctrl driver Tengfei Fan
2023-11-30  2:40 ` [PATCH v5 1/4] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl Tengfei Fan
2023-11-30 11:56   ` Krzysztof Kozlowski
2023-12-06  2:01     ` Tengfei Fan
2023-11-30  2:40 ` [PATCH v5 2/4] pinctrl: qcom: Add SM4450 pinctrl driver Tengfei Fan
2023-11-30 11:31   ` kernel test robot
2023-11-30 11:57   ` Krzysztof Kozlowski
2023-12-04  1:57     ` Tengfei Fan
2023-12-04  7:56       ` Krzysztof Kozlowski
2023-12-04  8:06         ` Tengfei Fan
2023-12-04  8:14           ` Krzysztof Kozlowski
2023-12-04  8:19             ` Tengfei Fan
2023-12-04 16:04         ` Jeff Johnson
2023-12-05  6:51           ` Tengfei Fan
2023-11-30  2:40 ` [PATCH v5 3/4] pinctrl: qcom: sm4450: Convert to platform remove callback returning void Tengfei Fan
2023-11-30 10:36   ` Konrad Dybcio
2023-12-04  2:00     ` Tengfei Fan
2023-11-30  2:40 ` [PATCH v5 4/4] pinctrl: qcom: sm4450: correct incorrect address offset Tengfei Fan
2023-12-01 21:36   ` Bjorn Andersson
2023-12-04  2:02     ` Tengfei Fan [this message]
2023-12-04  9:57     ` Linus Walleij
2023-12-05  0:59       ` Tengfei Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64fd99b9-51f1-4288-9789-d4f71f7d9dd2@quicinc.com \
    --to=quic_tengfan@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=kernel@quicinc.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®