mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bean Huo <beanhuo@iokpp.de>
To: chanwoo@kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	 Kyungmin Park <kyungmin.park@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	"Martin K . Petersen" <mkp@kernel.org>,
	"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	Avri Altman <avri.altman@sandisk.com>,
	 Bart Van Assche <bvanassche@acm.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Stanley Jhu <stanleyjhu@google.com>,
	 Bean Huo <beanhuo@micron.com>
Subject: Re: [PATCH v2 1/4] PM / devfreq: Fall back to previous_freq when get_cur_freq() fails
Date: Mon, 16 Nov 2026 15:00:23 +0100	[thread overview]
Message-ID: <34fdf9f5a04e05d1713f57f63dcd2cd0b81ee959.camel@iokpp.de> (raw)
In-Reply-To: <a813b1ea-6971-4fde-b310-659a03963fba@gmail.com>

On Sun, 2026-11-15 at 09:25 +0900, Choi Chanwoo wrote:
> > -       else
> > +       if (!devfreq->profile->get_cur_freq ||
> > +           devfreq->profile->get_cur_freq(devfreq->dev.parent, &cur_freq))
> >                 cur_freq = devfreq->previous_freq;
> >   
> >         freqs.old = cur_freq;
> 
> I agree this patch.
> But, I don't recommend to execute to function on if statement.
> In order to improve the readability, could you please update it as following:
> 
>         unsigned long cur_freq = devfreq->previous_freq;
>         unsigned long freq;
>         ...
>         if (devfreq->profile->get_cur_freq) {
>                 err = devfreq->profile->get_cur_freq(devfreq->dev.parent,
> &freq);
>                 if (!err)
>                         cur_freq = freq;
>         }
> 
> --
> Best Regards,
> Chanwoo Choi
> Principal Engineer, Samsung Electronics

Chanwoo, 

thanks, will update these two patches only since UFS patches have been merged.

Kind regards, 
Bean 


  reply	other threads:[~2026-11-16 14:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 19:21 [PATCH v2 0/4] devfreq: check the get_cur_freq() return value and use it in ufshcd Bean Huo
2026-09-07 19:21 ` [PATCH v2 1/4] PM / devfreq: Fall back to previous_freq when get_cur_freq() fails Bean Huo
2026-09-14  6:24   ` Jie Zhan
2026-11-15  0:25   ` Choi Chanwoo
2026-11-16 14:00     ` Bean Huo [this message]
2026-09-07 19:21 ` [PATCH v2 2/4] PM / devfreq: Add more details to the get_cur_freq() comment Bean Huo
2026-09-14  6:25   ` Jie Zhan
2026-11-15  0:27   ` Choi Chanwoo
2026-09-07 19:21 ` [PATCH v2 3/4] scsi: ufs: core: Record the frequency the controller starts at Bean Huo
2026-09-07 19:21 ` [PATCH v2 4/4] scsi: ufs: core: Report the current clock frequency to devfreq Bean Huo
2026-09-08  1:34 ` [PATCH v2 0/4] devfreq: check the get_cur_freq() return value and use it in ufshcd Stanley Jhu
2026-09-10  2:28 ` Martin K. Petersen (Oracle)
2026-09-14 13:12 ` Bean Huo
2026-10-06 11:07   ` Bean Huo
2026-09-17  2:28 ` Martin K. Petersen (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34fdf9f5a04e05d1713f57f63dcd2cd0b81ee959.camel@iokpp.de \
    --to=beanhuo@iokpp.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@sandisk.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=chanwoo@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=stanleyjhu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®