[PATCH] remoteproc: qcom: q6v5-mss: Fix memory banks count for SDM660

[PATCH] remoteproc: qcom: q6v5-mss: Fix memory banks count for SDM660

[Alexey Minnekhanov]

As per downstream driver [1], SDM660's MSS version QDSP6v62 1.5 has 29
banks, not 28. Leaving something unpowered sounds bad and can potentially
cause unexpected crashes. This was missed during addition of the initial
support for SDM660 modem remoteproc, fix it.

[1] https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/
    LA.UM.7.2.c25-11600-sdm660.0/drivers/soc/qcom/pil-q6v5.c#L508

Fixes: 10b6fec2c8c99 ("remoteproc: qcom: q6v5-mss: Add support for SDM630/636/660")
Signed-off-by: Alexey Minnekhanov <alexeymin@minlexx.ru>
---
 drivers/remoteproc/qcom_q6v5_mss.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index 2f71ed2feff69..d159efbfe2fc1 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -849,7 +849,8 @@ static int q6v5proc_reset(struct q6v5 *qproc)
 			} else {
 				/* MSS_MSM8998, MSS_SDM660 */
 				mem_pwr_ctl = QDSP6V6SS_MEM_PWR_CTL;
-				i = 28;
+				/* SDM660 QDSP6v62 1.5 has one additional memory bank */
+				i = qproc->version == MSS_SDM660 ? 29 : 28;
 				reverse = 0;
 			}
 

---
base-commit: becb95e45ef0dda9ffb35156d909d3da7a2789c3
change-id: 20261011-sdm660-mss-banks-count-fe106a280252

Best regards,
--  
Alexey Minnekhanov <alexeymin@minlexx.ru>

Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix memory banks count for SDM660

[David Heidelberg]

On 11/10/2026 14:56, Alexey Minnekhanov wrote:
> As per downstream driver [1], SDM660's MSS version QDSP6v62 1.5 has 29
> banks, not 28. Leaving something unpowered sounds bad and can potentially
> cause unexpected crashes. This was missed during addition of the initial
> support for SDM660 modem remoteproc, fix it.
> 
> [1] https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/
>      LA.UM.7.2.c25-11600-sdm660.0/drivers/soc/qcom/pil-q6v5.c#L508
> 
> Fixes: 10b6fec2c8c99 ("remoteproc: qcom: q6v5-mss: Add support for SDM630/636/660")
> Signed-off-by: Alexey Minnekhanov <alexeymin@minlexx.ru>
> ---
>   drivers/remoteproc/qcom_q6v5_mss.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
Reviewed-by: David Heidelberg <david@ixit.cz>

Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix memory banks count for SDM660

[Konrad Dybcio]

On 10/11/26 2:56 PM, Alexey Minnekhanov wrote:
> As per downstream driver [1], SDM660's MSS version QDSP6v62 1.5 has 29
> banks, not 28. Leaving something unpowered sounds bad and can potentially
> cause unexpected crashes. This was missed during addition of the initial
> support for SDM660 modem remoteproc, fix it.
> 
> [1] https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/
>     LA.UM.7.2.c25-11600-sdm660.0/drivers/soc/qcom/pil-q6v5.c#L508

The linebreak here makes the link unclickable

> 
> Fixes: 10b6fec2c8c99 ("remoteproc: qcom: q6v5-mss: Add support for SDM630/636/660")
> Signed-off-by: Alexey Minnekhanov <alexeymin@minlexx.ru>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad