* [PATCH] spi: s3c64xx: fix all kernel-doc warnings
@ 2026-02-26 5:12 Randy Dunlap
2026-02-26 6:58 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2026-02-26 5:12 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Andi Shyti, Tudor Ambarus, linux-spi, linux-samsung-soc
Add kernel-doc for one struct member and use the correct function name
to eliminate kernel-doc warnings:
Warning: include/linux/platform_data/spi-s3c64xx.h:40 struct member
'polling' not described in 's3c64xx_spi_info'
Warning: include/linux/platform_data/spi-s3c64xx.h:51 expecting prototype
for s3c64xx_spi_set_platdata(). Prototype was for
s3c64xx_spi0_set_platdata() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Andi Shyti <andi.shyti@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: linux-spi@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
include/linux/platform_data/spi-s3c64xx.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20260225.orig/include/linux/platform_data/spi-s3c64xx.h
+++ linux-next-20260225/include/linux/platform_data/spi-s3c64xx.h
@@ -30,6 +30,7 @@ struct s3c64xx_spi_csinfo {
* @src_clk_nr: Clock source index for the CLK_CFG[SPI_CLKSEL] field.
* @num_cs: Number of CS this controller emulates.
* @no_cs: Used when CS line is not connected.
+ * @polling: Using polling mode when %true (no 'dmas' property in devicetree)
* @cfg_gpio: Configure pins for this SPI controller.
*/
struct s3c64xx_spi_info {
@@ -41,7 +42,7 @@ struct s3c64xx_spi_info {
};
/**
- * s3c64xx_spi_set_platdata - SPI Controller configure callback by the board
+ * s3c64xx_spi0_set_platdata - SPI Controller configure callback by the board
* initialization code.
* @src_clk_nr: Clock the SPI controller is to use to generate SPI clocks.
* @num_cs: Number of elements in the 'cs' array.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] spi: s3c64xx: fix all kernel-doc warnings
2026-02-26 5:12 [PATCH] spi: s3c64xx: fix all kernel-doc warnings Randy Dunlap
@ 2026-02-26 6:58 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-26 6:58 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Andi Shyti, Tudor Ambarus, linux-spi, linux-samsung-soc
On 26/02/2026 06:12, Randy Dunlap wrote:
> Add kernel-doc for one struct member and use the correct function name
> to eliminate kernel-doc warnings:
>
> Warning: include/linux/platform_data/spi-s3c64xx.h:40 struct member
> 'polling' not described in 's3c64xx_spi_info'
> Warning: include/linux/platform_data/spi-s3c64xx.h:51 expecting prototype
> for s3c64xx_spi_set_platdata(). Prototype was for
> s3c64xx_spi0_set_platdata() instead
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-26 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-26 5:12 [PATCH] spi: s3c64xx: fix all kernel-doc warnings Randy Dunlap
2026-02-26 6:58 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®