mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chung, ChiaHsuan (Tom)" <chiahsuan.chung@amd.com>
To: Wayne Lin <Wayne.Lin@amd.com>, amd-gfx@lists.freedesktop.org
Cc: "Cooper Morgan" <ext-github@cwooper.dev>,
	"Eren Özen" <erenozen@protonmail.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	oystersuki <oss@oysterdaisuki.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: Store the AMD VSDB version for DP sinks without Replay
Date: Thu, 19 Nov 2026 17:11:34 +0800	[thread overview]
Message-ID: <356085da-41e4-4f73-ae9d-806ff13df236@amd.com> (raw)
In-Reply-To: <20261119032758.3857304-1-Wayne.Lin@amd.com>


On 11/19/2026 11:27 AM, Wayne Lin wrote:
> Store amd_vsdb_version for every DP and eDP sink after get_amd_vsdb(),
> not only when Replay is advertised. Without this, a native DP sink
> above 255 Hz with AMD VSDB v3 and no Replay keeps version 0.
> amdgpu_dm_update_freesync_state_on_stream() then sends the v1
> infopacket and truncates the rate to eight bits. A later EDID without
> the VSDB still writes 0. Replay still sets replay_mode and the eDP
> adaptive-sync type.
>
> Cooper Morgan's patch already contained this hunk in
> amdgpu_dm_connector.c. The hunk was left out when the patch was
> applied. This follow-up puts that hunk back.
>
> Fixes: ae60ec4dcfc4 ("drm/amd/display: Use FreeSync v3 infopacket for sinks above 255 Hz")
> Reported-by: Eren Özen <erenozen@protonmail.com>
> Link: https://lore.kernel.org/amd-gfx/20261113010529.11514-3-ext-github@cwooper.dev/
> Cc: Cooper Morgan <ext-github@cwooper.dev>
> Cc: Eren Özen <erenozen@protonmail.com>
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>

Reviewed-by: Tom Chung <chiahsuan.chung@amd.com>


> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> index 1bc8547d5777..41fc641b1b60 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> @@ -3928,10 +3928,10 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector,
>   		}
>   
>   		get_amd_vsdb(amdgpu_dm_connector, &vsdb_info);
> +		amdgpu_dm_connector->vsdb_info.amd_vsdb_version = vsdb_info.amd_vsdb_version;
>   
>   		if (vsdb_info.replay_mode) {
>   			amdgpu_dm_connector->vsdb_info.replay_mode = vsdb_info.replay_mode;
> -			amdgpu_dm_connector->vsdb_info.amd_vsdb_version = vsdb_info.amd_vsdb_version;
>   			amdgpu_dm_connector->as_type = ADAPTIVE_SYNC_TYPE_EDP;
>   		}
>   

      parent reply	other threads:[~2026-11-19  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  3:27 Wayne Lin
2026-11-19  8:37 ` Eren Özen
2026-11-19  9:11 ` Chung, ChiaHsuan (Tom) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=356085da-41e4-4f73-ae9d-806ff13df236@amd.com \
    --to=chiahsuan.chung@amd.com \
    --cc=Wayne.Lin@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=erenozen@protonmail.com \
    --cc=ext-github@cwooper.dev \
    --cc=harry.wentland@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oss@oysterdaisuki.com \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®