mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Store the AMD VSDB version for DP sinks without Replay
@ 2026-11-19  3:27 Wayne Lin
  2026-11-19  8:37 ` Eren Özen
  2026-11-19  9:11 ` Chung, ChiaHsuan (Tom)
  0 siblings, 2 replies; 3+ messages in thread
From: Wayne Lin @ 2026-11-19  3:27 UTC (permalink / raw)
  To: amd-gfx
  Cc: Cooper Morgan, Eren Özen, Harry Wentland, Leo Li,
	Rodrigo Siqueira, Alex Deucher, Christian König,
	David Airlie, Simona Vetter, oystersuki, dri-devel, linux-kernel

Store amd_vsdb_version for every DP and eDP sink after get_amd_vsdb(),
not only when Replay is advertised. Without this, a native DP sink
above 255 Hz with AMD VSDB v3 and no Replay keeps version 0.
amdgpu_dm_update_freesync_state_on_stream() then sends the v1
infopacket and truncates the rate to eight bits. A later EDID without
the VSDB still writes 0. Replay still sets replay_mode and the eDP
adaptive-sync type.

Cooper Morgan's patch already contained this hunk in
amdgpu_dm_connector.c. The hunk was left out when the patch was
applied. This follow-up puts that hunk back.

Fixes: ae60ec4dcfc4 ("drm/amd/display: Use FreeSync v3 infopacket for sinks above 255 Hz")
Reported-by: Eren Özen <erenozen@protonmail.com>
Link: https://lore.kernel.org/amd-gfx/20261113010529.11514-3-ext-github@cwooper.dev/
Cc: Cooper Morgan <ext-github@cwooper.dev>
Cc: Eren Özen <erenozen@protonmail.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
index 1bc8547d5777..41fc641b1b60 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
@@ -3928,10 +3928,10 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector,
 		}
 
 		get_amd_vsdb(amdgpu_dm_connector, &vsdb_info);
+		amdgpu_dm_connector->vsdb_info.amd_vsdb_version = vsdb_info.amd_vsdb_version;
 
 		if (vsdb_info.replay_mode) {
 			amdgpu_dm_connector->vsdb_info.replay_mode = vsdb_info.replay_mode;
-			amdgpu_dm_connector->vsdb_info.amd_vsdb_version = vsdb_info.amd_vsdb_version;
 			amdgpu_dm_connector->as_type = ADAPTIVE_SYNC_TYPE_EDP;
 		}
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amd/display: Store the AMD VSDB version for DP sinks without Replay
  2026-11-19  3:27 [PATCH] drm/amd/display: Store the AMD VSDB version for DP sinks without Replay Wayne Lin
@ 2026-11-19  8:37 ` Eren Özen
  2026-11-19  9:11 ` Chung, ChiaHsuan (Tom)
  1 sibling, 0 replies; 3+ messages in thread
From: Eren Özen @ 2026-11-19  8:37 UTC (permalink / raw)
  To: Wayne Lin
  Cc: amd-gfx, Cooper Morgan, Harry Wentland, Leo Li, Rodrigo Siqueira,
	Alex Deucher, Christian König, David Airlie, Simona Vetter,
	oystersuki, dri-devel, linux-kernel

Hi Wayne,

Thanks for the quick fix. It's the same hunk as in Cooper's v1/v2.

I ran the amdgpu_dm KUnit suite on amd-staging-drm-next 8dd68a79583a
with this change plus the i2c_xfer test fix, so the suite runs to the
end. dm_test_fs_caps_dp_vsdb_version passes again, and all 1931 tests
pass. I haven't tested it on a DP monitor above 255 Hz.

Tested-by: Eren Özen <erenozen@protonmail.com>

Thanks,
Eren


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amd/display: Store the AMD VSDB version for DP sinks without Replay
  2026-11-19  3:27 [PATCH] drm/amd/display: Store the AMD VSDB version for DP sinks without Replay Wayne Lin
  2026-11-19  8:37 ` Eren Özen
@ 2026-11-19  9:11 ` Chung, ChiaHsuan (Tom)
  1 sibling, 0 replies; 3+ messages in thread
From: Chung, ChiaHsuan (Tom) @ 2026-11-19  9:11 UTC (permalink / raw)
  To: Wayne Lin, amd-gfx
  Cc: Cooper Morgan, Eren Özen, Harry Wentland, Leo Li,
	Rodrigo Siqueira, Alex Deucher, Christian König,
	David Airlie, Simona Vetter, oystersuki, dri-devel, linux-kernel


On 11/19/2026 11:27 AM, Wayne Lin wrote:
> Store amd_vsdb_version for every DP and eDP sink after get_amd_vsdb(),
> not only when Replay is advertised. Without this, a native DP sink
> above 255 Hz with AMD VSDB v3 and no Replay keeps version 0.
> amdgpu_dm_update_freesync_state_on_stream() then sends the v1
> infopacket and truncates the rate to eight bits. A later EDID without
> the VSDB still writes 0. Replay still sets replay_mode and the eDP
> adaptive-sync type.
>
> Cooper Morgan's patch already contained this hunk in
> amdgpu_dm_connector.c. The hunk was left out when the patch was
> applied. This follow-up puts that hunk back.
>
> Fixes: ae60ec4dcfc4 ("drm/amd/display: Use FreeSync v3 infopacket for sinks above 255 Hz")
> Reported-by: Eren Özen <erenozen@protonmail.com>
> Link: https://lore.kernel.org/amd-gfx/20261113010529.11514-3-ext-github@cwooper.dev/
> Cc: Cooper Morgan <ext-github@cwooper.dev>
> Cc: Eren Özen <erenozen@protonmail.com>
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>

Reviewed-by: Tom Chung <chiahsuan.chung@amd.com>


> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> index 1bc8547d5777..41fc641b1b60 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> @@ -3928,10 +3928,10 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector,
>   		}
>   
>   		get_amd_vsdb(amdgpu_dm_connector, &vsdb_info);
> +		amdgpu_dm_connector->vsdb_info.amd_vsdb_version = vsdb_info.amd_vsdb_version;
>   
>   		if (vsdb_info.replay_mode) {
>   			amdgpu_dm_connector->vsdb_info.replay_mode = vsdb_info.replay_mode;
> -			amdgpu_dm_connector->vsdb_info.amd_vsdb_version = vsdb_info.amd_vsdb_version;
>   			amdgpu_dm_connector->as_type = ADAPTIVE_SYNC_TYPE_EDP;
>   		}
>   

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-19  9:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19  3:27 [PATCH] drm/amd/display: Store the AMD VSDB version for DP sinks without Replay Wayne Lin
2026-11-19  8:37 ` Eren Özen
2026-11-19  9:11 ` Chung, ChiaHsuan (Tom)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®