Re: [PATCH v4 2/2] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943

[Guenter Roeck <linux@roeck-us.net>]

On 3/24/26 21:17, Dawei Liu wrote:
> Add I2C device IDs for Renesas RAA228942 and RAA228943.
> 
> At the Linux PMBus hwmon interface level currently supported by this
> driver, these devices are compatible with the existing 2-rail non-TC
> controllers, so devicetree will use fallback compatibles and no
> dedicated OF match entries are needed.
> 

The AI still has a couple of concerns:

https://sashiko.dev/#/patchset/20260325090208.857-1-dawei.liu.jy%40renesas.com

As it turns out, the concern about i2c_match_id() vs. i2c_get_match_data()
has already been addressed in the hwmon-next branch.

Given that, I'll apply the series and address Krzysztof's feedback to the
first patch. No need to resend.

Thanks,
Guenter

> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
> ---
>   Documentation/hwmon/isl68137.rst | 20 ++++++++++++++++++++
>   drivers/hwmon/pmbus/isl68137.c   |  2 ++
>   2 files changed, 22 insertions(+)
> 
> diff --git a/Documentation/hwmon/isl68137.rst b/Documentation/hwmon/isl68137.rst
> index e77f582c2..0ce20d091 100644
> --- a/Documentation/hwmon/isl68137.rst
> +++ b/Documentation/hwmon/isl68137.rst
> @@ -394,6 +394,26 @@ Supported chips:
>   
>         Provided by Renesas upon request and NDA
>   
> +  * Renesas RAA228942
> +
> +    Prefix: 'raa228942'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Provided by Renesas upon request and NDA
> +
> +  * Renesas RAA228943
> +
> +    Prefix: 'raa228943'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Provided by Renesas upon request and NDA
> +
>     * Renesas RAA229001
>   
>       Prefix: 'raa229001'
> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index 3346afdf3..03c9adc0e 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -432,6 +432,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
>   	{"raa228228", raa_dmpvr2_2rail_nontc},
>   	{"raa228244", raa_dmpvr2_2rail_nontc},
>   	{"raa228246", raa_dmpvr2_2rail_nontc},
> +	{"raa228942", raa_dmpvr2_2rail_nontc},
> +	{"raa228943", raa_dmpvr2_2rail_nontc},
>   	{"raa229001", raa_dmpvr2_2rail},
>   	{"raa229004", raa_dmpvr2_2rail},
>   	{"raa229141", raa_dmpvr2_2rail_pmbus},