* [PATCH] slimbus: qcom-ngd-ctrl: fix ngd register base address
@ 2026-07-09 17:00 Federico Amedeo Izzo via B4 Relay
2026-07-10 9:40 ` Luca Weiss
0 siblings, 1 reply; 2+ messages in thread
From: Federico Amedeo Izzo via B4 Relay @ 2026-07-09 17:00 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: linux-arm-msm, linux-sound, linux-kernel, phone-devel,
~postmarketos/upstreaming, Federico Amedeo Izzo
From: Federico Amedeo Izzo <federico@izzo.pro>
The slimbus controller register base was calculated using the
controller ID and the register size, producing wrong results for ID > 1.
The expression reduces to ngd->base = ctrl->base for controller with ID = 1;
but for ID > 1 the other factors produce a wrong base address.
This bug caused a crash while trying to bring-up the secondary
slimbus controller (ID = 3) on oneplus-enchilada with sdm845.
In practice, the correct base address for each slimbus controller can be
obtained from the device-tree, so there is no need for further
calculations.
This was validated by reading the version register from the WCN3990 slim
interface on oneplus-enchilada.
---
Signed-off-by: Federico Amedeo Izzo <federico@izzo.pro>
---
drivers/slimbus/qcom-ngd-ctrl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index 80877e951849..91932f8d021b 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -1547,8 +1547,7 @@ static int of_qcom_slim_ngd_register(struct device *parent,
kfree(ngd);
return ret;
}
- ngd->base = ctrl->base + ngd->id * data->offset +
- (ngd->id - 1) * data->size;
+ ngd->base = ctrl->base + data->offset;
return 0;
}
---
base-commit: b9810cd75b9fb56a3425d391cba3f608502bd474
change-id: 20260709-qcom-ngd-register-base-fix-a59713a184b8
Best regards,
--
Federico Amedeo Izzo <federico@izzo.pro>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] slimbus: qcom-ngd-ctrl: fix ngd register base address
2026-07-09 17:00 [PATCH] slimbus: qcom-ngd-ctrl: fix ngd register base address Federico Amedeo Izzo via B4 Relay
@ 2026-07-10 9:40 ` Luca Weiss
0 siblings, 0 replies; 2+ messages in thread
From: Luca Weiss @ 2026-07-10 9:40 UTC (permalink / raw)
To: federico
Cc: Srinivas Kandagatla, linux-arm-msm, linux-sound, linux-kernel,
phone-devel, ~postmarketos/upstreaming
Hi Federico,
On 2026-07-09 19:00, Federico Amedeo Izzo via B4 Relay wrote:
> From: Federico Amedeo Izzo <federico@izzo.pro>
>
> The slimbus controller register base was calculated using the
> controller ID and the register size, producing wrong results for ID >
> 1.
>
> The expression reduces to ngd->base = ctrl->base for controller with ID
> = 1;
> but for ID > 1 the other factors produce a wrong base address.
> This bug caused a crash while trying to bring-up the secondary
> slimbus controller (ID = 3) on oneplus-enchilada with sdm845.
>
> In practice, the correct base address for each slimbus controller can
> be
> obtained from the device-tree, so there is no need for further
> calculations.
>
> This was validated by reading the version register from the WCN3990
> slim
> interface on oneplus-enchilada.
>
> ---
Please remove the ---, otherwise your S-o-b will be dropped when
applying the patch.
Also Fixes: ?
> Signed-off-by: Federico Amedeo Izzo <federico@izzo.pro>
> ---
> drivers/slimbus/qcom-ngd-ctrl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/slimbus/qcom-ngd-ctrl.c
> b/drivers/slimbus/qcom-ngd-ctrl.c
> index 80877e951849..91932f8d021b 100644
> --- a/drivers/slimbus/qcom-ngd-ctrl.c
> +++ b/drivers/slimbus/qcom-ngd-ctrl.c
> @@ -1547,8 +1547,7 @@ static int of_qcom_slim_ngd_register(struct
> device *parent,
> kfree(ngd);
> return ret;
> }
> - ngd->base = ctrl->base + ngd->id * data->offset +
> - (ngd->id - 1) * data->size;
> + ngd->base = ctrl->base + data->offset;
>
> return 0;
> }
>
> ---
> base-commit: b9810cd75b9fb56a3425d391cba3f608502bd474
> change-id: 20260709-qcom-ngd-register-base-fix-a59713a184b8
>
> Best regards,
> --
> Federico Amedeo Izzo <federico@izzo.pro>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-10 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-09 17:00 [PATCH] slimbus: qcom-ngd-ctrl: fix ngd register base address Federico Amedeo Izzo via B4 Relay
2026-07-10 9:40 ` Luca Weiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®