Re: [PATCH] parisc: Enable LOCKDEP support

Re: [PATCH] parisc: Enable LOCKDEP support

[Guenter Roeck]

Helge,

On Tue, May 23, 2023 at 09:06:40AM +0200, Helge Deller wrote:
> Cc: <stable@vger.kernel.org> # v6.0+
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>  arch/parisc/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index 466a25525364..967bde65dd0e 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -130,6 +130,10 @@ config PM
>  config STACKTRACE_SUPPORT
>  	def_bool y
>  
> +config LOCKDEP_SUPPORT
> +	bool
> +	default y
> +
>  config ISA_DMA_API
>  	bool
>  

This patch results in a bunch of WARNING message with each parisc boot if
CONFIG_PROVE_LOCKING and CONFIG_DEBUG_LOCKDEP are enabled.

WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:5545 check_flags+0x24c/0x274
Backtrace:
 [<1026d44c>] lock_acquire+0xdc/0x388
 [<10e8c66c>] _raw_spin_lock_irqsave+0x64/0x98
 [<10e922dc>] down_trylock+0x20/0x58
 [<102768c8>] __down_trylock_console_sem+0x44/0x114
 [<1027b768>] vprintk_emit+0xa8/0x3dc
 [<1027bac4>] vprintk_default+0x28/0x38
 [<1027c574>] vprintk+0xa4/0xb4
 [<10e6c62c>] _printk+0x30/0x40
 [<10e37700>] report_bug+0x338/0x35c
 [<101c19fc>] handle_interruption+0x654/0x768
 [<101bb070>] intr_check_sig+0x0/0x38

WARNING: CPU: 0 PID: 0 at kernel/context_tracking.c:367 ct_irq_enter+0x94/0xb0
Backtrace:
 [<101f0c1c>] irq_enter+0x18/0x30
 [<101c2dec>] do_cpu_irq_mask+0x7c/0x388
 [<101bb064>] intr_return+0x0/0xc

Is that going to be fixed, or should I disable CONFIG_PROVE_LOCKING
for parisc in my testing ?

Thanks,
Guenter

Re: [PATCH] parisc: Enable LOCKDEP support

[Helge Deller]

On 5/30/23 16:19, Guenter Roeck wrote:
> Helge,
>
> On Tue, May 23, 2023 at 09:06:40AM +0200, Helge Deller wrote:
>> Cc: <stable@vger.kernel.org> # v6.0+
>> Signed-off-by: Helge Deller <deller@gmx.de>
>> ---
>>   arch/parisc/Kconfig | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
>> index 466a25525364..967bde65dd0e 100644
>> --- a/arch/parisc/Kconfig
>> +++ b/arch/parisc/Kconfig
>> @@ -130,6 +130,10 @@ config PM
>>   config STACKTRACE_SUPPORT
>>   	def_bool y
>>
>> +config LOCKDEP_SUPPORT
>> +	bool
>> +	default y
>> +
>>   config ISA_DMA_API
>>   	bool
>>
>
> This patch results in a bunch of WARNING message with each parisc boot if
> CONFIG_PROVE_LOCKING and CONFIG_DEBUG_LOCKDEP are enabled.
>
> WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:5545 check_flags+0x24c/0x274
> Backtrace:
>   [<1026d44c>] lock_acquire+0xdc/0x388
>   [<10e8c66c>] _raw_spin_lock_irqsave+0x64/0x98
>   [<10e922dc>] down_trylock+0x20/0x58
>   [<102768c8>] __down_trylock_console_sem+0x44/0x114
>   [<1027b768>] vprintk_emit+0xa8/0x3dc
>   [<1027bac4>] vprintk_default+0x28/0x38
>   [<1027c574>] vprintk+0xa4/0xb4
>   [<10e6c62c>] _printk+0x30/0x40
>   [<10e37700>] report_bug+0x338/0x35c
>   [<101c19fc>] handle_interruption+0x654/0x768
>   [<101bb070>] intr_check_sig+0x0/0x38
>
> WARNING: CPU: 0 PID: 0 at kernel/context_tracking.c:367 ct_irq_enter+0x94/0xb0
> Backtrace:
>   [<101f0c1c>] irq_enter+0x18/0x30
>   [<101c2dec>] do_cpu_irq_mask+0x7c/0x388
>   [<101bb064>] intr_return+0x0/0xc
>
> Is that going to be fixed, or should I disable CONFIG_PROVE_LOCKING
> for parisc in my testing ?

They should be looked at and fixed over time. Right now please disable
for now, as I personally won't have time to check as I'm leaving
for vacation. You may send me your .config in private mail though, in
case I find time.

Helge