From: Eric Salem <ericsalem@gmail.com>
To: Joe Perches <joe@perches.com>, greg@kroah.com
Cc: arve@android.com, riandrews@android.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] Staging: android: fixed permissions style issue
Date: Sun, 25 Sep 2016 22:33:34 -0500 [thread overview]
Message-ID: <35cf54aa-2ab4-b58d-194c-5c278f1f0a46@gmail.com> (raw)
In-Reply-To: <1474858836.2238.10.camel@perches.com>
Fixed a coding style issue. Changed symbolic permissions to octal.
Signed-off-by: Eric Salem <ericsalem@gmail.com>
---
drivers/staging/android/lowmemorykiller.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
index 80d7adf..ec3b665 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -204,10 +204,9 @@ device_initcall(lowmem_init);
* not really modular, but the easiest way to keep compat with existing
* bootargs behaviour is to continue using module_param here.
*/
-module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
-module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
- S_IRUGO | S_IWUSR);
+module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
+module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644);
module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
- S_IRUGO | S_IWUSR);
-module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
+ 0644);
+module_param_named(debug_level, lowmem_debug_level, uint, 0644);
--
2.7.4
On 09/25/2016 10:00 PM, Joe Perches wrote:
> On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote:
>> Fixed a coding style issue. Changed symbolic permissions to octal.
>
> If you do these, please shorten the lines where possible.
>
>> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
> []
>> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
>> * not really modular, but the easiest way to keep compat with existing
>> * bootargs behaviour is to continue using module_param here.
>> */
>> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
>> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
>> module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
>> - S_IRUGO | S_IWUSR);
>> + 0644);
>
> module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644);
>
> etc...
>
prev parent reply other threads:[~2016-09-26 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 2:47 [PATCH] " Eric Salem
2016-09-26 3:00 ` Joe Perches
2016-09-26 3:33 ` Eric Salem [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35cf54aa-2ab4-b58d-194c-5c278f1f0a46@gmail.com \
--to=ericsalem@gmail.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®