mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org, pmladek@suse.com,
	marco.crivellari@suse.com, gustavold@gmail.com,
	david.dai@linux.dev, kernel-team@meta.com, tj@kernel.org
Subject: Re: [PATCH 4/5] workqueue: build percpu pwqs through the attrs path
Date: Thu, 10 Sep 2026 07:29:45 -1000	[thread overview]
Message-ID: <35e5c7afa2d90310ceba68cb1c5064c8@kernel.org> (raw)
In-Reply-To: <aqKCaEe5mcYjv6vB@gmail.com>

Hello,

On Thu, Sep 10, 2026 at 03:13:15AM -0700, Breno Leitao wrote:
> Sure. Would a if() in put_pwq() cause harm? This is what I came up with.
> Any chance it would be acceptable?

A failed system workqueue allocation hits BUG_ON() in workqueue_init_early()
anyway. Please use BUG_ON(!pwq_release_worker) with a comment explaining why
the failure is unrecoverable.

Thanks.

-- 
tejun

  reply	other threads:[~2026-09-10 17:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 14:37 [PATCH 0/5] workqueue: unify percpu and unbound pwq allocation Breno Leitao
2026-08-19 14:37 ` [PATCH 1/5] workqueue: move the unbound-only attrs check to apply_workqueue_attrs() Breno Leitao
2026-08-19 14:37 ` [PATCH 2/5] workqueue: resolve the backing pool in alloc_pwq() Breno Leitao
2026-08-19 14:37 ` [PATCH 3/5] workqueue: make the default pwq optional Breno Leitao
2026-08-26  8:22   ` Marco Crivellari
2026-08-26 16:33     ` Breno Leitao
2026-08-19 14:37 ` [PATCH 4/5] workqueue: build percpu pwqs through the attrs path Breno Leitao
2026-08-31 22:23   ` Tejun Heo
2026-09-10 10:13     ` Breno Leitao
2026-09-10 17:29       ` Tejun Heo [this message]
2026-08-19 14:37 ` [PATCH 5/5] workqueue: rename the pwq slot helpers shared with percpu Breno Leitao
2026-08-31 22:11 ` [PATCH 0/5] workqueue: unify percpu and unbound pwq allocation Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35e5c7afa2d90310ceba68cb1c5064c8@kernel.org \
    --to=tj@kernel.org \
    --cc=david.dai@linux.dev \
    --cc=gustavold@gmail.com \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®