From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, Juri Lelli <juri.lelli@redhat.com>,
Cestmir Kalina <ckalina@redhat.com>,
Alex Gladkov <agladkov@redhat.com>, Phil Auld <pauld@redhat.com>,
Costa Shulyupin <cshulyup@redhat.com>
Subject: Re: [PATCH-wq v3 0/4] workqueue: Enable unbound cpumask update on ordered workqueues
Date: Mon, 5 Feb 2024 20:24:06 -0500 [thread overview]
Message-ID: <35ec9009-52eb-40aa-bf7a-db7a451d3652@redhat.com> (raw)
In-Reply-To: <ZcF3qmion7H6qyYY@slm.duckdns.org>
On 2/5/24 19:04, Tejun Heo wrote:
> On Mon, Feb 05, 2024 at 09:53:09AM -1000, Tejun Heo wrote:
>> On Mon, Feb 05, 2024 at 02:45:58PM -0500, Waiman Long wrote:
>>> v3:
>>> - [v2] https://lore.kernel.org/lkml/20240203154334.791910-1-longman@redhat.com/
>>> - Drop patch 1 as it has been merged into the for-6.9 branch.
>>> - Use rcu_access_pointer() to access wq->dfl_pwq.
>>> - Use RCU protection instead of acquiring wq->mutex in
>>> apply_wqattrs_cleanup().
>> Looks like we raced each other. I'll wait for v4.
> BTW, please don't bother to handle __WQ_ORDERED being cleared. We are very
> close to removing the implicit ORDERED promotion, so we should be able to
> apply the patch to remove the distinction between explicitly and implicitly
> ordered workqueues.
BTW, the workqueue.c file in your latest for-6.9 branch still has a
reference to __WQ_ORDERED_EXPLICIT in workqueue_apply_unbound_cpumask().
Will that break compilation?
Regards,
Longman
next prev parent reply other threads:[~2024-02-06 1:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 19:45 Waiman Long
2024-02-05 19:45 ` [PATCH-wq v3 1/4] " Waiman Long
2024-02-05 19:46 ` [PATCH-wq v3 2/4] workqueue: Thaw frozen pwq in workqueue_apply_unbound_cpumask() Waiman Long
2024-02-05 19:46 ` [PATCH-wq v3 3/4] kernel/workqueue: Let rescuers follow unbound wq cpumask changes Waiman Long
2024-02-05 19:46 ` [PATCH-wq v3 4/4] workqueue: Bind unbound workqueue rescuer to wq_unbound_cpumask Waiman Long
2024-02-05 19:53 ` [PATCH-wq v3 0/4] workqueue: Enable unbound cpumask update on ordered workqueues Tejun Heo
2024-02-06 0:04 ` Tejun Heo
2024-02-06 1:07 ` Waiman Long
2024-02-06 1:24 ` Waiman Long [this message]
2024-02-06 1:40 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35ec9009-52eb-40aa-bf7a-db7a451d3652@redhat.com \
--to=longman@redhat.com \
--cc=agladkov@redhat.com \
--cc=ckalina@redhat.com \
--cc=cshulyup@redhat.com \
--cc=jiangshanlai@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pauld@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®