mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rashika Kheria <rashika.kheria@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
	Jiri Kosina <jkosina@suse.cz>,
	Randy Dunlap <rdunlap@infradead.org>,
	Masanari Iida <standby24x7@gmail.com>,
	Rashika Kheria <rashika.kheria@gmail.com>,
	linux-scsi@vger.kernel.org, josh@joshtriplett.org
Subject: [PATCH 31/55] scsi: Mark functions as static in mvsas/mv_sas.c
Date: Sat, 29 Mar 2014 23:49:26 +0530	[thread overview]
Message-ID: <36003591ecb5adf76db0306aa63b2f6b2d208e43.1396114898.git.rashika.kheria@gmail.com> (raw)
In-Reply-To: <5fd6fa49a592043459f75ed83a72f8c1ed9ddc13.1396114897.git.rashika.kheria@gmail.com>

Mark functions as static in mvsas/mv_sas.c because they are not used
outside this file.

This eliminates the following warnings in mvsas/mv_sas.c:
drivers/scsi/mvsas/mv_sas.c:77:18: warning: no previous prototype for ‘mvs_find_dev_mvi’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_sas.c:105:5: warning: no previous prototype for ‘mvs_find_dev_phyno’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_sas.c:1260:20: warning: no previous prototype for ‘mvs_alloc_dev’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_sas.c:1277:6: warning: no previous prototype for ‘mvs_free_dev’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_sas.c:1287:5: warning: no previous prototype for ‘mvs_dev_found_notify’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_sas.c:1343:6: warning: no previous prototype for ‘mvs_dev_gone_notify’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_sas.c:1709:6: warning: no previous prototype for ‘mvs_set_sense’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_sas.c:1748:6: warning: no previous prototype for ‘mvs_fill_ssp_resp_iu’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/scsi/mvsas/mv_sas.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index 6c1f223..80c2b1d 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -74,7 +74,7 @@ void mvs_tag_init(struct mvs_info *mvi)
 		mvs_tag_clear(mvi, i);
 }
 
-struct mvs_info *mvs_find_dev_mvi(struct domain_device *dev)
+static struct mvs_info *mvs_find_dev_mvi(struct domain_device *dev)
 {
 	unsigned long i = 0, j = 0, hi = 0;
 	struct sas_ha_struct *sha = dev->port->ha;
@@ -102,7 +102,7 @@ struct mvs_info *mvs_find_dev_mvi(struct domain_device *dev)
 
 }
 
-int mvs_find_dev_phyno(struct domain_device *dev, int *phyno)
+static int mvs_find_dev_phyno(struct domain_device *dev, int *phyno)
 {
 	unsigned long i = 0, j = 0, n = 0, num = 0;
 	struct mvs_device *mvi_dev = (struct mvs_device *)dev->lldd_dev;
@@ -1257,7 +1257,7 @@ void mvs_port_deformed(struct asd_sas_phy *sas_phy)
 	mvs_port_notify_deformed(sas_phy, 1);
 }
 
-struct mvs_device *mvs_alloc_dev(struct mvs_info *mvi)
+static struct mvs_device *mvs_alloc_dev(struct mvs_info *mvi)
 {
 	u32 dev;
 	for (dev = 0; dev < MVS_MAX_DEVICES; dev++) {
@@ -1274,7 +1274,7 @@ struct mvs_device *mvs_alloc_dev(struct mvs_info *mvi)
 	return NULL;
 }
 
-void mvs_free_dev(struct mvs_device *mvi_dev)
+static void mvs_free_dev(struct mvs_device *mvi_dev)
 {
 	u32 id = mvi_dev->device_id;
 	memset(mvi_dev, 0, sizeof(*mvi_dev));
@@ -1284,7 +1284,7 @@ void mvs_free_dev(struct mvs_device *mvi_dev)
 	mvi_dev->taskfileset = MVS_ID_NOT_MAPPED;
 }
 
-int mvs_dev_found_notify(struct domain_device *dev, int lock)
+static int mvs_dev_found_notify(struct domain_device *dev, int lock)
 {
 	unsigned long flags = 0;
 	int res = 0;
@@ -1340,7 +1340,7 @@ int mvs_dev_found(struct domain_device *dev)
 	return mvs_dev_found_notify(dev, 1);
 }
 
-void mvs_dev_gone_notify(struct domain_device *dev)
+static void mvs_dev_gone_notify(struct domain_device *dev)
 {
 	unsigned long flags = 0;
 	struct mvs_device *mvi_dev = dev->lldd_dev;
@@ -1706,7 +1706,7 @@ static int mvs_sata_done(struct mvs_info *mvi, struct sas_task *task,
 	return stat;
 }
 
-void mvs_set_sense(u8 *buffer, int len, int d_sense,
+static void mvs_set_sense(u8 *buffer, int len, int d_sense,
 		int key, int asc, int ascq)
 {
 	memset(buffer, 0, len);
@@ -1745,8 +1745,8 @@ void mvs_set_sense(u8 *buffer, int len, int d_sense,
 	return;
 }
 
-void mvs_fill_ssp_resp_iu(struct ssp_response_iu *iu,
-				u8 key, u8 asc, u8 asc_q)
+static void mvs_fill_ssp_resp_iu(struct ssp_response_iu *iu,
+				 u8 key, u8 asc, u8 asc_q)
 {
 	iu->datapres = 2;
 	iu->response_data_len = 0;
-- 
1.7.9.5


  parent reply	other threads:[~2014-03-29 18:19 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-29 17:42 [PATCH 01/55] scsi: Mark function as static in aacraid/src.c Rashika Kheria
2014-03-29 17:43 ` [PATCH 02/55] scsi: Mark function as static in be2iscsi/be_cmds.c Rashika Kheria
2014-04-03  5:02   ` Jayamohan Kallickal
2014-03-29 17:44 ` [PATCH 03/55] drivers: scsi: Mark function as static in bfa/bfad.c Rashika Kheria
2014-03-29 17:46 ` [PATCH 04/55] scsi: Mark function as static in bfa/bfad_attr.c Rashika Kheria
2014-03-29 17:47 ` [PATCH 05/55] scsi: Mark function as static in bfa/bfa_ioc.c Rashika Kheria
2014-03-29 17:48 ` [PATCH 06/55] scsi: Mark function as static in bfa/bfa_ioc_ct.c Rashika Kheria
2014-03-29 17:49 ` [PATCH 07/55] scsi: Mark function as static in bfa/bfa_fcs_lport.c Rashika Kheria
2014-03-29 17:50 ` [PATCH 08/55] scsi: Mark function as static in bfa/bfa_port.c Rashika Kheria
2014-03-29 17:51 ` [PATCH 09/55] scsi: Mark function as static in bfa/bfa_fcpim.c Rashika Kheria
2014-03-29 17:54 ` [PATCH 10/55] scsi: Mark function as static in bfa/bfa_core.c Rashika Kheria
2014-03-29 17:55 ` [PATCH 11/55] scsi: Mark function as static in bfa/bfa_svc.c Rashika Kheria
2014-03-29 17:56 ` [PATCH 12/55] scsi: Mark function as static in bnx2fc/bnx2fc_els.c Rashika Kheria
2014-03-29 17:57 ` [PATCH 13/55] scsi: Mark function as static in bnx2fc/bnx2fc_fcoe.c Rashika Kheria
2014-03-29 17:58 ` [PATCH 14/55] scsi: Mark function as static in bnx2fc/bnx2fc_hwi.c Rashika Kheria
2014-03-29 17:59 ` [PATCH 15/55] scsi: Mark function as static in bnx2fc/bnx2fc_io.c Rashika Kheria
2014-03-29 18:00 ` [PATCH 16/55] scsi: Mark function as static in cxgbi/libcxgbi.c Rashika Kheria
2014-03-29 18:02 ` [PATCH 17/55] scsi: Mark function as static in cxgbi/cxgb3i/cxgb3i.c Rashika Kheria
2014-03-29 18:03 ` [PATCH 18/55] scsi: Mark function as static in cxgbi/cxgb4i/cxgb4i.c Rashika Kheria
2014-03-29 18:04 ` [PATCH 19/55] scsi: Mark function as static in isci/phy.c Rashika Kheria
2014-03-31  8:54   ` Dorau, Lukasz
2014-03-31  9:36     ` Josh Triplett
     [not found]     ` <af1d52ad252849d6a8c5d5b09fa93d17@fmsmsx103.amr.corp.intel.com>
2014-03-31  9:47       ` Dorau, Lukasz
2014-03-29 18:05 ` [PATCH 20/55] scsi: Mark function as static in isci/remote_device.c Rashika Kheria
2014-03-31  8:55   ` Dorau, Lukasz
2014-03-29 18:06 ` [PATCH 21/55] scsi: Mark function as static in isci/port.c Rashika Kheria
2014-03-31  8:56   ` Dorau, Lukasz
2014-03-29 18:07 ` [PATCH 22/55] scsi: Mark functions as static in lpfc/lpfc_sli.c Rashika Kheria
2014-03-29 18:08 ` [PATCH 23/55] scsi: Mark functions as static in lpfc/lpfc_hbadisc.c Rashika Kheria
2014-03-29 18:09 ` [PATCH 24/55] scsi: Mark functions as static in lpfc/lpfc_init.c Rashika Kheria
2014-03-29 18:11 ` [PATCH 25/55] scsi: Mark functions as static in lpfc/lpfc_scsi.c Rashika Kheria
2014-03-29 18:12 ` [PATCH 26/55] scsi: Mark function as static in lpfc/lpfc_bsg.c Rashika Kheria
2014-03-29 18:13 ` [PATCH 27/55] scsi: Mark functions as static in megaraid/megaraid_sas_base.c Rashika Kheria
2014-03-29 18:15 ` [PATCH 28/55] scsi: Move prototype declaration to appropriate header file megaraid/megaraid_sas.h from megaraid/megaraid_sas_fusion.c Rashika Kheria
2014-03-29 18:16 ` [PATCH 29/55] scsi: Mark functions as static in megaraid/megaraid_sas_fusion.c Rashika Kheria
2014-04-11  6:04   ` Saxena, Sumit
2014-03-29 18:18 ` [PATCH 30/55] scsi: Mark functions as static in megaraid/megaraid_sas_fp.c Rashika Kheria
2014-04-11  6:05   ` Saxena, Sumit
2014-03-29 18:19 ` Rashika Kheria [this message]
2014-03-29 18:20 ` [PATCH 32/55] scsi: Mark functions as static in mvsas/mv_64xx.c Rashika Kheria
2014-03-29 18:22 ` [PATCH 33/55] scsi: Mark functions as static in mvsas/mv_94xx.c Rashika Kheria
2014-03-29 18:23 ` [PATCH 34/55] scsi: Mark function as static in pm8001/pm8001_init.c Rashika Kheria
2014-03-29 18:24 ` [PATCH 35/55] scsi: Mark function as static in pm8001/pm8001_sas.c Rashika Kheria
2014-03-29 18:25 ` [PATCH 36/55] scsi: Mark function as static in pm8001/pm8001_hwi.c Rashika Kheria
2014-03-29 18:26 ` [PATCH 37/55] scsi: Mark function as static in pm8001/pm80xx_hwi.c Rashika Kheria
2014-03-29 18:27 ` [PATCH 38/55] scsi: Mark function as static in qla2xxx/qla_bsg.c Rashika Kheria
2014-03-29 18:28 ` [PATCH 39/55] scsi: Mark functions as static in qla2xxx/qla_iocb.c Rashika Kheria
2014-03-29 18:29 ` [PATCH 40/55] scsi: Mark function as static in qla2xxx/qla_nx.c Rashika Kheria
2014-03-29 18:31 ` [PATCH 41/55] scsi: Mark functions as static in qla2xxx/qla_nx2.c Rashika Kheria
2014-03-29 18:32 ` [PATCH 42/55] scsi: Mark function as static in scsi_transport_fc.c Rashika Kheria
2014-03-29 18:35 ` [PATCH 43/55] scsi: Mark function as static in scsi_transport_iscsi.c Rashika Kheria
2014-03-29 18:37 ` [PATCH 44/55] scsi: Mark function as static in scsi/libiscsi.c Rashika Kheria
2014-03-29 18:39 ` [PATCH 45/55] scsi: Mark funtion as static in hpsa.c Rashika Kheria
2014-03-29 18:40 ` [PATCH 46/55] scsi: Mark functions as static in gdth.c Rashika Kheria
2014-03-29 18:43 ` [PATCH 47/55] scsi: Mark functions as static in scsi/pmcraid.c Rashika Kheria
2014-03-29 18:44 ` [PATCH 48/55] scsi: Mark function as static in scsi_debug.c Rashika Kheria
2014-03-29 18:45 ` [PATCH 49/55] scsi: Move prototype declaration to header file scsi_priv.h from scsi_scan.c Rashika Kheria
2014-03-29 18:46 ` [PATCH 50/55] scsi: Mark function and macro definition as static in be2iscsi/be_main.c Rashika Kheria
2014-03-29 18:47 ` [PATCH 51/55] scsi: Move prototype declaration to header file megaraid/megaraid_sas_fusion.h from megaraid/megaraid_sas_base.c Rashika Kheria
2014-04-11  6:06   ` Saxena, Sumit
2014-03-29 18:48 ` [PATCH 52/55] scsi: Move prototype declaration to header file megaraid/megaraid_sas.h from megaraid/megaraid_sas_fusion.c Rashika Kheria
2014-04-11  6:10   ` Saxena, Sumit
2014-03-29 18:49 ` [PATCH 53/55] scsi: Mark functions as static in ufs/ufshcd.c Rashika Kheria
2014-03-29 18:50 ` [PATCH 54/55] scsi: Add prototype declaration to header file ufs/ufshcd.h Rashika Kheria
2014-03-29 18:51 ` [PATCH 55/55] scsi: Mark functions as static in bfa/bfad_bsg.c Rashika Kheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36003591ecb5adf76db0306aa63b2f6b2d208e43.1396114898.git.rashika.kheria@gmail.com \
    --to=rashika.kheria@gmail.com \
    --cc=JBottomley@parallels.com \
    --cc=jkosina@suse.cz \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=standby24x7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®