mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rashika Kheria <rashika.kheria@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Neela Syam Kolli <megaraidlinux@lsi.com>,
	"James E.J. Bottomley" <JBottomley@parallels.com>,
	linux-scsi@vger.kernel.org, josh@joshtriplett.org
Subject: [PATCH 29/55] scsi: Mark functions as static in megaraid/megaraid_sas_fusion.c
Date: Sat, 29 Mar 2014 23:46:50 +0530	[thread overview]
Message-ID: <a0017455228e59c42db9004e315b69e763e25aa3.1396114898.git.rashika.kheria@gmail.com> (raw)
In-Reply-To: <5fd6fa49a592043459f75ed83a72f8c1ed9ddc13.1396114897.git.rashika.kheria@gmail.com>

Mark functions as static in megaraid/megaraid_sas_fusion.c because they
are not used outside this file.

This eliminates the warnings of following type in
megaraid/megaraid_sas_fusion.c:
drivers/scsi/megaraid/megaraid_sas_fusion.c:91:1: warning: no previous prototype for ‘megasas_enable_intr_fusion’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c |   39 ++++++++++++++-------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 2806d6d..ce6219c 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -74,7 +74,7 @@ extern int resetwaittime;
  * megasas_enable_intr_fusion -	Enables interrupts
  * @regs:			MFI register set
  */
-void
+static void
 megasas_enable_intr_fusion(struct megasas_instance *instance)
 {
 	struct megasas_register_set __iomem *regs;
@@ -94,7 +94,7 @@ megasas_enable_intr_fusion(struct megasas_instance *instance)
  * megasas_disable_intr_fusion - Disables interrupt
  * @regs:			 MFI register set
  */
-void
+static void
 megasas_disable_intr_fusion(struct megasas_instance *instance)
 {
 	u32 mask = 0xFFFFFFFF;
@@ -134,8 +134,8 @@ megasas_clear_intr_fusion(struct megasas_register_set __iomem *regs)
  *
  * Returns a free command from the pool
  */
-struct megasas_cmd_fusion *megasas_get_cmd_fusion(struct megasas_instance
-						  *instance)
+static struct megasas_cmd_fusion *megasas_get_cmd_fusion(
+				  struct megasas_instance *instance)
 {
 	unsigned long flags;
 	struct fusion_context *fusion =
@@ -363,7 +363,7 @@ static int megasas_create_frame_pool_fusion(struct megasas_instance *instance)
  * and is used as SMID of the cmd.
  * SMID value range is from 1 to max_fw_cmds.
  */
-int
+static int
 megasas_alloc_cmds_fusion(struct megasas_instance *instance)
 {
 	int i, j, count;
@@ -919,7 +919,7 @@ megasas_display_intel_branding(struct megasas_instance *instance)
  *
  * This is the main function for initializing firmware.
  */
-u32
+static u32
 megasas_init_adapter_fusion(struct megasas_instance *instance)
 {
 	struct megasas_register_set __iomem *reg_set;
@@ -1037,7 +1037,7 @@ fail_alloc_mfi_cmds:
  * @frame_count :		Number of frames for the command
  * @regs :			MFI register set
  */
-void
+static void
 megasas_fire_cmd_fusion(struct megasas_instance *instance,
 			dma_addr_t req_desc_lo,
 			u32 req_desc_hi,
@@ -1059,7 +1059,7 @@ megasas_fire_cmd_fusion(struct megasas_instance *instance,
  * @ext_status :	ext status of cmd returned by FW
  */
 
-void
+static void
 map_cmd_status(struct megasas_cmd_fusion *cmd, u8 status, u8 ext_status)
 {
 
@@ -1199,7 +1199,7 @@ megasas_make_sgl_fusion(struct megasas_instance *instance,
  *
  * Used to set the PD LBA in CDB for FP IOs
  */
-void
+static void
 megasas_set_pd_lba(struct MPI2_RAID_SCSI_IO_REQUEST *io_request, u8 cdb_len,
 		   struct IO_REQUEST_INFO *io_info, struct scsi_cmnd *scp,
 		   struct MR_FW_RAID_MAP_ALL *local_map_ptr, u32 ref_tag)
@@ -1376,7 +1376,7 @@ megasas_set_pd_lba(struct MPI2_RAID_SCSI_IO_REQUEST *io_request, u8 cdb_len,
  * Prepares the io_request and chain elements (sg_frame) for IO
  * The IO can be for PD (Fast Path) or LD
  */
-void
+static void
 megasas_build_ldio_fusion(struct megasas_instance *instance,
 			  struct scsi_cmnd *scp,
 			  struct megasas_cmd_fusion *cmd)
@@ -1678,7 +1678,7 @@ NonFastPath:
  * Invokes helper functions to prepare request frames
  * and sets flags appropriate for IO/Non-IO cmd
  */
-int
+static int
 megasas_build_io_fusion(struct megasas_instance *instance,
 			struct scsi_cmnd *scp,
 			struct megasas_cmd_fusion *cmd)
@@ -1749,7 +1749,7 @@ megasas_build_io_fusion(struct megasas_instance *instance,
 	return 0;
 }
 
-union MEGASAS_REQUEST_DESCRIPTOR_UNION *
+static union MEGASAS_REQUEST_DESCRIPTOR_UNION *
 megasas_get_request_descriptor(struct megasas_instance *instance, u16 index)
 {
 	u8 *p;
@@ -1829,7 +1829,7 @@ megasas_build_and_issue_cmd_fusion(struct megasas_instance *instance,
  * @instance:			Adapter soft state
  * Completes all commands that is in reply descriptor queue
  */
-int
+static int
 complete_cmd_fusion(struct megasas_instance *instance, u32 MSIxIndex)
 {
 	union MPI2_REPLY_DESCRIPTORS_UNION *desc;
@@ -1974,7 +1974,7 @@ complete_cmd_fusion(struct megasas_instance *instance, u32 MSIxIndex)
  *
  * Tasklet to complete cmds
  */
-void
+static void
 megasas_complete_cmd_dpc_fusion(unsigned long instance_addr)
 {
 	struct megasas_instance *instance =
@@ -1999,7 +1999,7 @@ megasas_complete_cmd_dpc_fusion(unsigned long instance_addr)
 /**
  * megasas_isr_fusion - isr entry point
  */
-irqreturn_t megasas_isr_fusion(int irq, void *devp)
+static irqreturn_t megasas_isr_fusion(int irq, void *devp)
 {
 	struct megasas_irq_context *irq_context = devp;
 	struct megasas_instance *instance = irq_context->instance;
@@ -2038,7 +2038,7 @@ irqreturn_t megasas_isr_fusion(int irq, void *devp)
  * mfi_cmd:			megasas_cmd pointer
  *
  */
-u8
+static u8
 build_mpt_mfi_pass_thru(struct megasas_instance *instance,
 			struct megasas_cmd *mfi_cmd)
 {
@@ -2101,7 +2101,7 @@ build_mpt_mfi_pass_thru(struct megasas_instance *instance,
  * @cmd:			mfi cmd to build
  *
  */
-union MEGASAS_REQUEST_DESCRIPTOR_UNION *
+static union MEGASAS_REQUEST_DESCRIPTOR_UNION *
 build_mpt_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd)
 {
 	union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc;
@@ -2134,7 +2134,7 @@ build_mpt_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd)
  * @cmd:			mfi cmd pointer
  *
  */
-void
+static void
 megasas_issue_dcmd_fusion(struct megasas_instance *instance,
 			  struct megasas_cmd *cmd)
 {
@@ -2197,7 +2197,8 @@ megasas_check_reset_fusion(struct megasas_instance *instance,
 }
 
 /* This function waits for outstanding commands on fusion to complete */
-int megasas_wait_for_outstanding_fusion(struct megasas_instance *instance)
+static int megasas_wait_for_outstanding_fusion(struct megasas_instance
+					       *instance)
 {
 	int i, outstanding, retval = 0;
 	u32 fw_state;
-- 
1.7.9.5


  parent reply	other threads:[~2014-03-29 18:16 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-29 17:42 [PATCH 01/55] scsi: Mark function as static in aacraid/src.c Rashika Kheria
2014-03-29 17:43 ` [PATCH 02/55] scsi: Mark function as static in be2iscsi/be_cmds.c Rashika Kheria
2014-04-03  5:02   ` Jayamohan Kallickal
2014-03-29 17:44 ` [PATCH 03/55] drivers: scsi: Mark function as static in bfa/bfad.c Rashika Kheria
2014-03-29 17:46 ` [PATCH 04/55] scsi: Mark function as static in bfa/bfad_attr.c Rashika Kheria
2014-03-29 17:47 ` [PATCH 05/55] scsi: Mark function as static in bfa/bfa_ioc.c Rashika Kheria
2014-03-29 17:48 ` [PATCH 06/55] scsi: Mark function as static in bfa/bfa_ioc_ct.c Rashika Kheria
2014-03-29 17:49 ` [PATCH 07/55] scsi: Mark function as static in bfa/bfa_fcs_lport.c Rashika Kheria
2014-03-29 17:50 ` [PATCH 08/55] scsi: Mark function as static in bfa/bfa_port.c Rashika Kheria
2014-03-29 17:51 ` [PATCH 09/55] scsi: Mark function as static in bfa/bfa_fcpim.c Rashika Kheria
2014-03-29 17:54 ` [PATCH 10/55] scsi: Mark function as static in bfa/bfa_core.c Rashika Kheria
2014-03-29 17:55 ` [PATCH 11/55] scsi: Mark function as static in bfa/bfa_svc.c Rashika Kheria
2014-03-29 17:56 ` [PATCH 12/55] scsi: Mark function as static in bnx2fc/bnx2fc_els.c Rashika Kheria
2014-03-29 17:57 ` [PATCH 13/55] scsi: Mark function as static in bnx2fc/bnx2fc_fcoe.c Rashika Kheria
2014-03-29 17:58 ` [PATCH 14/55] scsi: Mark function as static in bnx2fc/bnx2fc_hwi.c Rashika Kheria
2014-03-29 17:59 ` [PATCH 15/55] scsi: Mark function as static in bnx2fc/bnx2fc_io.c Rashika Kheria
2014-03-29 18:00 ` [PATCH 16/55] scsi: Mark function as static in cxgbi/libcxgbi.c Rashika Kheria
2014-03-29 18:02 ` [PATCH 17/55] scsi: Mark function as static in cxgbi/cxgb3i/cxgb3i.c Rashika Kheria
2014-03-29 18:03 ` [PATCH 18/55] scsi: Mark function as static in cxgbi/cxgb4i/cxgb4i.c Rashika Kheria
2014-03-29 18:04 ` [PATCH 19/55] scsi: Mark function as static in isci/phy.c Rashika Kheria
2014-03-31  8:54   ` Dorau, Lukasz
2014-03-31  9:36     ` Josh Triplett
     [not found]     ` <af1d52ad252849d6a8c5d5b09fa93d17@fmsmsx103.amr.corp.intel.com>
2014-03-31  9:47       ` Dorau, Lukasz
2014-03-29 18:05 ` [PATCH 20/55] scsi: Mark function as static in isci/remote_device.c Rashika Kheria
2014-03-31  8:55   ` Dorau, Lukasz
2014-03-29 18:06 ` [PATCH 21/55] scsi: Mark function as static in isci/port.c Rashika Kheria
2014-03-31  8:56   ` Dorau, Lukasz
2014-03-29 18:07 ` [PATCH 22/55] scsi: Mark functions as static in lpfc/lpfc_sli.c Rashika Kheria
2014-03-29 18:08 ` [PATCH 23/55] scsi: Mark functions as static in lpfc/lpfc_hbadisc.c Rashika Kheria
2014-03-29 18:09 ` [PATCH 24/55] scsi: Mark functions as static in lpfc/lpfc_init.c Rashika Kheria
2014-03-29 18:11 ` [PATCH 25/55] scsi: Mark functions as static in lpfc/lpfc_scsi.c Rashika Kheria
2014-03-29 18:12 ` [PATCH 26/55] scsi: Mark function as static in lpfc/lpfc_bsg.c Rashika Kheria
2014-03-29 18:13 ` [PATCH 27/55] scsi: Mark functions as static in megaraid/megaraid_sas_base.c Rashika Kheria
2014-03-29 18:15 ` [PATCH 28/55] scsi: Move prototype declaration to appropriate header file megaraid/megaraid_sas.h from megaraid/megaraid_sas_fusion.c Rashika Kheria
2014-03-29 18:16 ` Rashika Kheria [this message]
2014-04-11  6:04   ` [PATCH 29/55] scsi: Mark functions as static in megaraid/megaraid_sas_fusion.c Saxena, Sumit
2014-03-29 18:18 ` [PATCH 30/55] scsi: Mark functions as static in megaraid/megaraid_sas_fp.c Rashika Kheria
2014-04-11  6:05   ` Saxena, Sumit
2014-03-29 18:19 ` [PATCH 31/55] scsi: Mark functions as static in mvsas/mv_sas.c Rashika Kheria
2014-03-29 18:20 ` [PATCH 32/55] scsi: Mark functions as static in mvsas/mv_64xx.c Rashika Kheria
2014-03-29 18:22 ` [PATCH 33/55] scsi: Mark functions as static in mvsas/mv_94xx.c Rashika Kheria
2014-03-29 18:23 ` [PATCH 34/55] scsi: Mark function as static in pm8001/pm8001_init.c Rashika Kheria
2014-03-29 18:24 ` [PATCH 35/55] scsi: Mark function as static in pm8001/pm8001_sas.c Rashika Kheria
2014-03-29 18:25 ` [PATCH 36/55] scsi: Mark function as static in pm8001/pm8001_hwi.c Rashika Kheria
2014-03-29 18:26 ` [PATCH 37/55] scsi: Mark function as static in pm8001/pm80xx_hwi.c Rashika Kheria
2014-03-29 18:27 ` [PATCH 38/55] scsi: Mark function as static in qla2xxx/qla_bsg.c Rashika Kheria
2014-03-29 18:28 ` [PATCH 39/55] scsi: Mark functions as static in qla2xxx/qla_iocb.c Rashika Kheria
2014-03-29 18:29 ` [PATCH 40/55] scsi: Mark function as static in qla2xxx/qla_nx.c Rashika Kheria
2014-03-29 18:31 ` [PATCH 41/55] scsi: Mark functions as static in qla2xxx/qla_nx2.c Rashika Kheria
2014-03-29 18:32 ` [PATCH 42/55] scsi: Mark function as static in scsi_transport_fc.c Rashika Kheria
2014-03-29 18:35 ` [PATCH 43/55] scsi: Mark function as static in scsi_transport_iscsi.c Rashika Kheria
2014-03-29 18:37 ` [PATCH 44/55] scsi: Mark function as static in scsi/libiscsi.c Rashika Kheria
2014-03-29 18:39 ` [PATCH 45/55] scsi: Mark funtion as static in hpsa.c Rashika Kheria
2014-03-29 18:40 ` [PATCH 46/55] scsi: Mark functions as static in gdth.c Rashika Kheria
2014-03-29 18:43 ` [PATCH 47/55] scsi: Mark functions as static in scsi/pmcraid.c Rashika Kheria
2014-03-29 18:44 ` [PATCH 48/55] scsi: Mark function as static in scsi_debug.c Rashika Kheria
2014-03-29 18:45 ` [PATCH 49/55] scsi: Move prototype declaration to header file scsi_priv.h from scsi_scan.c Rashika Kheria
2014-03-29 18:46 ` [PATCH 50/55] scsi: Mark function and macro definition as static in be2iscsi/be_main.c Rashika Kheria
2014-03-29 18:47 ` [PATCH 51/55] scsi: Move prototype declaration to header file megaraid/megaraid_sas_fusion.h from megaraid/megaraid_sas_base.c Rashika Kheria
2014-04-11  6:06   ` Saxena, Sumit
2014-03-29 18:48 ` [PATCH 52/55] scsi: Move prototype declaration to header file megaraid/megaraid_sas.h from megaraid/megaraid_sas_fusion.c Rashika Kheria
2014-04-11  6:10   ` Saxena, Sumit
2014-03-29 18:49 ` [PATCH 53/55] scsi: Mark functions as static in ufs/ufshcd.c Rashika Kheria
2014-03-29 18:50 ` [PATCH 54/55] scsi: Add prototype declaration to header file ufs/ufshcd.h Rashika Kheria
2014-03-29 18:51 ` [PATCH 55/55] scsi: Mark functions as static in bfa/bfad_bsg.c Rashika Kheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0017455228e59c42db9004e315b69e763e25aa3.1396114898.git.rashika.kheria@gmail.com \
    --to=rashika.kheria@gmail.com \
    --cc=JBottomley@parallels.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=megaraidlinux@lsi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®