From: Krzysztof Kozlowski <krzk@kernel.org>
To: cy_huang@richtek.com, Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: supply: Add Richtek RT9756 smart cap divider charger
Date: Tue, 29 Jul 2025 17:40:32 +0200 [thread overview]
Message-ID: <3603a744-e898-49ef-968a-2388e14cae54@kernel.org> (raw)
In-Reply-To: <3fa997b42b4aec43fc182a043cf521f7e3e7fcb3.1753759794.git.cy_huang@richtek.com>
On 29/07/2025 06:21, cy_huang@richtek.com wrote:
> +
> + shunt-resistor-micro-ohms:
> + description: Battery current sense resistor mounted.
> + default: 2000
> +
> +required:
> + - compatible
> + - reg
> + - wakeup-source
Why do you require this? I cannot find any use of it, so maybe I missed
some change in Linux code (and that's second question like that for
Richtek, so refer to your other patchsets for contexr).
> + - interrupts
> +
Missing ref to power supply.
> +additionalProperties: false
> +
unevaluated instead
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-29 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 4:21 [PATCH 0/3] Add Richtek RT9756 Smart-Cap dividor charger cy_huang
2025-07-29 4:21 ` [PATCH 1/3] dt-bindings: power: supply: Add Richtek RT9756 smart cap divider charger cy_huang
2025-07-29 15:40 ` Krzysztof Kozlowski [this message]
2025-07-30 2:07 ` ChiYuan Huang
2025-07-30 7:39 ` Krzysztof Kozlowski
2025-07-30 7:50 ` Krzysztof Kozlowski
2025-07-30 9:06 ` cy_huang
2025-07-29 4:21 ` [PATCH 2/3] power: supply: rt9756: " cy_huang
2025-07-29 4:21 ` [PATCH 3/3] Documentation: power: rt9756: Document exported sysfs entries cy_huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3603a744-e898-49ef-968a-2388e14cae54@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome