From: ChiYuan Huang <cy_huang@richtek.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: power: supply: Add Richtek RT9756 smart cap divider charger
Date: Wed, 30 Jul 2025 10:07:16 +0800 [thread overview]
Message-ID: <aIl+VKFURqFfXKz3@git-send.richtek.com> (raw)
In-Reply-To: <3603a744-e898-49ef-968a-2388e14cae54@kernel.org>
On Tue, Jul 29, 2025 at 05:40:32PM +0200, Krzysztof Kozlowski wrote:
> On 29/07/2025 06:21, cy_huang@richtek.com wrote:
> > +
> > + shunt-resistor-micro-ohms:
> > + description: Battery current sense resistor mounted.
> > + default: 2000
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - wakeup-source
>
> Why do you require this? I cannot find any use of it, so maybe I missed
> some change in Linux code (and that's second question like that for
> Richtek, so refer to your other patchsets for contexr).
>
This will mark the interrupt as wakeup capable.
https://elixir.bootlin.com/linux/v6.16/source/drivers/i2c/i2c-core-of.c#L57
https://elixir.bootlin.com/linux/v6.16/source/drivers/i2c/i2c-core-base.c#L547
> > + - interrupts
> > +
>
> Missing ref to power supply.
>
> > +additionalProperties: false
> > +
>
Ack, will add the below lines to the document for next revision.
allOf:
- $ref: power-supply.yaml#
> unevaluated instead
>
Ack.
Thx.
next prev parent reply other threads:[~2025-07-30 2:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 4:21 [PATCH 0/3] Add Richtek RT9756 Smart-Cap dividor charger cy_huang
2025-07-29 4:21 ` [PATCH 1/3] dt-bindings: power: supply: Add Richtek RT9756 smart cap divider charger cy_huang
2025-07-29 15:40 ` Krzysztof Kozlowski
2025-07-30 2:07 ` ChiYuan Huang [this message]
2025-07-30 7:39 ` Krzysztof Kozlowski
2025-07-30 7:50 ` Krzysztof Kozlowski
2025-07-30 9:06 ` cy_huang
2025-07-29 4:21 ` [PATCH 2/3] power: supply: rt9756: " cy_huang
2025-07-29 4:21 ` [PATCH 3/3] Documentation: power: rt9756: Document exported sysfs entries cy_huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIl+VKFURqFfXKz3@git-send.richtek.com \
--to=cy_huang@richtek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome