From: Yang Jihong <yangjihong1@huawei.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Yao Jin <yao.jin@linux.intel.com>,
<gustavoars@kernel.org>, <mliska@suse.cz>,
linux-kernel <linux-kernel@vger.kernel.org>,
<zhangjinhao2@huawei.com>
Subject: Re: [PATCH] perf annotate: Fix sample events lost in stdio mode
Date: Fri, 12 Mar 2021 18:20:03 +0800 [thread overview]
Message-ID: <360667d9-f0cc-866c-b0b9-b37dd85a9c45@huawei.com> (raw)
In-Reply-To: <CAM9d7ciM6bZmYepRCe_YY7mYZGbvrpwF7A_oCngM9GMoxPXS6A@mail.gmail.com>
Hello,
On 2021/3/12 16:39, Namhyung Kim wrote:
> On Fri, Mar 12, 2021 at 4:19 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>>
>>
>> Hello,
>> On 2021/3/12 13:49, Namhyung Kim wrote:
>>> Hi,
>>>
>>> On Fri, Mar 12, 2021 at 12:24 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>>>>
>>>> Hello, Namhyung
>>>>
>>>> On 2021/3/11 22:42, Namhyung Kim wrote:
>>>>> Hi,
>>>>>
>>>>> On Thu, Mar 11, 2021 at 5:48 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> On 2021/3/6 16:28, Yang Jihong wrote:
>>>>>>> In hist__find_annotations function, since have a hist_entry per IP for the same
>>>>>>> symbol, we free notes->src to signal already processed this symbol in stdio mode;
>>>>>>> when annotate, entry will skipped if notes->src is NULL to avoid repeated output.
>>>>>
>>>>> I'm not sure it's still true that we have a hist_entry per IP.
>>>>> Afaik the default sort key is comm,dso,sym which means it should have a single
>>>>> hist_entry for each symbol. It seems like an old comment..
>>>>>
>>>> Emm, yes, we have a hist_entry for per IP.
>>>> a member named "sym" in struct "hist_entry" points to symbol,
>>>> different IP may point to the same symbol.
>>>
>>> Are you sure about this? It seems like a bug then.
>>>
>> Yes, now each IP corresponds to a hist_entry :)
>>
>> Last week I found that some sample events were missing when perf
>> annotate in stdio mode, so I went through the annotate code carefully.
>>
>> The event handling process is as follows:
>> process_sample_event
>> evsel_add_sample
>> hists__add_entry
>> __hists__add_entry
>> hists__findnew_entry
>> hist_entry__new -> here allock new hist_entry
>
> Yeah, so this is for a symbol.
>
>>
>> hist_entry__inc_addr_samples
>> symbol__inc_addr_samples
>> symbol__hists
>> annotated_source__new -> here alloc annotate soruce
>> annotated_source__alloc_histograms -> here alloc histograms
>
> This should be for each IP (ideally it should be per instruction).
>
>>
>> By bugs, do you mean there's something wrong?
>
> No. I think we were saying about different things. :)
>
OK, :)
>
>>>>> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
>>>>> index a23ba6bb99b6..a91fe45bd69f 100644
>>>>> --- a/tools/perf/builtin-annotate.c
>>>>> +++ b/tools/perf/builtin-annotate.c
>>>>> @@ -374,13 +374,6 @@ static void hists__find_annotations(struct hists *hists,
>>>>> } else {
>>>>> hist_entry__tty_annotate(he, evsel, ann);
>>>>> nd = rb_next(nd);
>>>>> - /*
>>>>> - * Since we have a hist_entry per IP for the same
>>>>> - * symbol, free he->ms.sym->src to signal we already
>>>>> - * processed this symbol.
>>>>> - */
>>>>> - zfree(¬es->src->cycles_hist);
>>>>> - zfree(¬es->src);
>>>>> }
>>>>> }
>>>>> }
>>>>>
>>>> This solution may have the following problem:
>>>> For example, if two sample events are in two different processes but in
>>>> the same symbol, repeated output may occur.
>>>> Therefore, a flag is required to indicate whether the symbol has been
>>>> processed to avoid repeated output.
>>>
>>> Hmm.. ok. Yeah we don't care about the processes here.
>>> Then we should remove it from the sort key like below:
>>>
>>> @@ -624,6 +617,7 @@ int cmd_annotate(int argc, const char **argv)
>>> if (setup_sorting(annotate.session->evlist) < 0)
>>> usage_with_options(annotate_usage, options);
>>> } else {
>>> + sort_order = "dso,symbol";
>>> if (setup_sorting(NULL) < 0)
>>> usage_with_options(annotate_usage, options);
>>> }
>>>
>>>
>> Are you referring to this solution?
>> --- a/tools/perf/builtin-annotate.c
>> +++ b/tools/perf/builtin-annotate.c
>> @@ -374,13 +374,6 @@ static void hists__find_annotations(struct hists
>> *hists,
>> } else {
>> hist_entry__tty_annotate(he, evsel, ann);
>> nd = rb_next(nd);
>> - /*
>> - * Since we have a hist_entry per IP for the same
>> - * symbol, free he->ms.sym->src to signal we already
>> - * processed this symbol.
>> - */
>> - zfree(¬es->src->cycles_hist);
>> - zfree(¬es->src);
>> }
>> }
>> }
>> @@ -624,6 +617,7 @@ int cmd_annotate(int argc, const char **argv)
>> if (setup_sorting(annotate.session->evlist) < 0)
>> usage_with_options(annotate_usage, options);
>> } else {
>> + sort_order = "dso,symbol";
>> if (setup_sorting(NULL) < 0)
>> usage_with_options(annotate_usage, options);
>> }
>> It seems to be a better solution without adding new member.
>> I just tested it and it works.
>>
>> If we decide to use this solution, I'll resubmit a v3 patch.
>
> I prefer changing the sort order (and removing the zfree and comments).
>
OK, I'll submit a v3 patch based on the "changing the sort order" solution.
Thanks,
Yang
> Thanks,
> Namhyung
> .
>
next prev parent reply other threads:[~2021-03-12 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 8:28 Yang Jihong
2021-03-11 8:48 ` Yang Jihong
2021-03-11 14:42 ` Namhyung Kim
2021-03-12 3:24 ` Yang Jihong
2021-03-12 5:49 ` Namhyung Kim
2021-03-12 7:18 ` Yang Jihong
2021-03-12 8:39 ` Namhyung Kim
2021-03-12 10:20 ` Yang Jihong [this message]
2021-03-13 2:00 ` Yang Jihong
2021-03-13 2:23 ` Yang Jihong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=360667d9-f0cc-866c-b0b9-b37dd85a9c45@huawei.com \
--to=yangjihong1@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=gustavoars@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
--cc=zhangjinhao2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®