mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Waiman Long <longman@redhat.com>
Subject: Re: [patch 22/25] debugobjects: Move pool statistics into global_pool struct
Date: Thu, 10 Oct 2024 17:50:40 +0800	[thread overview]
Message-ID: <365d6eb6-7a35-a8a3-1942-2a931a6d9f5d@huawei.com> (raw)
In-Reply-To: <20241007164914.318776207@linutronix.de>



On 2024/10/8 0:50, Thomas Gleixner wrote:
> Keep it along with the pool as that's a hot cache line anyway and it makes
> the code more comprehensible.

Reviewed-by: Zhen Lei <thunder.leizhen@huawei.com>

> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  lib/debugobjects.c |   85 +++++++++++++++++++++++++++++++----------------------
>  1 file changed, 51 insertions(+), 34 deletions(-)
> 
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -47,11 +47,18 @@ struct debug_bucket {
>  	raw_spinlock_t		lock;
>  };
>  
> +struct pool_stats {
> +	unsigned int		cur_used;
> +	unsigned int		max_used;
> +	unsigned int		min_fill;
> +};
> +
>  struct obj_pool {
>  	struct hlist_head	objects;
>  	unsigned int		cnt;
>  	unsigned int		min_cnt;
>  	unsigned int		max_cnt;
> +	struct pool_stats	stats;
>  } ____cacheline_aligned;
>  
>  
> @@ -66,8 +73,11 @@ static struct debug_obj		obj_static_pool
>  static DEFINE_RAW_SPINLOCK(pool_lock);
>  
>  static struct obj_pool pool_global = {
> -	.min_cnt	= ODEBUG_POOL_MIN_LEVEL,
> -	.max_cnt	= ODEBUG_POOL_SIZE,
> +	.min_cnt		= ODEBUG_POOL_MIN_LEVEL,
> +	.max_cnt		= ODEBUG_POOL_SIZE,
> +	.stats			= {
> +		.min_fill	= ODEBUG_POOL_SIZE,
> +	},
>  };
>  
>  static struct obj_pool pool_to_free = {
> @@ -76,16 +86,6 @@ static struct obj_pool pool_to_free = {
>  
>  static HLIST_HEAD(pool_boot);
>  
> -/*
> - * Because of the presence of percpu free pools, obj_pool_free will
> - * under-count those in the percpu free pools. Similarly, obj_pool_used
> - * will over-count those in the percpu free pools. Adjustments will be
> - * made at debug_stats_show(). Both obj_pool_min_free and obj_pool_max_used
> - * can be off.
> - */
> -static int __data_racy		obj_pool_min_free = ODEBUG_POOL_SIZE;
> -static int			obj_pool_used;
> -static int __data_racy		obj_pool_max_used;
>  static bool			obj_freeing;
>  
>  static int __data_racy			debug_objects_maxchain __read_mostly;
> @@ -231,6 +231,19 @@ static struct debug_obj *__alloc_object(
>  	return obj;
>  }
>  
> +static void pcpu_refill_stats(void)
> +{
> +	struct pool_stats *stats = &pool_global.stats;
> +
> +	WRITE_ONCE(stats->cur_used, stats->cur_used + ODEBUG_BATCH_SIZE);
> +
> +	if (stats->cur_used > stats->max_used)
> +		stats->max_used = stats->cur_used;
> +
> +	if (pool_global.cnt < stats->min_fill)
> +		stats->min_fill = pool_global.cnt;
> +}
> +
>  static struct debug_obj *pcpu_alloc(void)
>  {
>  	struct obj_pool *pcp = this_cpu_ptr(&pool_pcpu);
> @@ -250,13 +263,7 @@ static struct debug_obj *pcpu_alloc(void
>  			if (!pool_move_batch(pcp, &pool_global))
>  				return NULL;
>  		}
> -		obj_pool_used += ODEBUG_BATCH_SIZE;
> -
> -		if (obj_pool_used > obj_pool_max_used)
> -			obj_pool_max_used = obj_pool_used;
> -
> -		if (pool_global.cnt < obj_pool_min_free)
> -			obj_pool_min_free = pool_global.cnt;
> +		pcpu_refill_stats();
>  	}
>  }
>  
> @@ -285,7 +292,7 @@ static void pcpu_free(struct debug_obj *
>  	/* Try to fit the batch into the pool_global first */
>  	if (!pool_move_batch(&pool_global, pcp))
>  		pool_move_batch(&pool_to_free, pcp);
> -	obj_pool_used -= ODEBUG_BATCH_SIZE;
> +	WRITE_ONCE(pool_global.stats.cur_used, pool_global.stats.cur_used - ODEBUG_BATCH_SIZE);
>  }
>  
>  static void free_object_list(struct hlist_head *head)
> @@ -1074,23 +1081,33 @@ void debug_check_no_obj_freed(const void
>  
>  static int debug_stats_show(struct seq_file *m, void *v)
>  {
> -	int cpu, obj_percpu_free = 0;
> +	unsigned int cpu, pool_used, pcp_free = 0;
>  
> +	/*
> +	 * pool_global.stats.cur_used is the number of batches currently
> +	 * handed out to per CPU pools. Convert it to number of objects
> +	 * and subtract the number of free objects in the per CPU pools.
> +	 * As this is lockless the number is an estimate.
> +	 */
>  	for_each_possible_cpu(cpu)
> -		obj_percpu_free += per_cpu(pool_pcpu.cnt, cpu);
> +		pcp_free += per_cpu(pool_pcpu.cnt, cpu);
>  
> -	seq_printf(m, "max_chain     :%d\n", debug_objects_maxchain);
> -	seq_printf(m, "max_checked   :%d\n", debug_objects_maxchecked);
> -	seq_printf(m, "warnings      :%d\n", debug_objects_warnings);
> -	seq_printf(m, "fixups        :%d\n", debug_objects_fixups);
> -	seq_printf(m, "pool_free     :%d\n", pool_count(&pool_global) + obj_percpu_free);
> -	seq_printf(m, "pool_pcp_free :%d\n", obj_percpu_free);
> -	seq_printf(m, "pool_min_free :%d\n", obj_pool_min_free);
> -	seq_printf(m, "pool_used     :%d\n", obj_pool_used - obj_percpu_free);
> -	seq_printf(m, "pool_max_used :%d\n", obj_pool_max_used);
> -	seq_printf(m, "on_free_list  :%d\n", pool_count(&pool_to_free));
> -	seq_printf(m, "objs_allocated:%d\n", debug_objects_allocated);
> -	seq_printf(m, "objs_freed    :%d\n", debug_objects_freed);
> +	pool_used = data_race(pool_global.stats.cur_used);
> +	pcp_free = min(pool_used, pcp_free);
> +	pool_used -= pcp_free;
> +
> +	seq_printf(m, "max_chain     : %d\n", debug_objects_maxchain);
> +	seq_printf(m, "max_checked   : %d\n", debug_objects_maxchecked);
> +	seq_printf(m, "warnings      : %d\n", debug_objects_warnings);
> +	seq_printf(m, "fixups        : %d\n", debug_objects_fixups);
> +	seq_printf(m, "pool_free     : %u\n", pool_count(&pool_global) + pcp_free);
> +	seq_printf(m, "pool_pcp_free : %u\n", pcp_free);
> +	seq_printf(m, "pool_min_free : %u\n", data_race(pool_global.stats.min_fill));
> +	seq_printf(m, "pool_used     : %u\n", pool_used);
> +	seq_printf(m, "pool_max_used : %u\n", data_race(pool_global.stats.max_used));
> +	seq_printf(m, "on_free_list  : %u\n", pool_count(&pool_to_free));
> +	seq_printf(m, "objs_allocated: %d\n", debug_objects_allocated);
> +	seq_printf(m, "objs_freed    : %d\n", debug_objects_freed);
>  	return 0;
>  }
>  DEFINE_SHOW_ATTRIBUTE(debug_stats);
> 
> .
> 

-- 
Regards,
  Zhen Lei

  reply	other threads:[~2024-10-10  9:50 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-07 16:49 [patch 00/25] debugobjects: Rework object handling Thomas Gleixner
2024-10-07 16:49 ` [patch 01/25] debugobjects: Delete a piece of redundant code Thomas Gleixner
2024-10-07 16:49 ` [patch 02/25] debugobjects: Collect newly allocated objects in a list to reduce lock contention Thomas Gleixner
2024-10-07 16:49 ` [patch 03/25] debugobjects: Dont destroy kmem cache in init() Thomas Gleixner
2024-10-10  2:14   ` Leizhen (ThunderTown)
2024-10-10 11:46     ` Thomas Gleixner
2024-10-10 13:31       ` Leizhen (ThunderTown)
2024-10-11 20:37         ` Thomas Gleixner
2024-10-12  1:50           ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:49 ` [patch 04/25] debugobjects: Remove pointless hlist initialization Thomas Gleixner
2024-10-10  2:19   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:49 ` [patch 05/25] debugobjects: Dont free objects directly on CPU hotplug Thomas Gleixner
2024-10-10  2:33   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:49 ` [patch 06/25] debugobjects: Reuse put_objects() on OOM Thomas Gleixner
2024-10-10  2:38   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:49 ` [patch 07/25] debugobjects: Remove pointless debug printk Thomas Gleixner
2024-10-10  2:44   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 08/25] debugobjects: Provide and use free_object_list() Thomas Gleixner
2024-10-10  2:54   ` Leizhen (ThunderTown)
2024-10-11 20:40     ` Thomas Gleixner
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 09/25] debugobjects: Make debug_objects_enabled bool Thomas Gleixner
2024-10-10  3:00   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 10/25] debugobjects: Reduce parallel pool fill attempts Thomas Gleixner
2024-10-07 16:50 ` [patch 11/25] debugobjects: Move pools into a datastructure Thomas Gleixner
2024-10-10  3:47   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 12/25] debugobjects: Use separate list head for boot pool Thomas Gleixner
2024-10-10  4:04   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 13/25] debugobjects: Rename and tidy up per CPU pools Thomas Gleixner
2024-10-10  6:23   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 14/25] debugobjects: Move min/max count into pool struct Thomas Gleixner
2024-10-10  6:26   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 15/25] debugobjects: Rework object allocation Thomas Gleixner
2024-10-10  6:39   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 16/25] debugobjects: Rework object freeing Thomas Gleixner
2024-10-10  7:39   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 17/25] debugobjects: Rework free_object_work() Thomas Gleixner
2024-10-10  8:10   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 18/25] debugobjects: Use static key for boot pool selection Thomas Gleixner
2024-10-10  8:12   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 19/25] debugobjects: Prepare for batching Thomas Gleixner
2024-10-10  8:15   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 20/25] debugobjects: Prepare kmem_cache allocations " Thomas Gleixner
2024-10-10  8:40   ` Leizhen (ThunderTown)
2024-10-11 20:47     ` Thomas Gleixner
2024-10-12  2:02       ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 21/25] debugobjects: Implement batch processing Thomas Gleixner
2024-10-10  9:39   ` Leizhen (ThunderTown)
2024-10-11 20:48     ` Thomas Gleixner
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 22/25] debugobjects: Move pool statistics into global_pool struct Thomas Gleixner
2024-10-10  9:50   ` Leizhen (ThunderTown) [this message]
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 23/25] debugobjects: Double the per CPU slots Thomas Gleixner
2024-10-10  9:51   ` Leizhen (ThunderTown)
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 24/25] debugobjects: Refill per CPU pool more agressively Thomas Gleixner
2024-10-10 10:02   ` Leizhen (ThunderTown)
2024-10-11 20:49     ` Thomas Gleixner
2024-10-15 15:36   ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner
2024-10-07 16:50 ` [patch 25/25] debugobjects: Track object usage to avoid premature freeing of objects Thomas Gleixner
2024-10-10 13:13   ` Leizhen (ThunderTown)
2024-10-13 18:45     ` Thomas Gleixner
2024-10-14  1:46       ` Leizhen (ThunderTown)
2024-10-15 15:36       ` [tip: core/debugobjects] " tip-bot2 for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=365d6eb6-7a35-a8a3-1942-2a931a6d9f5d@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®