mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Wilson" <mcs6502@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: pci_ids.h - duplicate entry and many out of order definitions
Date: Wed, 30 Jul 2008 09:00:09 +1000	[thread overview]
Message-ID: <3666888f0807291600n3c259c20wccc4896b2df3d0d8@mail.gmail.com> (raw)

I was browsing the pci_ids.h file and came across a duplicate entry
for PCI_VENDOR_ID_RDC. This prompted me to look further and I found a
number of out-of-order definitions (based on the comment at the head
of the file that indicates that they should be sorted). I decided to
write a script to check this and it found 74 "errors".

1) Is it worth my time generating a patch to fix all these mis-orderings?
2) Should it be one large patch or many small ones (eg one per PCI_VENDOR)?
3) Is there a maintainer for this file?

Here is an example of the output my script generates (on the
2.6.27-rc1 pci_ids.h file):

line 153: PCI_DEVICE_ID_COMPAQ_NETEL10	0xae34
line 154: PCI_DEVICE_ID_COMPAQ_TRIFLEX_IDE	0xae33

line 160: PCI_DEVICE_ID_COMPAQ_CISSB	0xb178
line 161: PCI_DEVICE_ID_COMPAQ_CISSC	0x46

line 193: PCI_DEVICE_ID_LSI_FC939X	0x0642
line 194: PCI_DEVICE_ID_LSI_FC949X	0x0640

line 195: PCI_DEVICE_ID_LSI_FC949ES	0x0646
line 196: PCI_DEVICE_ID_LSI_FC919X	0x0628

line 199: PCI_DEVICE_ID_LSI_63C815	0x1000
line 200: PCI_DEVICE_ID_LSI_SAS1064	0x0050

line 201: PCI_DEVICE_ID_LSI_SAS1064R	0x0411
line 202: PCI_DEVICE_ID_LSI_SAS1066	0x005E

             reply	other threads:[~2008-07-29 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-29 23:00 David Wilson [this message]
2008-07-29 23:26 ` Alan Cox
2008-07-29 23:43 ` Grant Coady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3666888f0807291600n3c259c20wccc4896b2df3d0d8@mail.gmail.com \
    --to=mcs6502@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®