From: Grant Coady <grant_lkml@dodo.com.au>
To: "David Wilson" <mcs6502@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: pci_ids.h - duplicate entry and many out of order definitions
Date: Wed, 30 Jul 2008 09:43:28 +1000 [thread overview]
Message-ID: <sdav849lsbk5k4m3attufmvvu7cl11mh26@4ax.com> (raw)
In-Reply-To: <3666888f0807291600n3c259c20wccc4896b2df3d0d8@mail.gmail.com>
On Wed, 30 Jul 2008 09:00:09 +1000, "David Wilson" <mcs6502@gmail.com> wrote:
>I was browsing the pci_ids.h file and came across a duplicate entry
>for PCI_VENDOR_ID_RDC. This prompted me to look further and I found a
>number of out-of-order definitions (based on the comment at the head
>of the file that indicates that they should be sorted). I decided to
>write a script to check this and it found 74 "errors".
>
>1) Is it worth my time generating a patch to fix all these mis-orderings?
>2) Should it be one large patch or many small ones (eg one per PCI_VENDOR)?
>3) Is there a maintainer for this file?
Dunno about a maintainer, I did a cleanup over the thing a couple years
ago and GregKH was taking the patches.
Also need to check that people not making PCI_* names up with macros in
drivers as that reduces grep usability.
Think there's a new PCI maintainer now?
Grant.
prev parent reply other threads:[~2008-07-29 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 23:00 David Wilson
2008-07-29 23:26 ` Alan Cox
2008-07-29 23:43 ` Grant Coady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sdav849lsbk5k4m3attufmvvu7cl11mh26@4ax.com \
--to=grant_lkml@dodo.com.au \
--cc=gcoady.lk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcs6502@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®